Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore](runtime-filter) improve rf::debug_string and add some check about rf #44697

Merged
merged 2 commits into from
Nov 29, 2024
Merged

[Chore](runtime-filter) improve rf::debug_string and add some check about rf #44697

merged 2 commits into from
Nov 29, 2024

Conversation

BiteTheDDDDt
Copy link
Contributor

What problem does this PR solve?

improve rf::debug_string and add some check about rf

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 797ac3b into apache:master Nov 29, 2024
23 of 25 checks passed
@BiteTheDDDDt BiteTheDDDDt mentioned this pull request Dec 2, 2024
Merged
16 tasks
BiteTheDDDDt added a commit that referenced this pull request Dec 2, 2024
@BiteTheDDDDt
[Bug](runtime-filter) check rf dependency is set and fix wrong throw …
8514df8 
…status (#44838)

### What problem does this PR solve?
1. check rf dependency is set
2. fix wrong throw status, introduced by
#44697
3. catch throw exception on buildsink::close
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangstar333 zhangstar333 zhangstar333 approved these changes

@Mryange Mryange Mryange approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x dev/2.1.x-conflict dev/3.0.x dev/3.0.x-conflict reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BiteTheDDDDt @Mryange @zhangstar333