-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test](load) injection cases should check Exception is thrown #44713
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 40029 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 196923 ms
|
ClickBench: Total hot run time: 32.39 s
|
run buildall |
TPC-H: Total hot run time: 40467 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 198452 ms
|
ClickBench: Total hot run time: 33.88 s
|
} catch(Exception e) { | ||
logger.info(e.getMessage()) | ||
assertTrue(e.getMessage().contains("wait flush token back pressure time is more than load_stream_max_wait_flush_token_time")) | ||
//assertTrue(e.getMessage().contains("Communications link failure")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change the error message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the previous error message seems incorrect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is re-written to test the timeout when flush wait time exceeds load_stream_max_wait_flush_token_time_ms
.
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
764d4ff
to
6d6232a
Compare
6d6232a
to
495f123
Compare
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40137 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 191483 ms
|
ClickBench: Total hot run time: 33.3 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…rown #44713 (#45270) Cherry-picked from #44713 Co-authored-by: Kaijie Chen <[email protected]>
What problem does this PR solve?
Problem Summary:
Some injection cases did not check exception is thrown.
This may cause false positives.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)