Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug](runtime-filter) fix wrong build_bf_exactly when sync filter size disabled #44716

Merged
merged 5 commits into from
Dec 3, 2024
Merged

[Bug](runtime-filter) fix wrong build_bf_exactly when sync filter size disabled #44716

merged 5 commits into from
Dec 3, 2024

Conversation

BiteTheDDDDt
Copy link
Contributor

What problem does this PR solve?

fix wrong build_bf_exactly when sync filter size disabled

introduced by #44169

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

HappenLee
HappenLee approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

PR approved by anyone and no changes requested.

HappenLee
HappenLee approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BiteTheDDDDt BiteTheDDDDt merged commit 0d48863 into apache:master Dec 3, 2024
24 of 27 checks passed
BiteTheDDDDt added a commit that referenced this pull request Jan 14, 2025
@BiteTheDDDDt
[Bug](runtime-filter) fix wrong build_bf_exactly when sync filter siz…
7a1de39 
…e disabled (#44716)

fix wrong build_bf_exactly when sync filter size disabled

introduced by #44169
@BiteTheDDDDt BiteTheDDDDt mentioned this pull request Jan 14, 2025
Merged
BiteTheDDDDt added a commit that referenced this pull request Jan 14, 2025
@BiteTheDDDDt
[Bug](runtime-filter) fix wrong build_bf_exactly when sync filter siz… …
9b3fb4a 
…#44716 (#46965)

pick from #44716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriel39 Gabriel39 Gabriel39 approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BiteTheDDDDt @HappenLee @Gabriel39