Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor](scan) Delete unused function in ScanNode #44733

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Nov 28, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40421 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9cf52aad3f7e3d2bfce6fc1888e93b25d595e3ed, data reload: false

------ Round 1 ----------------------------------
q1	17759	7679	7377	7377
q2	2067	181	164	164
q3	10669	1100	1163	1100
q4	10370	751	727	727
q5	7593	2753	2709	2709
q6	246	156	150	150
q7	991	625	619	619
q8	9225	1899	1966	1899
q9	6767	6528	6617	6528
q10	7080	2343	2317	2317
q11	469	286	261	261
q12	429	234	229	229
q13	17809	3031	3021	3021
q14	247	222	212	212
q15	574	543	526	526
q16	684	610	596	596
q17	1001	663	602	602
q18	7398	6581	6825	6581
q19	1340	1058	1015	1015
q20	473	195	184	184
q21	4209	3274	3377	3274
q22	388	330	330	330
Total cold run time: 107788 ms
Total hot run time: 40421 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7305	7268	7285	7268
q2	328	234	235	234
q3	2919	2921	2950	2921
q4	2082	1875	1885	1875
q5	5646	5701	5737	5701
q6	234	148	149	148
q7	2279	1850	1808	1808
q8	3418	3551	3598	3551
q9	8998	9121	9010	9010
q10	3617	3568	3543	3543
q11	610	500	506	500
q12	815	580	617	580
q13	11266	3266	3279	3266
q14	306	288	296	288
q15	583	535	526	526
q16	704	644	656	644
q17	1874	1639	1619	1619
q18	8288	7674	7702	7674
q19	1740	1613	1551	1551
q20	2140	1901	1877	1877
q21	5633	5471	5425	5425
q22	719	593	588	588
Total cold run time: 71504 ms
Total hot run time: 60597 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197994 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9cf52aad3f7e3d2bfce6fc1888e93b25d595e3ed, data reload: false

query1	1252	950	960	950
query2	6246	2047	1962	1962
query3	11056	4510	4575	4510
query4	67065	28373	23674	23674
query5	5002	465	448	448
query6	394	185	181	181
query7	5488	302	299	299
query8	320	242	229	229
query9	8703	2747	2740	2740
query10	465	256	247	247
query11	17297	15130	15955	15130
query12	158	103	111	103
query13	1457	455	411	411
query14	10756	7918	7836	7836
query15	228	193	208	193
query16	7384	487	468	468
query17	1108	610	603	603
query18	1869	329	308	308
query19	202	188	154	154
query20	125	118	110	110
query21	213	109	102	102
query22	4803	4432	4551	4432
query23	34782	34482	34317	34317
query24	5784	2571	2500	2500
query25	482	376	389	376
query26	679	157	158	157
query27	1869	283	284	283
query28	4409	2522	2512	2512
query29	667	426	419	419
query30	212	166	152	152
query31	982	855	811	811
query32	66	53	56	53
query33	439	327	287	287
query34	932	517	529	517
query35	853	768	761	761
query36	1086	946	965	946
query37	118	76	73	73
query38	4664	4448	4486	4448
query39	1484	1453	1472	1453
query40	213	106	97	97
query41	47	41	45	41
query42	105	103	94	94
query43	537	486	499	486
query44	1208	842	820	820
query45	193	168	175	168
query46	1185	748	736	736
query47	2064	1913	1939	1913
query48	434	324	344	324
query49	751	385	401	385
query50	840	404	422	404
query51	7421	7120	7017	7017
query52	93	89	89	89
query53	260	183	181	181
query54	511	399	389	389
query55	80	79	80	79
query56	267	234	235	234
query57	1301	1162	1155	1155
query58	217	210	208	208
query59	3081	3093	2915	2915
query60	264	249	244	244
query61	105	107	110	107
query62	788	656	669	656
query63	214	194	197	194
query64	1406	686	628	628
query65	3276	3177	3203	3177
query66	706	305	296	296
query67	15938	15923	15593	15593
query68	4099	585	561	561
query69	431	252	251	251
query70	1207	1146	1158	1146
query71	353	247	240	240
query72	6421	4106	4092	4092
query73	753	368	357	357
query74	10327	9247	9096	9096
query75	3385	2659	2692	2659
query76	2008	1171	1056	1056
query77	462	282	277	277
query78	10660	9427	9409	9409
query79	2304	622	631	622
query80	1467	423	447	423
query81	507	228	233	228
query82	1289	121	128	121
query83	269	143	145	143
query84	281	71	67	67
query85	1048	305	298	298
query86	410	303	302	302
query87	4853	4581	4491	4491
query88	3851	2268	2201	2201
query89	420	294	297	294
query90	1972	184	185	184
query91	137	102	103	102
query92	68	51	52	51
query93	2938	554	550	550
query94	835	286	301	286
query95	345	266	245	245
query96	627	276	276	276
query97	2860	2686	2674	2674
query98	219	199	201	199
query99	1686	1308	1310	1308
Total cold run time: 323096 ms
Total hot run time: 197994 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.23 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9cf52aad3f7e3d2bfce6fc1888e93b25d595e3ed, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.22	0.07	0.08
query4	1.61	0.10	0.11
query5	0.43	0.40	0.41
query6	1.14	0.66	0.66
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.56	0.52	0.51
query10	0.58	0.55	0.56
query11	0.15	0.11	0.10
query12	0.14	0.11	0.11
query13	0.64	0.60	0.60
query14	2.73	2.74	2.69
query15	0.89	0.83	0.82
query16	0.40	0.40	0.39
query17	0.99	1.08	1.02
query18	0.23	0.22	0.20
query19	1.83	1.86	1.86
query20	0.02	0.01	0.02
query21	15.38	0.59	0.56
query22	2.47	2.61	2.78
query23	17.04	0.96	0.80
query24	3.12	0.80	1.15
query25	0.21	0.22	0.16
query26	0.50	0.14	0.14
query27	0.05	0.04	0.03
query28	10.53	1.11	1.08
query29	12.55	3.22	3.19
query30	0.25	0.06	0.06
query31	2.86	0.39	0.38
query32	3.25	0.47	0.48
query33	2.96	3.03	2.99
query34	16.83	4.48	4.47
query35	4.55	4.52	4.53
query36	0.65	0.50	0.48
query37	0.08	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.03	0.02
query40	0.17	0.12	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.4 s
Total hot run time: 33.23 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit 3ce581e into apache:master Dec 2, 2024
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants