Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore](binlog) Save table type in CreateTableRecord #44735

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[chore](binlog) Save table type in CreateTableRecord #44735

merged 1 commit into from
Dec 2, 2024

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Nov 28, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@w41ter
Copy link
Contributor Author

w41ter commented Nov 28, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39922 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8a0188f440b518f2e3526910c7d3c178544133d0, data reload: false

------ Round 1 ----------------------------------
q1	17763	7669	7275	7275
q2	2047	184	174	174
q3	10631	1067	1173	1067
q4	10555	700	863	700
q5	7624	2767	2749	2749
q6	252	149	147	147
q7	988	635	602	602
q8	9246	1894	1981	1894
q9	6645	6414	6507	6414
q10	7051	2336	2376	2336
q11	478	260	264	260
q12	418	215	213	213
q13	17783	3017	3010	3010
q14	239	204	233	204
q15	583	544	516	516
q16	690	579	587	579
q17	975	476	497	476
q18	7259	6720	6815	6720
q19	1341	1046	918	918
q20	459	181	177	177
q21	3957	3368	3174	3174
q22	385	317	326	317
Total cold run time: 107369 ms
Total hot run time: 39922 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7293	7233	7257	7233
q2	329	239	235	235
q3	2922	2833	2983	2833
q4	2036	1792	1829	1792
q5	5669	5678	5648	5648
q6	225	143	145	143
q7	2221	1804	1844	1804
q8	3398	3551	3505	3505
q9	9033	8983	9146	8983
q10	3630	3532	3543	3532
q11	594	514	492	492
q12	837	632	635	632
q13	10598	3281	3251	3251
q14	315	274	276	274
q15	572	538	537	537
q16	674	626	674	626
q17	1859	1643	1627	1627
q18	8459	7893	7629	7629
q19	2269	1593	1587	1587
q20	2099	1858	1878	1858
q21	5478	5484	5323	5323
q22	658	563	601	563
Total cold run time: 71168 ms
Total hot run time: 60107 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197381 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8a0188f440b518f2e3526910c7d3c178544133d0, data reload: false

query1	1259	950	943	943
query2	6277	2015	2047	2015
query3	10907	4377	4380	4377
query4	66753	29227	23561	23561
query5	4987	462	450	450
query6	409	186	185	185
query7	5617	306	292	292
query8	314	235	241	235
query9	9290	2757	2734	2734
query10	461	244	236	236
query11	17400	15350	16234	15350
query12	164	102	109	102
query13	1614	415	423	415
query14	10066	7607	7142	7142
query15	205	196	193	193
query16	7420	469	507	469
query17	1085	605	603	603
query18	1945	311	312	311
query19	242	163	173	163
query20	126	118	109	109
query21	208	104	110	104
query22	4736	4615	4572	4572
query23	34974	34567	34423	34423
query24	5332	2413	2425	2413
query25	502	391	382	382
query26	637	158	152	152
query27	1817	283	293	283
query28	4567	2504	2490	2490
query29	674	418	416	416
query30	216	192	151	151
query31	992	824	861	824
query32	70	58	56	56
query33	393	277	279	277
query34	925	522	503	503
query35	860	775	766	766
query36	1110	972	952	952
query37	122	100	81	81
query38	4543	4457	4448	4448
query39	1522	1463	1475	1463
query40	206	101	102	101
query41	44	44	41	41
query42	108	103	100	100
query43	539	484	500	484
query44	1169	831	817	817
query45	186	168	167	167
query46	1175	728	728	728
query47	2051	1912	1953	1912
query48	407	322	311	311
query49	730	381	386	381
query50	825	399	399	399
query51	7423	7173	7080	7080
query52	97	84	95	84
query53	250	180	189	180
query54	492	394	397	394
query55	78	74	74	74
query56	251	233	229	229
query57	1278	1199	1192	1192
query58	211	215	213	213
query59	3095	3185	3069	3069
query60	270	232	233	232
query61	107	105	107	105
query62	762	674	649	649
query63	212	183	191	183
query64	1360	669	690	669
query65	3339	3166	3196	3166
query66	693	304	308	304
query67	15875	15734	15671	15671
query68	4123	557	560	557
query69	420	253	255	253
query70	1193	1154	1117	1117
query71	376	267	249	249
query72	6461	4060	3723	3723
query73	766	355	365	355
query74	10316	9087	9191	9087
query75	3397	2660	2618	2618
query76	1966	1126	1143	1126
query77	463	276	270	270
query78	10538	9455	9396	9396
query79	2324	589	611	589
query80	1409	415	441	415
query81	508	225	224	224
query82	1262	123	121	121
query83	233	149	136	136
query84	280	77	69	69
query85	1004	291	298	291
query86	404	301	305	301
query87	4820	4631	4587	4587
query88	3811	2231	2216	2216
query89	420	309	285	285
query90	2078	188	189	188
query91	135	101	99	99
query92	68	47	55	47
query93	2932	527	527	527
query94	881	297	285	285
query95	350	244	244	244
query96	622	277	279	277
query97	2859	2657	2701	2657
query98	220	202	194	194
query99	1603	1302	1319	1302
Total cold run time: 322216 ms
Total hot run time: 197381 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.9 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8a0188f440b518f2e3526910c7d3c178544133d0, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.24	0.07	0.07
query4	1.61	0.10	0.11
query5	0.41	0.41	0.39
query6	1.14	0.67	0.65
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.58	0.51	0.50
query10	0.56	0.56	0.56
query11	0.14	0.12	0.11
query12	0.14	0.13	0.12
query13	0.61	0.60	0.59
query14	2.82	2.88	2.87
query15	0.90	0.82	0.82
query16	0.39	0.37	0.38
query17	0.97	0.96	1.07
query18	0.22	0.22	0.21
query19	1.95	1.82	1.95
query20	0.01	0.02	0.01
query21	15.37	0.60	0.55
query22	3.07	2.45	2.00
query23	17.17	0.95	0.89
query24	2.66	0.93	2.21
query25	0.30	0.25	0.09
query26	0.35	0.13	0.13
query27	0.05	0.04	0.04
query28	10.06	1.12	1.08
query29	12.59	3.21	3.19
query30	0.27	0.08	0.06
query31	2.84	0.38	0.38
query32	3.27	0.46	0.47
query33	2.96	3.09	3.09
query34	16.99	4.48	4.50
query35	4.52	4.51	4.52
query36	0.67	0.48	0.47
query37	0.10	0.06	0.06
query38	0.04	0.04	0.03
query39	0.04	0.02	0.03
query40	0.16	0.12	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.03
query43	0.04	0.03	0.04
Total cold run time: 106.47 s
Total hot run time: 32.9 s

dataroaring
dataroaring approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@w41ter w41ter merged commit 59ae800 into apache:master Dec 2, 2024
26 of 28 checks passed
@w41ter w41ter deleted the reduce_show_backup_restore_output_size branch December 2, 2024 02:43
github-actions bot pushed a commit that referenced this pull request Dec 2, 2024
@w41ter
[chore](binlog) Save table type in CreateTableRecord (#44735)
3a9a4c5
@github-actions github-actions bot mentioned this pull request Dec 2, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 2, 2024
@w41ter
[chore](binlog) Save table type in CreateTableRecord (#44735)
fd5953d
@github-actions github-actions bot mentioned this pull request Dec 2, 2024
Merged
dataroaring pushed a commit that referenced this pull request Dec 3, 2024
@github-actions @w41ter
branch-3.0: [chore](binlog) Save table type in CreateTableRecord #44735…
06d9a44 
… (#44835)

Cherry-picked from #44735

Co-authored-by: walter <[email protected]>
dataroaring pushed a commit that referenced this pull request Dec 3, 2024
@github-actions @w41ter
branch-2.1: [chore](binlog) Save table type in CreateTableRecord #44735…
4b7f5f8 
… (#44836)

Cherry-picked from #44735

Co-authored-by: walter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@w41ter @doris-robot @Yukang-Lian @dataroaring