Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](cluster key) 3.0 forbid mow cluster key #44737

Merged
merged 5 commits into from
Dec 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,9 @@ public void analyze(List<ColumnDef> cols) throws AnalysisException {
}

if (clusterKeysColumnNames != null) {
analyzeClusterKeys(cols);
// analyzeClusterKeys(cols);
// forbid cluster key in 3.0 temporarily
throw new AnalysisException("Cluster key is not supported");
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -777,6 +777,10 @@ private void validateKeyColumns() {
}
}

if (!clusterKeysColumnNames.isEmpty()) {
// forbid cluster key in 3.0 temporarily
throw new AnalysisException("Cluster key is not supported");
}
if (!clusterKeysColumnNames.isEmpty()) {
// the same code as KeysDesc#analyzeClusterKeys
if (Config.isCloudMode()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,13 @@ excludeSuites = "000_the_start_sentinel_do_not_touch," + // keep this line as th
"test_be_inject_publish_txn_fail," + // not a case for cloud mode, no need to run
"test_compaction_uniq_cluster_keys_with_delete," +
"test_compaction_uniq_keys_cluster_key," +
"test_pk_uk_case_cluster," +
"test_point_query_ck," +
"test_rowstore_ck," +
"test_point_query_partition_ck," +
"test_dump_image," +
"test_index_failure_injection," +
"test_information_schema_external," +
"test_pk_uk_case_cluster," +
"test_point_query_cluster_key," +
"test_profile," +
"test_publish_timeout," +
"test_refresh_mtmv," + // not supported yet
Expand Down
7 changes: 7 additions & 0 deletions regression-test/pipeline/p0/conf/regression-conf.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,12 @@ excludeGroups = ""
excludeSuites = "000_the_start_sentinel_do_not_touch," + // keep this line as the first line
"test_dump_image," +
"test_index_failure_injection," +
"test_compaction_uniq_cluster_keys_with_delete," +
"test_compaction_uniq_keys_cluster_key," +
"test_pk_uk_case_cluster," +
"test_point_query_ck," +
"test_rowstore_ck," +
"test_point_query_partition_ck," +
"test_profile," +
"test_refresh_mtmv," +
"test_spark_load," +
Expand All @@ -80,6 +86,7 @@ excludeDirectories = "000_the_start_sentinel_do_not_touch," + // keep this line
"cloud," +
"cloud_p0," +
"nereids_rules_p0/subquery," +
"unique_with_mow_c_p0," +
"workload_manager_p1," +
"zzz_the_end_sentinel_do_not_touch"// keep this line as the last line

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ suite("test_index_compaction_unique_keys_arr", "array_contains_inverted_index")
run_test.call(tableName)

// cluster key is not supported in cloud mode at branch-3.0
if (!isCloudMode) {
if (false) {
tableName = "test_index_compaction_unique_keys_arr_cluster_key"
sql """ DROP TABLE IF EXISTS ${tableName}; """
sql """
Expand Down
Loading