Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](nereids) fix NereidsCoordinator compute wrong result when exists CTE #44753

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

924060929
Copy link
Contributor

@924060929 924060929 commented Nov 28, 2024

What problem does this PR solve?

fix NereidsCoordinator compute wrong result when exists CTE, introduced by #41730

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39680 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 54658e6ed4d9f567b3b401f48899fc5cb0ee10d4, data reload: false

------ Round 1 ----------------------------------
q1	17599	7383	7263	7263
q2	2051	172	174	172
q3	10697	1095	1211	1095
q4	10540	670	726	670
q5	7612	2659	2712	2659
q6	235	150	149	149
q7	959	623	611	611
q8	9247	1809	1912	1809
q9	6763	6443	6484	6443
q10	6980	2301	2319	2301
q11	473	251	257	251
q12	425	214	212	212
q13	17791	3005	3011	3005
q14	230	206	212	206
q15	569	531	516	516
q16	673	609	576	576
q17	969	538	572	538
q18	7215	6554	6733	6554
q19	1326	1031	1060	1031
q20	465	179	177	177
q21	4229	3129	3129	3129
q22	377	313	320	313
Total cold run time: 107425 ms
Total hot run time: 39680 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7255	7207	7247	7207
q2	334	231	234	231
q3	2842	2793	2931	2793
q4	2095	1805	1804	1804
q5	5680	5653	5658	5653
q6	223	138	142	138
q7	2212	1814	1808	1808
q8	3404	3522	3481	3481
q9	9012	9048	8935	8935
q10	3606	3540	3542	3540
q11	580	510	493	493
q12	818	613	616	613
q13	11933	3292	3173	3173
q14	317	274	271	271
q15	583	549	525	525
q16	694	658	639	639
q17	1851	1609	1648	1609
q18	8264	7768	7818	7768
q19	1685	1545	1498	1498
q20	2128	1871	1881	1871
q21	5612	5342	5242	5242
q22	641	589	555	555
Total cold run time: 71769 ms
Total hot run time: 59847 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197162 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 54658e6ed4d9f567b3b401f48899fc5cb0ee10d4, data reload: false

query1	1293	944	934	934
query2	6254	2092	2010	2010
query3	10951	4452	4342	4342
query4	33105	23558	23526	23526
query5	3516	467	456	456
query6	264	184	182	182
query7	3980	301	300	300
query8	295	216	215	215
query9	9632	2730	2689	2689
query10	459	249	250	249
query11	17830	15258	15358	15258
query12	130	109	103	103
query13	1553	410	416	410
query14	9701	7028	6999	6999
query15	268	191	213	191
query16	8019	502	473	473
query17	1626	606	583	583
query18	2186	330	321	321
query19	214	155	160	155
query20	123	114	115	114
query21	211	109	110	109
query22	4865	4561	4610	4561
query23	35363	35287	34609	34609
query24	10610	2672	2510	2510
query25	584	387	391	387
query26	740	159	151	151
query27	2311	299	286	286
query28	6673	2503	2483	2483
query29	775	411	403	403
query30	234	148	151	148
query31	1070	804	851	804
query32	90	55	51	51
query33	773	301	291	291
query34	1050	512	542	512
query35	913	785	753	753
query36	1122	971	982	971
query37	129	73	80	73
query38	4470	4435	4441	4435
query39	1663	1468	1465	1465
query40	214	105	101	101
query41	54	45	46	45
query42	110	104	105	104
query43	550	510	482	482
query44	1309	857	834	834
query45	205	179	168	168
query46	1208	763	695	695
query47	2072	1954	1973	1954
query48	401	323	321	321
query49	912	389	404	389
query50	833	405	395	395
query51	7291	7257	7293	7257
query52	100	94	93	93
query53	258	181	176	176
query54	1251	408	431	408
query55	85	78	78	78
query56	276	244	233	233
query57	1341	1236	1213	1213
query58	220	198	209	198
query59	3136	2885	2989	2885
query60	258	240	239	239
query61	103	107	106	106
query62	844	674	677	674
query63	210	197	187	187
query64	3632	653	620	620
query65	3283	3221	3211	3211
query66	725	300	295	295
query67	16194	15754	15388	15388
query68	4511	550	541	541
query69	406	247	252	247
query70	1200	1088	1137	1088
query71	317	247	245	245
query72	6429	4008	4128	4008
query73	763	361	365	361
query74	10087	9273	8966	8966
query75	3449	2657	2698	2657
query76	2732	1062	1102	1062
query77	373	264	325	264
query78	10422	9423	9384	9384
query79	2458	586	609	586
query80	1064	421	440	421
query81	548	230	234	230
query82	642	122	120	120
query83	239	139	136	136
query84	227	65	72	65
query85	1598	288	294	288
query86	483	301	318	301
query87	4835	4729	4585	4585
query88	4144	2239	2204	2204
query89	421	292	287	287
query90	1867	189	194	189
query91	138	104	101	101
query92	66	52	51	51
query93	2508	546	539	539
query94	709	292	291	291
query95	357	248	248	248
query96	625	288	284	284
query97	2906	2753	2656	2656
query98	233	192	189	189
query99	1583	1329	1307	1307
Total cold run time: 300460 ms
Total hot run time: 197162 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.62 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 54658e6ed4d9f567b3b401f48899fc5cb0ee10d4, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.08	0.07
query4	1.62	0.10	0.10
query5	0.42	0.42	0.42
query6	1.19	0.66	0.65
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.60	0.54	0.53
query10	0.57	0.57	0.58
query11	0.14	0.11	0.11
query12	0.13	0.12	0.11
query13	0.62	0.60	0.60
query14	2.75	2.75	2.80
query15	0.89	0.82	0.83
query16	0.37	0.39	0.37
query17	1.06	1.01	1.02
query18	0.22	0.20	0.20
query19	1.86	1.89	1.94
query20	0.02	0.01	0.02
query21	15.37	0.58	0.55
query22	2.29	2.79	1.72
query23	17.12	1.06	0.86
query24	2.90	1.89	0.99
query25	0.24	0.09	0.17
query26	0.49	0.14	0.14
query27	0.05	0.04	0.04
query28	10.46	1.10	1.07
query29	12.60	3.24	3.25
query30	0.25	0.06	0.07
query31	2.85	0.40	0.38
query32	3.29	0.45	0.46
query33	3.05	3.01	3.14
query34	16.82	4.48	4.45
query35	4.46	4.55	4.46
query36	0.67	0.48	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.24 s
Total hot run time: 32.62 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 28, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@924060929 924060929 merged commit 2cde7b0 into apache:master Dec 2, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. not-merge/3.0 reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants