Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement](Test) Add test config to recycler #44761

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[Enhancement](Test) Add test config to recycler #44761

merged 1 commit into from
Dec 12, 2024

Conversation

Yukang-Lian
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Yukang-Lian
Copy link
Collaborator Author

run buildall

dataroaring
dataroaring previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Yukang-Lian Yukang-Lian force-pushed the Add-Test-Config-For-Recycler branch from 47fc072 to 5ae1274 Compare November 30, 2024 14:47
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 30, 2024
@Yukang-Lian
Copy link
Collaborator Author

run buildall

@dataroaring
Copy link
Contributor

run buildall

@Yukang-Lian Yukang-Lian force-pushed the Add-Test-Config-For-Recycler branch from f0edf40 to fbc746a Compare December 5, 2024 14:30
@dataroaring
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@gavinchou gavinchou merged commit c0f4c89 into apache:master Dec 12, 2024
25 of 26 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
@Yukang-Lian
[Enhancement](Test) Add test config to recycler (#44761)
93164cf
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
Merged
dataroaring pushed a commit that referenced this pull request Dec 13, 2024
@github-actions @Yukang-Lian
branch-3.0: [Enhancement](Test) Add test config to recycler #44761 (#…
45bcd1d 
…45368)

Cherry-picked from #44761

Co-authored-by: abmdocrt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luwei16 luwei16 luwei16 approved these changes

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yukang-Lian @doris-robot @dataroaring @gavinchou @luwei16