-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](nereids) remove enable nereids rules usage #44769
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
xzj7019
changed the title
[fix](nereids) remove enable nereids rules usage
[opt](nereids) remove enable nereids rules usage
Nov 29, 2024
run buildall |
TPC-H: Total hot run time: 40468 ms
|
16 tasks
TPC-DS: Total hot run time: 191353 ms
|
ClickBench: Total hot run time: 32.78 s
|
xzj7019
force-pushed
the
remove_enable_nereids_rules
branch
from
November 29, 2024 08:22
2d4fbb9
to
d00b730
Compare
run buildall |
TPC-H: Total hot run time: 40224 ms
|
TPC-DS: Total hot run time: 197176 ms
|
ClickBench: Total hot run time: 32.8 s
|
run cloud_p0 |
englefly
approved these changes
Dec 2, 2024
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Dec 2, 2024
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
morrySnow
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: (#35925)
Problem Summary:
(1) Remove enable_nereids_rules usage, and replaced with use_cbo_rule hint.
(2) Current case with use_cbo_rule which has deleted the enable_nereids_rules can't really tracking the rule's impact since the enable_nereids_rules related checking can't be passed. This pr activates these part of plan change.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)