Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt](nereids) remove enable nereids rules usage #44769

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

xzj7019
Copy link
Contributor

@xzj7019 xzj7019 commented Nov 29, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: (#35925)

Problem Summary:
(1) Remove enable_nereids_rules usage, and replaced with use_cbo_rule hint.
(2) Current case with use_cbo_rule which has deleted the enable_nereids_rules can't really tracking the rule's impact since the enable_nereids_rules related checking can't be passed. This pr activates these part of plan change.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xzj7019 xzj7019 changed the title [fix](nereids) remove enable nereids rules usage [opt](nereids) remove enable nereids rules usage Nov 29, 2024
@xzj7019
Copy link
Contributor Author

xzj7019 commented Nov 29, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40468 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2d4fbb959012d0bab295f2285fa8439c8845cbf0, data reload: false

------ Round 1 ----------------------------------
q1	17670	7515	7388	7388
q2	2048	191	164	164
q3	10531	1158	1151	1151
q4	10220	771	721	721
q5	7606	2739	2642	2642
q6	242	147	146	146
q7	999	630	623	623
q8	9226	1844	1957	1844
q9	6880	6564	6576	6564
q10	7043	2359	2325	2325
q11	467	268	261	261
q12	534	216	215	215
q13	17805	3028	3055	3028
q14	252	215	213	213
q15	586	536	511	511
q16	665	590	586	586
q17	1007	583	608	583
q18	7427	6745	6721	6721
q19	1336	1100	1123	1100
q20	472	183	181	181
q21	4038	3253	3192	3192
q22	385	309	314	309
Total cold run time: 107439 ms
Total hot run time: 40468 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7354	7310	7279	7279
q2	328	245	226	226
q3	2918	2877	2779	2779
q4	1976	1688	1718	1688
q5	5401	5412	5472	5412
q6	221	138	135	135
q7	2125	1730	1710	1710
q8	3291	3424	3455	3424
q9	8678	8688	8701	8688
q10	3525	3474	3470	3470
q11	593	498	495	495
q12	815	579	581	579
q13	13610	3024	3064	3024
q14	300	273	256	256
q15	584	527	513	513
q16	706	627	650	627
q17	1796	1607	1573	1573
q18	7661	7529	7468	7468
q19	1687	1432	1530	1432
q20	2070	1823	1807	1807
q21	5313	5258	5247	5247
q22	646	537	548	537
Total cold run time: 71598 ms
Total hot run time: 58369 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191353 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2d4fbb959012d0bab295f2285fa8439c8845cbf0, data reload: false

query1	792	401	404	401
query2	4218	2017	2023	2017
query3	6178	214	231	214
query4	33241	23909	23496	23496
query5	2131	468	440	440
query6	263	189	206	189
query7	4489	328	312	312
query8	284	237	241	237
query9	9399	2755	2745	2745
query10	479	272	249	249
query11	18005	15329	15309	15309
query12	146	103	100	100
query13	1585	405	406	405
query14	8752	6861	7512	6861
query15	255	169	182	169
query16	6660	474	453	453
query17	1017	552	538	538
query18	1854	294	284	284
query19	350	146	144	144
query20	122	110	109	109
query21	208	101	99	99
query22	4521	4352	4266	4266
query23	35184	34394	34081	34081
query24	11190	2478	2508	2478
query25	549	402	398	398
query26	1240	145	151	145
query27	2801	268	282	268
query28	7862	2468	2461	2461
query29	740	405	407	405
query30	247	144	156	144
query31	1025	811	815	811
query32	69	56	54	54
query33	732	343	271	271
query34	925	524	509	509
query35	905	741	729	729
query36	1106	952	959	952
query37	186	69	77	69
query38	4275	4223	4133	4133
query39	1494	1421	1429	1421
query40	229	105	105	105
query41	56	50	44	44
query42	103	97	97	97
query43	520	486	496	486
query44	1253	805	798	798
query45	186	170	171	170
query46	1186	687	737	687
query47	1948	1878	1849	1849
query48	421	314	325	314
query49	878	381	383	381
query50	846	401	388	388
query51	7256	7133	7163	7133
query52	94	92	100	92
query53	255	182	185	182
query54	1139	405	395	395
query55	78	75	79	75
query56	256	249	234	234
query57	1244	1095	1144	1095
query58	211	226	222	222
query59	3166	3059	3060	3059
query60	276	246	246	246
query61	122	107	108	107
query62	919	659	683	659
query63	214	187	185	185
query64	3141	661	643	643
query65	3332	3178	3223	3178
query66	1056	323	317	317
query67	16038	15786	15746	15746
query68	3471	574	555	555
query69	394	248	254	248
query70	1198	1133	1124	1124
query71	314	254	255	254
query72	5637	4128	4099	4099
query73	769	369	366	366
query74	9995	9115	9000	9000
query75	3451	2671	2647	2647
query76	1912	1124	1056	1056
query77	384	270	286	270
query78	10297	9349	9377	9349
query79	1123	588	592	588
query80	733	439	432	432
query81	513	233	238	233
query82	1078	120	123	120
query83	178	205	142	142
query84	264	67	66	66
query85	949	308	303	303
query86	317	303	296	296
query87	4673	4599	4563	4563
query88	3447	2247	2211	2211
query89	408	302	290	290
query90	2069	190	188	188
query91	201	110	106	106
query92	57	50	50	50
query93	1081	528	529	528
query94	880	294	295	294
query95	353	255	261	255
query96	614	281	283	281
query97	2859	2724	2667	2667
query98	215	201	195	195
query99	1529	1324	1337	1324
Total cold run time: 283265 ms
Total hot run time: 191353 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.78 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2d4fbb959012d0bab295f2285fa8439c8845cbf0, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.05	0.03
query3	0.23	0.08	0.07
query4	1.62	0.11	0.11
query5	0.42	0.40	0.43
query6	1.16	0.66	0.65
query7	0.01	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.51	0.50
query10	0.54	0.57	0.56
query11	0.14	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.62	0.60
query14	2.75	2.78	2.81
query15	0.90	0.82	0.82
query16	0.38	0.38	0.38
query17	1.07	1.08	1.04
query18	0.22	0.21	0.20
query19	1.84	1.81	2.01
query20	0.01	0.01	0.02
query21	15.38	0.59	0.57
query22	2.97	1.74	1.53
query23	17.16	0.91	0.89
query24	2.97	1.38	1.23
query25	0.22	0.16	0.07
query26	0.53	0.14	0.12
query27	0.05	0.04	0.04
query28	10.15	1.10	1.08
query29	12.58	3.29	3.27
query30	0.25	0.06	0.06
query31	2.86	0.39	0.37
query32	3.27	0.48	0.48
query33	3.00	3.12	3.08
query34	17.06	4.46	4.50
query35	4.52	4.50	4.48
query36	0.67	0.49	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.03	0.03
query40	0.15	0.12	0.12
query41	0.07	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 106.85 s
Total hot run time: 32.78 s

@xzj7019 xzj7019 force-pushed the remove_enable_nereids_rules branch from 2d4fbb9 to d00b730 Compare November 29, 2024 08:22
@xzj7019
Copy link
Contributor Author

xzj7019 commented Nov 29, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40224 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f29cfac88ffe0854e2eab74f6e90e91192a804cb, data reload: false

------ Round 1 ----------------------------------
q1	17725	7738	7305	7305
q2	2053	180	174	174
q3	10783	1096	1242	1096
q4	10395	773	757	757
q5	7610	2795	2804	2795
q6	242	149	147	147
q7	1018	619	609	609
q8	9247	1845	1974	1845
q9	6757	6512	6520	6512
q10	7029	2312	2323	2312
q11	464	255	257	255
q12	431	214	212	212
q13	17756	3021	3009	3009
q14	256	210	226	210
q15	582	533	514	514
q16	667	584	574	574
q17	1001	652	541	541
q18	7369	6858	6741	6741
q19	1385	1028	1089	1028
q20	474	181	177	177
q21	3929	3264	3104	3104
q22	375	311	307	307
Total cold run time: 107548 ms
Total hot run time: 40224 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7285	7243	7230	7230
q2	332	240	240	240
q3	2936	2991	2918	2918
q4	2079	1767	1844	1767
q5	5684	5653	5683	5653
q6	224	137	145	137
q7	2214	1823	1787	1787
q8	3396	3540	3590	3540
q9	8892	9112	9005	9005
q10	3593	3605	3546	3546
q11	594	504	504	504
q12	793	608	612	608
q13	11181	3242	3197	3197
q14	314	266	272	266
q15	563	533	531	531
q16	691	659	646	646
q17	1879	1625	1621	1621
q18	8397	7744	7825	7744
q19	1687	1599	1579	1579
q20	2115	1913	1881	1881
q21	5639	5418	5450	5418
q22	623	585	597	585
Total cold run time: 71111 ms
Total hot run time: 60403 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197176 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f29cfac88ffe0854e2eab74f6e90e91192a804cb, data reload: false

query1	1316	983	958	958
query2	6236	2050	2047	2047
query3	10959	4473	4434	4434
query4	66762	28861	23503	23503
query5	4914	452	433	433
query6	410	186	184	184
query7	5487	301	297	297
query8	323	232	232	232
query9	8315	2666	2653	2653
query10	428	248	252	248
query11	16902	15207	15772	15207
query12	158	102	101	101
query13	1494	414	428	414
query14	9750	7722	7095	7095
query15	216	188	197	188
query16	7080	496	497	496
query17	1112	591	602	591
query18	1844	325	309	309
query19	191	160	158	158
query20	120	118	112	112
query21	222	110	102	102
query22	4635	4497	4548	4497
query23	34844	34356	34584	34356
query24	5450	2518	2446	2446
query25	505	371	385	371
query26	644	163	164	163
query27	1723	284	283	283
query28	4282	2460	2455	2455
query29	693	425	405	405
query30	207	151	157	151
query31	997	837	882	837
query32	65	54	59	54
query33	401	284	280	280
query34	926	517	503	503
query35	884	776	776	776
query36	1057	953	962	953
query37	118	74	77	74
query38	4469	4409	4322	4322
query39	1523	1442	1473	1442
query40	209	98	103	98
query41	43	42	43	42
query42	114	96	98	96
query43	535	495	516	495
query44	1191	849	855	849
query45	190	167	169	167
query46	1191	724	707	707
query47	2049	1961	1943	1943
query48	415	311	313	311
query49	732	380	398	380
query50	812	410	381	381
query51	7362	7196	7237	7196
query52	94	89	89	89
query53	253	174	177	174
query54	510	400	389	389
query55	82	78	76	76
query56	255	226	228	226
query57	1246	1111	1112	1111
query58	212	224	209	209
query59	3376	3170	3182	3170
query60	259	234	238	234
query61	106	106	105	105
query62	806	656	684	656
query63	216	189	192	189
query64	1367	672	681	672
query65	3276	3233	3211	3211
query66	707	301	307	301
query67	15912	15813	15732	15732
query68	4088	572	560	560
query69	433	252	295	252
query70	1159	1128	1130	1128
query71	355	244	249	244
query72	6457	4071	3984	3984
query73	762	355	361	355
query74	10205	8944	9131	8944
query75	3423	2633	2675	2633
query76	1868	1072	1162	1072
query77	477	328	279	279
query78	10476	9493	9412	9412
query79	1147	587	589	587
query80	774	420	426	420
query81	513	235	228	228
query82	235	120	113	113
query83	178	146	142	142
query84	282	75	66	66
query85	900	300	294	294
query86	326	296	291	291
query87	4738	4529	4505	4505
query88	3837	2202	2191	2191
query89	414	297	299	297
query90	2017	188	183	183
query91	136	100	99	99
query92	65	50	48	48
query93	1355	534	535	534
query94	792	290	289	289
query95	349	239	248	239
query96	612	287	272	272
query97	2877	2672	2722	2672
query98	207	202	194	194
query99	1865	1315	1310	1310
Total cold run time: 314504 ms
Total hot run time: 197176 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.8 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f29cfac88ffe0854e2eab74f6e90e91192a804cb, data reload: false

query1	0.04	0.03	0.02
query2	0.06	0.03	0.03
query3	0.23	0.06	0.07
query4	1.62	0.10	0.11
query5	0.41	0.39	0.39
query6	1.18	0.65	0.65
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.58	0.51	0.51
query10	0.56	0.57	0.56
query11	0.14	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.61	0.59
query14	2.82	2.84	2.75
query15	0.90	0.83	0.83
query16	0.40	0.38	0.38
query17	1.03	1.07	1.04
query18	0.22	0.21	0.22
query19	1.94	1.82	2.03
query20	0.02	0.00	0.01
query21	15.36	0.58	0.58
query22	2.49	2.43	2.10
query23	17.47	0.87	0.75
query24	3.50	0.98	0.99
query25	0.21	0.28	0.13
query26	0.33	0.14	0.14
query27	0.04	0.05	0.04
query28	10.80	1.08	1.07
query29	12.58	3.24	3.22
query30	0.26	0.06	0.06
query31	2.86	0.38	0.37
query32	3.29	0.46	0.46
query33	2.95	3.02	3.04
query34	17.07	4.45	4.47
query35	4.47	4.44	4.51
query36	0.66	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.17	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.78 s
Total hot run time: 32.8 s

@xzj7019
Copy link
Contributor Author

xzj7019 commented Nov 29, 2024

run cloud_p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 0995618 into apache:master Dec 2, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants