Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](coordinator) fix NereidsCoordinator can not interrupt query in fe #44795

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

924060929
Copy link
Contributor

@924060929 924060929 commented Nov 29, 2024

What problem does this PR solve?

fix NereidsCoordinator can not interrupt query in fe, the QueryProcessor should set the status to failed

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@924060929
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39698 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0f185102437cc5de16b1e847e66de36c1acabc54, data reload: false

------ Round 1 ----------------------------------
q1	17615	7517	7258	7258
q2	2043	177	165	165
q3	10597	1096	1184	1096
q4	10600	782	711	711
q5	7608	2724	2624	2624
q6	238	148	153	148
q7	973	625	610	610
q8	9270	1869	1874	1869
q9	6588	6446	6443	6443
q10	6994	2268	2341	2268
q11	456	273	256	256
q12	426	224	220	220
q13	17767	2956	3004	2956
q14	236	210	209	209
q15	589	523	511	511
q16	678	582	584	582
q17	971	548	498	498
q18	7300	6605	6672	6605
q19	1340	1037	1030	1030
q20	458	181	187	181
q21	4041	3148	3197	3148
q22	370	324	310	310
Total cold run time: 107158 ms
Total hot run time: 39698 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7266	7225	7287	7225
q2	322	227	235	227
q3	2915	2786	2911	2786
q4	2081	1788	1837	1788
q5	5657	5634	5692	5634
q6	225	140	144	140
q7	2245	1820	1813	1813
q8	3373	3568	3520	3520
q9	8957	8952	9020	8952
q10	3599	3566	3548	3548
q11	614	520	513	513
q12	832	587	622	587
q13	13942	3232	3232	3232
q14	326	271	273	271
q15	588	525	517	517
q16	686	636	651	636
q17	1868	1631	1594	1594
q18	8388	8019	7577	7577
q19	1711	1709	1589	1589
q20	2110	1866	1878	1866
q21	5582	5466	5422	5422
q22	638	582	579	579
Total cold run time: 73925 ms
Total hot run time: 60016 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198263 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0f185102437cc5de16b1e847e66de36c1acabc54, data reload: false

query1	1259	988	898	898
query2	6244	2106	2037	2037
query3	11002	4576	4500	4500
query4	66269	27847	23650	23650
query5	4949	461	432	432
query6	411	172	166	166
query7	5584	302	303	302
query8	304	223	220	220
query9	9082	2699	2705	2699
query10	450	247	250	247
query11	17411	15535	16029	15535
query12	163	111	105	105
query13	1548	448	417	417
query14	10607	7630	7384	7384
query15	227	190	188	188
query16	7179	472	486	472
query17	1249	596	582	582
query18	1864	313	325	313
query19	212	169	156	156
query20	120	114	113	113
query21	216	105	100	100
query22	4632	4477	4580	4477
query23	34764	34528	34381	34381
query24	5486	2435	2405	2405
query25	498	399	393	393
query26	644	146	151	146
query27	1811	288	288	288
query28	4261	2494	2502	2494
query29	664	421	413	413
query30	206	146	152	146
query31	993	829	845	829
query32	70	57	59	57
query33	452	315	375	315
query34	934	534	522	522
query35	889	790	770	770
query36	1070	947	967	947
query37	118	79	79	79
query38	4493	4380	4471	4380
query39	1529	1477	1475	1475
query40	214	101	101	101
query41	45	44	42	42
query42	106	100	110	100
query43	544	477	517	477
query44	1195	855	819	819
query45	191	169	168	168
query46	1184	728	718	718
query47	1991	1936	1925	1925
query48	414	322	322	322
query49	766	413	393	393
query50	845	402	401	401
query51	7343	7248	7061	7061
query52	96	92	91	91
query53	258	188	181	181
query54	516	421	395	395
query55	76	74	79	74
query56	265	262	235	235
query57	1271	1123	1141	1123
query58	222	210	207	207
query59	3360	3339	3220	3220
query60	272	244	247	244
query61	108	108	108	108
query62	779	684	683	683
query63	212	193	189	189
query64	1361	692	626	626
query65	3277	3255	3185	3185
query66	693	299	304	299
query67	15995	15876	15745	15745
query68	3978	571	545	545
query69	431	254	255	254
query70	1228	1198	1144	1144
query71	355	253	250	250
query72	6369	4035	4097	4035
query73	770	358	358	358
query74	10475	9009	9101	9009
query75	3403	2694	2670	2670
query76	1844	1057	1191	1057
query77	480	336	277	277
query78	10423	9396	9385	9385
query79	1903	597	608	597
query80	1424	439	432	432
query81	504	241	238	238
query82	1283	117	111	111
query83	265	142	142	142
query84	281	71	67	67
query85	1006	309	364	309
query86	420	305	297	297
query87	4692	4649	4585	4585
query88	3741	2190	2168	2168
query89	421	293	293	293
query90	1963	188	179	179
query91	139	102	105	102
query92	69	51	51	51
query93	2262	536	530	530
query94	815	278	295	278
query95	361	254	252	252
query96	615	278	281	278
query97	2917	2704	2735	2704
query98	215	199	200	199
query99	1583	1302	1339	1302
Total cold run time: 320098 ms
Total hot run time: 198263 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.32 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0f185102437cc5de16b1e847e66de36c1acabc54, data reload: false

query1	0.03	0.03	0.05
query2	0.06	0.03	0.04
query3	0.23	0.07	0.07
query4	1.63	0.11	0.10
query5	0.42	0.40	0.43
query6	1.14	0.66	0.67
query7	0.02	0.02	0.01
query8	0.04	0.04	0.03
query9	0.58	0.52	0.50
query10	0.54	0.56	0.55
query11	0.14	0.11	0.11
query12	0.16	0.12	0.12
query13	0.60	0.62	0.60
query14	2.73	2.73	2.73
query15	0.88	0.82	0.81
query16	0.40	0.37	0.37
query17	1.01	1.02	1.04
query18	0.21	0.21	0.22
query19	1.82	1.80	1.80
query20	0.01	0.01	0.01
query21	15.37	0.57	0.57
query22	3.01	2.63	0.93
query23	17.16	0.88	0.79
query24	3.01	1.62	2.08
query25	0.31	0.22	0.04
query26	0.59	0.15	0.14
query27	0.04	0.04	0.04
query28	9.59	1.12	1.08
query29	12.54	3.26	3.28
query30	0.25	0.07	0.07
query31	2.86	0.38	0.38
query32	3.28	0.47	0.47
query33	2.95	3.04	3.06
query34	17.33	4.46	4.45
query35	4.53	4.52	4.49
query36	0.65	0.49	0.49
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.03	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 106.6 s
Total hot run time: 32.32 s

@924060929
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40112 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dc8be0e972c5ec1bb8f5bd117c19033ac70d0972, data reload: false

------ Round 1 ----------------------------------
q1	17597	7522	7262	7262
q2	2040	182	177	177
q3	10576	1103	1205	1103
q4	10573	787	716	716
q5	7600	2727	2716	2716
q6	240	146	148	146
q7	962	628	610	610
q8	9257	1847	1934	1847
q9	6636	6547	6497	6497
q10	6993	2268	2337	2268
q11	465	262	274	262
q12	417	232	228	228
q13	17775	3059	3031	3031
q14	238	215	212	212
q15	569	532	508	508
q16	690	578	581	578
q17	964	646	582	582
q18	7298	6765	6656	6656
q19	1330	955	1046	955
q20	468	186	187	186
q21	3976	3296	3261	3261
q22	394	321	311	311
Total cold run time: 107058 ms
Total hot run time: 40112 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7250	7244	7236	7236
q2	329	234	229	229
q3	2913	2871	2914	2871
q4	2083	1818	1871	1818
q5	5644	5686	5668	5668
q6	231	142	146	142
q7	2264	1810	1784	1784
q8	3413	3563	3492	3492
q9	8968	9027	9024	9024
q10	3599	3586	3561	3561
q11	595	500	511	500
q12	812	593	649	593
q13	12891	3423	3325	3325
q14	324	278	296	278
q15	578	536	542	536
q16	704	665	655	655
q17	1876	1650	1667	1650
q18	8441	7768	7456	7456
q19	1693	1620	1679	1620
q20	2112	1926	1871	1871
q21	5675	5525	5375	5375
q22	647	608	565	565
Total cold run time: 73042 ms
Total hot run time: 60249 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197726 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dc8be0e972c5ec1bb8f5bd117c19033ac70d0972, data reload: false

query1	1244	971	934	934
query2	6256	2093	2093	2093
query3	10954	4461	4387	4387
query4	67146	28664	23684	23684
query5	4946	460	475	460
query6	401	192	179	179
query7	5464	326	294	294
query8	316	228	241	228
query9	8441	2747	2711	2711
query10	439	255	252	252
query11	17104	15291	16138	15291
query12	156	108	105	105
query13	1418	414	426	414
query14	9910	7359	7343	7343
query15	209	179	178	178
query16	7093	446	492	446
query17	1054	572	570	570
query18	1851	302	299	299
query19	207	163	160	160
query20	123	109	116	109
query21	208	101	105	101
query22	4706	4631	4639	4631
query23	34995	34537	34458	34458
query24	5627	2573	2617	2573
query25	520	413	412	412
query26	659	156	155	155
query27	1921	286	301	286
query28	4491	2560	2483	2483
query29	670	421	427	421
query30	215	151	148	148
query31	988	785	843	785
query32	68	52	59	52
query33	409	289	315	289
query34	933	535	519	519
query35	881	777	772	772
query36	1090	966	979	966
query37	126	81	68	68
query38	4524	4403	4435	4403
query39	1552	1531	1477	1477
query40	199	104	105	104
query41	44	48	43	43
query42	112	102	97	97
query43	539	501	471	471
query44	1188	821	835	821
query45	192	209	178	178
query46	1161	741	769	741
query47	2023	1934	1927	1927
query48	421	334	324	324
query49	713	398	385	385
query50	855	407	416	407
query51	7432	7184	7129	7129
query52	95	84	92	84
query53	256	181	181	181
query54	516	410	403	403
query55	80	75	77	75
query56	269	262	247	247
query57	1265	1104	1098	1098
query58	214	209	221	209
query59	3129	3008	2854	2854
query60	274	241	239	239
query61	111	108	109	108
query62	795	670	659	659
query63	213	184	193	184
query64	1348	728	638	638
query65	3268	3250	3187	3187
query66	722	302	311	302
query67	15965	15697	15457	15457
query68	4155	583	552	552
query69	415	251	253	251
query70	1211	1080	1148	1080
query71	362	255	284	255
query72	6397	4074	4046	4046
query73	772	366	373	366
query74	10231	8922	9067	8922
query75	3366	2691	2684	2684
query76	1875	1043	1260	1043
query77	494	280	284	280
query78	10519	9447	9410	9410
query79	1532	608	602	602
query80	883	438	443	438
query81	496	233	219	219
query82	1284	118	116	116
query83	253	149	149	149
query84	282	70	71	70
query85	904	377	310	310
query86	345	297	310	297
query87	4793	4577	4577	4577
query88	3592	2230	2191	2191
query89	414	296	291	291
query90	2015	189	189	189
query91	143	106	106	106
query92	68	50	50	50
query93	1912	557	543	543
query94	829	297	288	288
query95	354	250	251	250
query96	623	278	282	278
query97	2855	2670	2729	2670
query98	217	194	197	194
query99	1592	1321	1341	1321
Total cold run time: 317897 ms
Total hot run time: 197726 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.77 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dc8be0e972c5ec1bb8f5bd117c19033ac70d0972, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.62	0.10	0.11
query5	0.42	0.40	0.42
query6	1.20	0.66	0.65
query7	0.02	0.02	0.01
query8	0.04	0.04	0.03
query9	0.58	0.51	0.50
query10	0.56	0.56	0.56
query11	0.14	0.10	0.10
query12	0.14	0.12	0.11
query13	0.60	0.60	0.59
query14	2.71	2.75	2.85
query15	0.90	0.82	0.82
query16	0.40	0.38	0.39
query17	1.07	1.06	0.99
query18	0.23	0.21	0.21
query19	1.88	1.80	1.96
query20	0.01	0.01	0.01
query21	15.36	0.61	0.62
query22	2.37	1.68	1.70
query23	16.89	0.91	0.79
query24	2.96	1.27	1.23
query25	0.20	0.22	0.20
query26	0.45	0.14	0.14
query27	0.04	0.04	0.04
query28	10.35	1.09	1.07
query29	12.53	3.23	3.21
query30	0.25	0.06	0.06
query31	2.87	0.39	0.37
query32	3.29	0.47	0.47
query33	3.10	3.08	3.05
query34	17.08	4.45	4.50
query35	4.53	4.47	4.49
query36	0.66	0.49	0.50
query37	0.08	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.12
query41	0.07	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 106.23 s
Total hot run time: 32.77 s

Copy link
Contributor

github-actions bot commented Dec 2, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

PR approved by anyone and no changes requested.

@924060929 924060929 merged commit 53ea2a0 into apache:master Dec 2, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. not-merge/3.0 reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants