Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](sql_cache) fix sql cache result wrong of from_unixtime(col, 'yyyy-MM-dd HH:mm:ss') (#44631) #44811

Merged

Conversation

924060929
Copy link
Contributor

cherry pick from #44631

…yy-MM-dd HH:mm:ss') (apache#44631)

fix sql cache result wrong of from_unixtime(col, 'yyyy-MM-dd HH:mm:ss')
which introduced by apache#33262

the wrong result: is `yyyy-MM-dd HH:mm:ss`

(cherry picked from commit d592e27)
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40302 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dc1eec758e0d1fe9fdb494b2af38c3d2c49701b2, data reload: false

------ Round 1 ----------------------------------
q1	17603	7446	7276	7276
q2	2040	175	163	163
q3	10738	1073	1102	1073
q4	10546	797	663	663
q5	7755	2812	2832	2812
q6	230	147	146	146
q7	970	610	606	606
q8	9564	1949	1948	1948
q9	7323	6353	6422	6353
q10	6963	2308	2322	2308
q11	449	262	269	262
q12	412	220	212	212
q13	17764	2980	2969	2969
q14	238	210	214	210
q15	551	529	505	505
q16	647	614	595	595
q17	964	532	486	486
q18	7255	6535	6500	6500
q19	2845	1031	1111	1031
q20	470	202	195	195
q21	4102	3143	3023	3023
q22	1090	998	966	966
Total cold run time: 110519 ms
Total hot run time: 40302 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7330	7233	7285	7233
q2	315	224	226	224
q3	2935	2855	2848	2848
q4	2048	1790	1762	1762
q5	5679	5728	5725	5725
q6	231	148	143	143
q7	2139	1773	1799	1773
q8	3363	3523	3372	3372
q9	8941	8928	8880	8880
q10	3538	3512	3525	3512
q11	584	506	509	506
q12	822	654	594	594
q13	16388	3156	3136	3136
q14	303	283	279	279
q15	582	540	525	525
q16	708	666	680	666
q17	1891	1602	1605	1602
q18	8160	7801	7350	7350
q19	1693	1498	1412	1412
q20	2044	1848	1860	1848
q21	5305	5310	5214	5214
q22	1096	1022	985	985
Total cold run time: 76095 ms
Total hot run time: 59589 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194856 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dc1eec758e0d1fe9fdb494b2af38c3d2c49701b2, data reload: false

query1	1212	915	899	899
query2	6232	2014	1997	1997
query3	10789	3653	3874	3653
query4	68832	28463	23313	23313
query5	5579	445	430	430
query6	472	170	162	162
query7	6199	317	323	317
query8	322	224	229	224
query9	9361	2661	2652	2652
query10	510	269	253	253
query11	18010	15336	15667	15336
query12	162	102	112	102
query13	1574	444	421	421
query14	11388	7321	6671	6671
query15	211	180	182	180
query16	7231	517	509	509
query17	1317	587	576	576
query18	1855	322	320	320
query19	213	167	159	159
query20	116	112	117	112
query21	216	106	106	106
query22	4765	4667	4542	4542
query23	34888	34157	34087	34087
query24	5854	2951	2956	2951
query25	498	376	380	376
query26	670	165	166	165
query27	2061	307	305	305
query28	4423	2572	2531	2531
query29	691	454	441	441
query30	237	161	160	160
query31	981	818	816	816
query32	64	52	53	52
query33	456	273	279	273
query34	910	502	523	502
query35	832	740	723	723
query36	1118	980	958	958
query37	115	75	67	67
query38	4055	3992	3957	3957
query39	1516	1457	1470	1457
query40	204	96	96	96
query41	50	48	46	46
query42	108	94	94	94
query43	523	497	483	483
query44	1176	805	821	805
query45	186	169	167	167
query46	1131	780	743	743
query47	2021	1908	1904	1904
query48	467	384	375	375
query49	735	383	391	383
query50	841	413	411	411
query51	7290	7242	6996	6996
query52	102	84	90	84
query53	250	184	186	184
query54	550	442	435	435
query55	75	72	71	71
query56	255	242	226	226
query57	1185	1122	1073	1073
query58	204	196	208	196
query59	3077	2836	2875	2836
query60	282	254	240	240
query61	107	105	99	99
query62	758	658	671	658
query63	211	193	191	191
query64	1429	650	614	614
query65	3244	3168	3152	3152
query66	648	297	301	297
query67	15737	15232	15182	15182
query68	4551	557	554	554
query69	417	272	256	256
query70	1191	1138	1126	1126
query71	314	247	251	247
query72	6464	4019	4018	4018
query73	743	346	343	343
query74	10117	8807	9001	8807
query75	3274	2796	2643	2643
query76	2264	1095	1141	1095
query77	480	268	260	260
query78	10713	9789	9404	9404
query79	9051	592	574	574
query80	2374	440	478	440
query81	567	240	249	240
query82	1277	113	111	111
query83	303	137	135	135
query84	297	79	82	79
query85	1951	297	283	283
query86	464	288	306	288
query87	4444	4172	4307	4172
query88	5818	2388	2395	2388
query89	561	284	288	284
query90	2173	176	180	176
query91	173	139	141	139
query92	65	49	50	49
query93	6800	537	536	536
query94	1035	275	284	275
query95	336	255	253	253
query96	647	281	276	276
query97	3329	3126	3212	3126
query98	219	204	201	201
query99	1710	1297	1282	1282
Total cold run time: 342903 ms
Total hot run time: 194856 ms

@924060929 924060929 merged commit 95aacda into apache:branch-3.0 Dec 2, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants