Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](nereids) fix months_add/ months_sub/ years_add/years_sub compute wrong result because SimplifyArithmeticComparisonRule (#44725) #44813

Conversation

924060929
Copy link
Contributor

cherry pick from #44725

…e wrong result because SimplifyArithmeticComparisonRule (apache#44725)

fix months_add/ months_sub/ years_add/years_sub compute wrong result
because SimplifyArithmeticComparisonRule
introduced by apache#25180

(cherry picked from commit 1ae91b8)
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40632 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9c8a4a490cad5c583a9ed938ec73a5e73857e295, data reload: false

------ Round 1 ----------------------------------
q1	17593	7376	7303	7303
q2	2043	160	162	160
q3	10711	1055	1144	1055
q4	10553	736	770	736
q5	7773	2791	2787	2787
q6	240	147	149	147
q7	998	612	605	605
q8	9584	1910	2023	1910
q9	7386	6436	6392	6392
q10	6995	2268	2338	2268
q11	449	258	257	257
q12	422	213	216	213
q13	17793	3004	3019	3004
q14	248	210	220	210
q15	572	518	531	518
q16	662	611	594	594
q17	958	509	551	509
q18	7161	6704	6558	6558
q19	2821	1045	1060	1045
q20	462	193	192	192
q21	3960	3174	3196	3174
q22	1107	999	995	995
Total cold run time: 110491 ms
Total hot run time: 40632 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7434	7280	7250	7250
q2	319	226	222	222
q3	2993	2898	2862	2862
q4	2039	1778	1770	1770
q5	5634	5684	5746	5684
q6	228	144	146	144
q7	2121	1766	1748	1748
q8	3323	3495	3378	3378
q9	8870	8874	8813	8813
q10	3580	3506	3478	3478
q11	638	492	484	484
q12	834	637	615	615
q13	16632	3176	3188	3176
q14	318	271	261	261
q15	579	524	526	524
q16	694	658	668	658
q17	1827	1593	1584	1584
q18	8249	8084	7501	7501
q19	4618	1597	1650	1597
q20	2122	1863	1844	1844
q21	9428	5255	5398	5255
q22	1133	1033	1010	1010
Total cold run time: 83613 ms
Total hot run time: 59858 ms

@morrySnow morrySnow merged commit 7337930 into apache:branch-3.0 Dec 2, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants