-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] (nereids)implement showSyncJobCommand in nereids #44817
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
a811c3d
to
2316a16
Compare
|
||
suite("test_show_sync_job_command", "query,sync_job") { | ||
try { | ||
sql """CREATE DATABASE IF NOT EXISTS test_db;""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls dont use common name like test_db. it might collide with other testcase and cause random failures.
pls use like test_show_sync_job_command_db.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done - pls review
2316a16
to
805baf6
Compare
run buildall |
TPC-H: Total hot run time: 39844 ms
|
TPC-DS: Total hot run time: 197655 ms
|
ClickBench: Total hot run time: 32.63 s
|
run buildall |
TPC-H: Total hot run time: 39881 ms
|
TPC-DS: Total hot run time: 197539 ms
|
ClickBench: Total hot run time: 33.1 s
|
run buildall |
TPC-H: Total hot run time: 39778 ms
|
TPC-DS: Total hot run time: 196777 ms
|
ClickBench: Total hot run time: 33.04 s
|
public <R, C> R accept(PlanVisitor<R, C> visitor, C context) { | ||
return visitor.visitShowSyncJobCommand(this, context); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Override
public RedirectStatus toRedirectStatus() {
return RedirectStatus.FORWARD_NO_SYNC;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done - please review
439326e
to
9f2b091
Compare
run buildall |
TPC-H: Total hot run time: 39735 ms
|
TPC-DS: Total hot run time: 196143 ms
|
ClickBench: Total hot run time: 32.65 s
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
What problem does this PR solve?
Issue Number: close #42775
Related PR: #xxx
Problem Summary:
[Enhancement] (nereids)implement showSyncJobCommand in nereids
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)