Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-2.1: [fix](iceberg)Bring field_id with parquet files And fix map type's key optional #44470 #44828

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 1, 2024

Cherry-picked from #44470

…y optional (#44470)

### What problem does this PR solve?

1. Column IDs are required to be stored as [field
IDs](http://github.com/apache/parquet-format/blob/40699d05bd24181de6b1457babbee2c16dce3803/src/main/thrift/parquet.thrift#L459)
on the parquet schema.
ref: https://iceberg.apache.org/spec/?h=field+id#parquet
So, we should add field ids.
2. For `MapType`, its key is always required.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Dec 1, 2024
@dataroaring dataroaring reopened this Dec 1, 2024
@doris-robot
Copy link

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.77% (9619/26161)
Line Coverage: 28.17% (79178/281027)
Region Coverage: 26.83% (40645/151485)
Branch Coverage: 23.66% (20698/87466)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c836706fefa09c421ed9f1a82a74f4b64302e9a9_c836706fefa09c421ed9f1a82a74f4b64302e9a9/report/index.html

@yiguolei yiguolei merged commit 5f952cf into branch-2.1 Dec 2, 2024
17 of 19 checks passed
@github-actions github-actions bot deleted the auto-pick-44470-branch-2.1 branch December 2, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants