Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test](show_data) test the correctness of data statistics in cloud mode #44947

Merged
merged 4 commits into from
Dec 12, 2024
Merged

[test](show_data) test the correctness of data statistics in cloud mode #44947

merged 4 commits into from
Dec 12, 2024

Conversation

pingchunzhang
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary: add show data tests

Release note

None

Check List (For Author)

  • Test

    • Regression test

  • Behavior changed:

    • No.

  • Does this need documentation?

    • No.

Check List (For Reviewer who merge this PR)

  • Confirm test cases

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

dataroaring
dataroaring previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
Copy link
Contributor

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

PR approved by anyone and no changes requested.

hello-stephen
hello-stephen reviewed Dec 9, 2024
View reviewed changes
regression-test/suites/show_data/ddl/lineitem_dup.sql
@@ -0,0 +1,25 @@
CREATE TABLE IF NOT EXISTS lineitem_mow (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lineitem_dup ？

morningman
morningman reviewed Dec 9, 2024
View reviewed changes
regression-test/plugins/aliyunOssSdk.groovy Outdated

}

// 获取某个存储空间下指定目录（文件夹）下的文件大小。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 10, 2024
@pingchunzhang
Copy link
Contributor Author

run buildall

@pingchunzhang
Copy link
Contributor Author

run buildall

dataroaring
dataroaring approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit 5706b6b into apache:master Dec 12, 2024
26 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
@pingchunzhang
[test](show_data) test the correctness of data statistics in cloud mo…
02e7f0d 
…de (#44947)
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
Merged
dataroaring pushed a commit that referenced this pull request Dec 19, 2024
@github-actions @pingchunzhang
branch-3.0: [test](show_data) test the correctness of data statistics…
7bb0491 
… in cloud mode #44947 (#45330)

Cherry-picked from #44947

Co-authored-by: chunping <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hello-stephen hello-stephen hello-stephen left review comments

@dataroaring dataroaring dataroaring approved these changes

@morningman morningman morningman approved these changes

@CalvinKirs CalvinKirs Awaiting requested review from CalvinKirs CalvinKirs is a code owner

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pingchunzhang @doris-robot @dataroaring @morningman @hello-stephen