[fix](sql) Fix error result for column tosql #44997

wyxxxcat · 2024-12-04T11:14:12Z

What problem does this PR solve?

related : selectdb/ccr-syncer#293

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

wyxxxcat · 2024-12-04T11:14:27Z

run buildall

doris-robot · 2024-12-04T11:14:42Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

doris-robot · 2024-12-04T11:41:14Z

TPC-H: Total hot run time: 40297 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d2d850938376d959050865ccb1e1fa9dffadc6f7, data reload: false

------ Round 1 ----------------------------------
q1	17583	7503	7369	7369
q2	2073	177	173	173
q3	10545	1156	1133	1133
q4	10236	756	726	726
q5	7596	2699	2740	2699
q6	242	153	152	152
q7	1019	648	617	617
q8	9255	1876	1948	1876
q9	6620	6500	6450	6450
q10	6941	2326	2321	2321
q11	453	263	266	263
q12	466	229	235	229
q13	17761	3056	2993	2993
q14	246	212	210	210
q15	567	528	541	528
q16	649	600	576	576
q17	997	509	555	509
q18	7461	6839	6737	6737
q19	1335	1001	970	970
q20	495	182	188	182
q21	4056	3409	3272	3272
q22	386	312	314	312
Total cold run time: 106982 ms
Total hot run time: 40297 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7264	7268	7325	7268
q2	329	232	227	227
q3	2901	2848	3279	2848
q4	2127	1814	1788	1788
q5	5575	5717	5616	5616
q6	220	143	139	139
q7	2180	1771	1799	1771
q8	3396	3518	3473	3473
q9	8987	8956	9069	8956
q10	3622	3553	3562	3553
q11	589	504	512	504
q12	838	632	622	622
q13	11999	3150	3194	3150
q14	309	270	287	270
q15	571	520	496	496
q16	694	662	641	641
q17	1796	1624	1568	1568
q18	7916	7391	7338	7338
q19	1722	1501	1578	1501
q20	2042	1822	1822	1822
q21	5496	5476	5353	5353
q22	683	628	563	563
Total cold run time: 71256 ms
Total hot run time: 59467 ms

wyxxxcat · 2024-12-04T11:49:23Z

run buildall

wyxxxcat · 2024-12-04T13:49:24Z

run buildall

doris-robot · 2024-12-04T14:41:10Z

TPC-H: Total hot run time: 39950 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b34ce67cedef411330e347b388084925c81b1d38, data reload: false

------ Round 1 ----------------------------------
q1	17600	7490	7321	7321
q2	2048	190	197	190
q3	10584	1115	1217	1115
q4	10577	765	700	700
q5	7617	2704	2570	2570
q6	236	155	153	153
q7	979	627	594	594
q8	9266	1889	1939	1889
q9	6684	6537	6506	6506
q10	6997	2261	2301	2261
q11	462	273	245	245
q12	414	219	224	219
q13	17785	3018	3011	3011
q14	246	214	234	214
q15	577	540	514	514
q16	664	599	589	589
q17	986	639	453	453
q18	7246	6770	6667	6667
q19	1347	1028	971	971
q20	475	179	181	179
q21	4037	3304	3267	3267
q22	389	324	322	322
Total cold run time: 107216 ms
Total hot run time: 39950 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7318	7196	7334	7196
q2	330	230	240	230
q3	2866	2794	2896	2794
q4	2086	1832	1893	1832
q5	5662	5671	5638	5638
q6	230	139	141	139
q7	2203	1852	1805	1805
q8	3374	3535	3482	3482
q9	9042	9054	9023	9023
q10	3586	3563	3539	3539
q11	592	504	501	501
q12	819	617	630	617
q13	11701	3241	3231	3231
q14	299	274	277	274
q15	567	525	526	525
q16	710	654	650	650
q17	1844	1666	1615	1615
q18	8292	7670	7816	7670
q19	1665	1629	1494	1494
q20	2095	1860	1890	1860
q21	5548	5300	5442	5300
q22	668	545	564	545
Total cold run time: 71497 ms
Total hot run time: 59960 ms

doris-robot · 2024-12-04T14:53:51Z

TPC-DS: Total hot run time: 198568 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b34ce67cedef411330e347b388084925c81b1d38, data reload: false

query1	1559	975	942	942
query2	6232	2121	2136	2121
query3	10983	4565	4303	4303
query4	67315	28419	23710	23710
query5	5050	473	459	459
query6	406	193	189	189
query7	5481	308	300	300
query8	328	238	236	236
query9	8543	2715	2707	2707
query10	428	257	245	245
query11	17189	15146	16024	15146
query12	153	102	100	100
query13	1430	416	406	406
query14	10857	7695	7686	7686
query15	216	195	204	195
query16	7118	474	501	474
query17	1133	591	599	591
query18	1843	337	341	337
query19	219	172	177	172
query20	126	116	113	113
query21	220	108	104	104
query22	4817	4512	4660	4512
query23	34687	34581	34602	34581
query24	5506	2694	2546	2546
query25	514	383	386	383
query26	688	163	160	160
query27	1910	308	290	290
query28	4420	2525	2486	2486
query29	694	426	424	424
query30	208	153	153	153
query31	1071	834	859	834
query32	71	52	78	52
query33	463	298	297	297
query34	937	532	534	532
query35	878	759	740	740
query36	1093	970	950	950
query37	124	73	74	73
query38	4528	4354	4547	4354
query39	1517	1486	1475	1475
query40	216	101	101	101
query41	45	43	43	43
query42	107	98	102	98
query43	550	507	505	505
query44	1209	835	826	826
query45	193	173	171	171
query46	1188	742	739	739
query47	2040	1918	1903	1903
query48	419	324	318	318
query49	778	402	383	383
query50	856	393	403	393
query51	7511	7300	7130	7130
query52	101	88	87	87
query53	258	179	179	179
query54	522	384	389	384
query55	79	73	82	73
query56	254	230	237	230
query57	1279	1147	1128	1128
query58	218	199	206	199
query59	3357	3214	3136	3136
query60	266	244	251	244
query61	108	108	104	104
query62	806	683	665	665
query63	220	188	207	188
query64	1758	704	642	642
query65	3293	3214	3244	3214
query66	746	317	310	310
query67	15924	15650	15542	15542
query68	3759	571	552	552
query69	420	262	253	253
query70	1202	1126	1133	1126
query71	360	251	254	251
query72	6387	4093	4096	4093
query73	786	358	363	358
query74	10445	8991	9012	8991
query75	3367	2664	2667	2664
query76	1870	1050	1094	1050
query77	492	277	273	273
query78	10640	9568	9494	9494
query79	1236	605	601	601
query80	823	439	447	439
query81	501	249	228	228
query82	1331	121	129	121
query83	266	141	213	141
query84	273	68	76	68
query85	910	301	310	301
query86	347	300	309	300
query87	4727	4588	4701	4588
query88	3376	2227	2206	2206
query89	426	296	291	291
query90	2025	187	188	187
query91	139	101	103	101
query92	70	48	50	48
query93	1267	586	542	542
query94	745	293	297	293
query95	346	243	240	240
query96	622	275	277	275
query97	2844	2685	2675	2675
query98	214	194	192	192
query99	1593	1314	1313	1313
Total cold run time: 319065 ms
Total hot run time: 198568 ms

doris-robot · 2024-12-04T14:59:22Z

ClickBench: Total hot run time: 33.66 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b34ce67cedef411330e347b388084925c81b1d38, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.63	0.10	0.11
query5	0.44	0.40	0.42
query6	1.14	0.67	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.54	0.49
query10	0.55	0.56	0.56
query11	0.15	0.10	0.10
query12	0.14	0.10	0.12
query13	0.62	0.60	0.60
query14	2.71	2.73	2.83
query15	0.92	0.84	0.82
query16	0.41	0.39	0.38
query17	1.00	1.05	1.05
query18	0.23	0.19	0.19
query19	1.94	1.80	2.03
query20	0.01	0.01	0.01
query21	15.36	0.61	0.60
query22	2.55	2.79	2.41
query23	17.03	0.95	0.85
query24	2.96	1.88	1.41
query25	0.28	0.12	0.17
query26	0.35	0.14	0.14
query27	0.05	0.05	0.04
query28	10.06	1.11	1.07
query29	12.52	3.22	3.18
query30	0.24	0.07	0.07
query31	2.84	0.38	0.38
query32	3.27	0.47	0.47
query33	3.06	3.10	3.01
query34	17.09	4.50	4.48
query35	4.49	4.47	4.47
query36	0.66	0.49	0.49
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.14	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.15 s
Total hot run time: 33.66 s

morrySnow

same as #44958 it is better to escape value

w41ter · 2024-12-06T03:39:43Z

same as #44958 it is better to escape value

This PR aims to fix dt DATETIME DEFAULT "CURRENT_TIMESTAMP", the correct syntax is dt DATETIME DEFAULT CURRENT_TIMESTAMP.

w41ter · 2024-12-09T03:23:27Z

@wyxxxcat please add some unit tests.

w41ter · 2024-12-09T03:34:24Z

@wyxxxcat please add some unit tests.

You can refer https://github.com/apache/doris/pull/41205/files

wyxxxcat · 2024-12-11T02:09:47Z

run buildall

doris-robot · 2024-12-11T02:28:27Z

TPC-H: Total hot run time: 39836 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7328f746960b5c65f392c203353560368f412473, data reload: false

------ Round 1 ----------------------------------
q1	17610	7362	7308	7308
q2	2047	170	165	165
q3	10610	1126	1220	1126
q4	10588	803	734	734
q5	7606	2710	2717	2710
q6	235	147	145	145
q7	999	612	610	610
q8	9251	1865	1945	1865
q9	6644	6536	6424	6424
q10	7040	2283	2321	2283
q11	478	254	254	254
q12	408	219	219	219
q13	17778	3082	2985	2985
q14	245	210	212	210
q15	576	525	514	514
q16	655	567	585	567
q17	971	499	472	472
q18	7272	6698	6702	6698
q19	1360	1013	959	959
q20	470	177	182	177
q21	3990	3098	3170	3098
q22	383	327	313	313
Total cold run time: 107216 ms
Total hot run time: 39836 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7215	7175	7234	7175
q2	332	230	226	226
q3	2892	2773	2953	2773
q4	2153	1878	1858	1858
q5	5683	5665	5617	5617
q6	231	142	149	142
q7	2273	1826	1833	1826
q8	3401	3531	3490	3490
q9	8957	8943	8941	8941
q10	3600	3530	3588	3530
q11	600	503	504	503
q12	849	616	630	616
q13	11452	3199	3198	3198
q14	304	267	278	267
q15	568	528	527	527
q16	663	651	653	651
q17	1886	1652	1597	1597
q18	8342	7775	7505	7505
q19	1673	1464	1505	1464
q20	2090	1859	1862	1859
q21	5688	5483	5442	5442
q22	641	626	574	574
Total cold run time: 71493 ms
Total hot run time: 59781 ms

doris-robot · 2024-12-11T02:41:03Z

TPC-DS: Total hot run time: 197010 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7328f746960b5c65f392c203353560368f412473, data reload: false

query1	1271	954	968	954
query2	6274	2064	2108	2064
query3	10938	4278	4495	4278
query4	66260	28829	23602	23602
query5	4939	501	462	462
query6	424	185	172	172
query7	5503	306	317	306
query8	323	242	233	233
query9	8992	2716	2719	2716
query10	428	253	250	250
query11	17260	15288	15813	15288
query12	159	114	109	109
query13	1475	428	433	428
query14	10723	7170	7712	7170
query15	217	193	202	193
query16	7386	456	455	455
query17	1102	578	569	569
query18	1700	301	294	294
query19	188	142	147	142
query20	146	109	111	109
query21	209	102	98	98
query22	4911	4602	4465	4465
query23	34852	34493	34244	34244
query24	5491	2581	2578	2578
query25	491	404	381	381
query26	643	147	143	143
query27	2171	283	284	283
query28	4382	2502	2448	2448
query29	679	440	406	406
query30	206	152	163	152
query31	1019	843	841	841
query32	64	52	58	52
query33	415	298	295	295
query34	951	522	517	517
query35	890	756	751	751
query36	1083	972	988	972
query37	123	75	70	70
query38	4510	4358	4438	4358
query39	1472	1507	1483	1483
query40	202	96	105	96
query41	45	41	45	41
query42	111	97	97	97
query43	553	506	512	506
query44	1183	821	827	821
query45	187	167	171	167
query46	1186	760	724	724
query47	2066	1922	1937	1922
query48	428	317	318	317
query49	729	381	411	381
query50	833	391	388	388
query51	7456	7252	6958	6958
query52	97	84	91	84
query53	261	176	173	173
query54	509	396	389	389
query55	77	72	75	72
query56	248	228	240	228
query57	1239	1107	1138	1107
query58	206	206	206	206
query59	3249	3166	3010	3010
query60	262	235	248	235
query61	106	111	123	111
query62	812	664	668	664
query63	208	179	182	179
query64	1365	654	630	630
query65	3246	3204	3226	3204
query66	707	290	319	290
query67	16003	15741	15748	15741
query68	3747	564	559	559
query69	435	252	243	243
query70	1219	1155	1138	1138
query71	376	244	243	243
query72	6410	4111	4040	4040
query73	774	352	361	352
query74	10279	9024	9069	9024
query75	3404	2682	2668	2668
query76	1930	1003	1048	1003
query77	484	279	270	270
query78	10393	9497	9460	9460
query79	1127	581	583	581
query80	835	425	424	424
query81	487	226	231	226
query82	1325	114	113	113
query83	250	140	152	140
query84	284	65	69	65
query85	870	303	299	299
query86	328	304	305	304
query87	4783	4523	4596	4523
query88	3380	2175	2162	2162
query89	418	305	289	289
query90	2003	182	181	181
query91	141	101	102	101
query92	67	50	51	50
query93	1242	520	532	520
query94	775	293	301	293
query95	338	247	248	247
query96	611	283	273	273
query97	2828	2647	2654	2647
query98	220	189	192	189
query99	1663	1311	1321	1311
Total cold run time: 317270 ms
Total hot run time: 197010 ms

doris-robot · 2024-12-11T02:46:32Z

ClickBench: Total hot run time: 32.84 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7328f746960b5c65f392c203353560368f412473, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.03	0.03
query3	0.23	0.07	0.08
query4	1.62	0.10	0.10
query5	0.42	0.40	0.40
query6	1.15	0.65	0.65
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.58	0.52	0.50
query10	0.54	0.57	0.54
query11	0.14	0.10	0.11
query12	0.15	0.11	0.11
query13	0.61	0.62	0.60
query14	2.70	2.73	2.72
query15	0.91	0.83	0.82
query16	0.39	0.38	0.39
query17	1.07	1.05	1.04
query18	0.22	0.21	0.22
query19	1.99	1.90	2.02
query20	0.02	0.01	0.01
query21	15.36	0.60	0.60
query22	2.37	2.34	1.89
query23	16.99	1.04	0.84
query24	3.19	1.00	1.19
query25	0.21	0.12	0.11
query26	0.54	0.14	0.13
query27	0.06	0.05	0.05
query28	10.51	1.10	1.08
query29	12.57	3.28	3.26
query30	0.25	0.07	0.06
query31	2.85	0.38	0.36
query32	3.30	0.46	0.46
query33	3.00	3.03	3.14
query34	17.07	4.48	4.46
query35	4.52	4.52	4.50
query36	0.67	0.48	0.51
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.84 s
Total hot run time: 32.84 s

wyxxxcat · 2024-12-11T06:04:33Z

run buildall

doris-robot · 2024-12-11T06:44:48Z

TPC-H: Total hot run time: 39826 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 298c2d134d9822896b18ddb4a24c0a2525c4090e, data reload: false

------ Round 1 ----------------------------------
q1	17611	7402	7258	7258
q2	2047	176	174	174
q3	10600	1083	1141	1083
q4	10555	711	761	711
q5	7582	2728	2683	2683
q6	241	149	149	149
q7	969	631	610	610
q8	9253	1799	1946	1799
q9	6706	6489	6420	6420
q10	7020	2330	2339	2330
q11	466	257	251	251
q12	425	226	223	223
q13	17764	3026	2981	2981
q14	243	204	212	204
q15	582	531	524	524
q16	669	587	581	581
q17	970	521	524	521
q18	7242	6721	6688	6688
q19	1342	982	959	959
q20	452	186	179	179
q21	3997	3181	3233	3181
q22	376	317	317	317
Total cold run time: 107112 ms
Total hot run time: 39826 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7257	7218	7265	7218
q2	329	232	224	224
q3	2862	2754	2913	2754
q4	2066	1860	1810	1810
q5	5620	5688	5619	5619
q6	228	141	141	141
q7	2284	1815	1816	1815
q8	3338	3532	3505	3505
q9	8923	9057	9105	9057
q10	3565	3536	3567	3536
q11	587	497	531	497
q12	803	624	641	624
q13	12512	3287	3314	3287
q14	312	269	271	269
q15	580	534	533	533
q16	701	648	648	648
q17	1840	1612	1584	1584
q18	8365	7673	7691	7673
q19	1737	1652	1629	1629
q20	2113	1903	1870	1870
q21	5637	5493	5385	5385
q22	656	573	563	563
Total cold run time: 72315 ms
Total hot run time: 60241 ms

doris-robot · 2024-12-11T06:57:32Z

TPC-DS: Total hot run time: 197170 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 298c2d134d9822896b18ddb4a24c0a2525c4090e, data reload: false

query1	1277	976	965	965
query2	6275	2071	1996	1996
query3	11030	4433	4693	4433
query4	66258	28638	23533	23533
query5	5018	461	480	461
query6	409	188	180	180
query7	5692	302	296	296
query8	331	250	238	238
query9	9327	2751	2703	2703
query10	482	245	259	245
query11	17720	15398	15888	15398
query12	163	101	108	101
query13	1636	412	413	412
query14	10873	7632	7116	7116
query15	233	195	198	195
query16	7131	443	490	443
query17	1405	567	552	552
query18	1841	299	291	291
query19	249	160	153	153
query20	121	114	117	114
query21	213	112	102	102
query22	4961	4547	4679	4547
query23	35666	34614	34238	34238
query24	5536	2510	2444	2444
query25	483	374	377	374
query26	635	154	155	154
query27	1859	276	290	276
query28	4319	2505	2484	2484
query29	675	433	407	407
query30	208	153	147	147
query31	992	833	830	830
query32	69	60	55	55
query33	437	301	291	291
query34	956	514	530	514
query35	901	795	769	769
query36	1079	962	971	962
query37	122	92	83	83
query38	4507	4411	4495	4411
query39	1525	1493	1481	1481
query40	206	103	99	99
query41	46	44	43	43
query42	122	96	97	96
query43	542	488	490	488
query44	1188	831	827	827
query45	188	168	173	168
query46	1197	743	749	743
query47	2060	1913	1957	1913
query48	434	328	315	315
query49	729	405	388	388
query50	836	407	392	392
query51	7272	7371	7011	7011
query52	97	85	83	83
query53	260	176	183	176
query54	510	392	385	385
query55	77	79	77	77
query56	237	264	239	239
query57	1268	1113	1141	1113
query58	215	201	209	201
query59	3152	2987	2995	2987
query60	262	238	267	238
query61	105	107	109	107
query62	775	682	660	660
query63	207	182	186	182
query64	1404	649	649	649
query65	3351	3217	3178	3178
query66	708	354	306	306
query67	16092	15859	15922	15859
query68	4212	547	553	547
query69	436	254	249	249
query70	1204	1059	1131	1059
query71	348	251	275	251
query72	6196	4074	4017	4017
query73	766	354	347	347
query74	10305	9039	9102	9039
query75	3403	2704	2689	2689
query76	1861	976	1105	976
query77	507	272	264	264
query78	10667	9477	9385	9385
query79	2124	595	591	591
query80	1274	424	429	424
query81	510	245	230	230
query82	1190	121	125	121
query83	208	145	139	139
query84	282	74	74	74
query85	1021	312	383	312
query86	413	268	306	268
query87	4683	4738	4579	4579
query88	3659	2223	2168	2168
query89	427	299	288	288
query90	2027	184	184	184
query91	131	100	103	100
query92	67	47	50	47
query93	3040	527	522	522
query94	912	288	285	285
query95	347	244	246	244
query96	640	274	276	274
query97	2849	2671	2661	2661
query98	219	193	190	190
query99	1675	1333	1329	1329
Total cold run time: 323757 ms
Total hot run time: 197170 ms

doris-robot · 2024-12-11T07:03:03Z

ClickBench: Total hot run time: 32.65 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 298c2d134d9822896b18ddb4a24c0a2525c4090e, data reload: false

query1	0.04	0.05	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.63	0.10	0.10
query5	0.43	0.42	0.39
query6	1.17	0.66	0.66
query7	0.01	0.02	0.02
query8	0.04	0.03	0.04
query9	0.56	0.50	0.48
query10	0.56	0.58	0.56
query11	0.14	0.10	0.11
query12	0.13	0.11	0.11
query13	0.60	0.60	0.60
query14	2.68	2.83	2.86
query15	0.90	0.82	0.83
query16	0.39	0.38	0.36
query17	1.07	1.04	1.08
query18	0.23	0.21	0.22
query19	2.00	1.87	2.00
query20	0.01	0.01	0.01
query21	15.36	0.62	0.61
query22	3.30	2.88	1.82
query23	16.93	1.19	0.74
query24	3.52	1.82	0.95
query25	0.20	0.21	0.06
query26	0.56	0.13	0.13
query27	0.05	0.05	0.04
query28	10.47	1.11	1.08
query29	12.64	3.28	3.23
query30	0.25	0.06	0.05
query31	2.87	0.39	0.37
query32	3.27	0.48	0.46
query33	2.95	3.05	3.06
query34	17.11	4.42	4.48
query35	4.51	4.53	4.53
query36	0.67	0.48	0.48
query37	0.09	0.06	0.07
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.17	0.13	0.13
query41	0.07	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 108.04 s
Total hot run time: 32.65 s

wyxxxcat · 2024-12-11T07:30:07Z

run p0

github-actions · 2024-12-11T08:38:11Z

PR approved by anyone and no changes requested.

fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java

starocean999 · 2024-12-12T02:16:09Z

please update fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/DefaultValue.java for nereids, too

wyxxxcat · 2024-12-12T08:18:37Z

run buildall

doris-robot · 2024-12-12T08:37:33Z

TPC-H: Total hot run time: 40125 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 39a8004b55af1c024d87c660e96e71d4eaff90e9, data reload: false

------ Round 1 ----------------------------------
q1	17582	7407	7277	7277
q2	2050	175	171	171
q3	10610	1063	1170	1063
q4	10571	723	708	708
q5	7640	2732	2711	2711
q6	233	146	143	143
q7	989	628	621	621
q8	9245	1847	1934	1847
q9	6691	6510	6527	6510
q10	6968	2282	2319	2282
q11	456	248	255	248
q12	434	225	220	220
q13	17767	3028	3053	3028
q14	241	220	207	207
q15	571	530	512	512
q16	621	583	579	579
q17	989	551	556	551
q18	7226	6756	6751	6751
q19	1354	994	1067	994
q20	477	188	182	182
q21	3996	3254	3217	3217
q22	373	303	321	303
Total cold run time: 107084 ms
Total hot run time: 40125 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7267	7176	7213	7176
q2	332	233	233	233
q3	2870	2795	2965	2795
q4	2084	1867	1859	1859
q5	5625	5670	5630	5630
q6	230	148	145	145
q7	2265	1841	1883	1841
q8	3425	3588	3556	3556
q9	8991	9160	8988	8988
q10	3593	3513	3549	3513
q11	603	492	502	492
q12	822	617	632	617
q13	11615	3228	3177	3177
q14	293	284	282	282
q15	569	515	525	515
q16	676	666	642	642
q17	1855	1651	1597	1597
q18	8323	7812	7761	7761
q19	4536	1569	1498	1498
q20	2061	1851	1859	1851
q21	5595	5531	5499	5499
q22	619	582	554	554
Total cold run time: 74249 ms
Total hot run time: 60221 ms

doris-robot · 2024-12-12T08:50:12Z

TPC-DS: Total hot run time: 195892 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 39a8004b55af1c024d87c660e96e71d4eaff90e9, data reload: false

query1	1303	924	966	924
query2	6251	2093	2150	2093
query3	10956	4425	4248	4248
query4	66862	28635	23463	23463
query5	5033	453	426	426
query6	392	180	190	180
query7	5474	319	293	293
query8	310	229	227	227
query9	8841	2698	2687	2687
query10	425	241	235	235
query11	17119	15224	15624	15224
query12	154	101	106	101
query13	1482	428	432	428
query14	10531	6608	7766	6608
query15	226	177	204	177
query16	6927	467	458	458
query17	1119	543	553	543
query18	1834	309	306	306
query19	203	156	150	150
query20	132	112	139	112
query21	207	115	104	104
query22	4940	4727	4512	4512
query23	34660	33795	33983	33795
query24	5386	2545	2484	2484
query25	486	383	396	383
query26	630	158	154	154
query27	1823	299	296	296
query28	4258	2484	2492	2484
query29	707	457	446	446
query30	207	151	155	151
query31	1021	841	875	841
query32	67	58	56	56
query33	437	310	303	303
query34	974	515	534	515
query35	899	769	769	769
query36	1073	983	961	961
query37	115	69	75	69
query38	4404	4346	4379	4346
query39	1501	1630	1473	1473
query40	208	98	98	98
query41	45	44	45	44
query42	114	93	103	93
query43	561	522	506	506
query44	1187	862	859	859
query45	199	168	170	168
query46	1183	726	733	726
query47	2012	1936	1929	1929
query48	426	341	323	323
query49	710	402	420	402
query50	810	400	387	387
query51	7346	7309	7085	7085
query52	96	91	91	91
query53	257	181	173	173
query54	512	392	386	386
query55	79	76	71	71
query56	260	245	234	234
query57	1271	1131	1131	1131
query58	213	207	205	205
query59	3192	3047	3109	3047
query60	281	245	251	245
query61	110	106	107	106
query62	796	690	661	661
query63	215	195	185	185
query64	1354	690	715	690
query65	3251	3140	3217	3140
query66	702	295	317	295
query67	16147	15980	15539	15539
query68	4360	556	567	556
query69	425	256	249	249
query70	1204	1156	1103	1103
query71	356	242	265	242
query72	6462	4025	4150	4025
query73	764	357	360	357
query74	10235	9004	9046	9004
query75	3355	2644	2692	2644
query76	1959	1075	1065	1065
query77	476	283	268	268
query78	10400	9481	9402	9402
query79	2203	639	605	605
query80	1417	418	433	418
query81	502	226	222	222
query82	1272	118	112	112
query83	172	153	152	152
query84	279	69	71	69
query85	1008	312	322	312
query86	386	299	300	299
query87	4681	4599	4616	4599
query88	3703	2221	2200	2200
query89	420	292	290	290
query90	1975	181	181	181
query91	132	103	107	103
query92	66	49	49	49
query93	3016	564	552	552
query94	858	294	294	294
query95	356	248	243	243
query96	634	281	278	278
query97	2846	2661	2702	2661
query98	222	197	197	197
query99	1594	1297	1334	1297
Total cold run time: 320644 ms
Total hot run time: 195892 ms

doris-robot · 2024-12-12T08:55:40Z

ClickBench: Total hot run time: 32.32 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 39a8004b55af1c024d87c660e96e71d4eaff90e9, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.03	0.03
query3	0.23	0.06	0.07
query4	1.64	0.11	0.10
query5	0.41	0.41	0.42
query6	1.17	0.65	0.65
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.58	0.50	0.49
query10	0.55	0.60	0.56
query11	0.14	0.10	0.11
query12	0.14	0.11	0.11
query13	0.61	0.61	0.59
query14	2.75	2.81	2.71
query15	0.90	0.83	0.83
query16	0.39	0.38	0.38
query17	1.01	0.99	1.01
query18	0.22	0.21	0.21
query19	1.90	1.80	2.00
query20	0.01	0.01	0.01
query21	15.38	0.60	0.58
query22	2.64	1.70	1.91
query23	17.02	0.91	0.84
query24	2.94	1.54	0.98
query25	0.14	0.14	0.17
query26	0.57	0.15	0.13
query27	0.04	0.04	0.04
query28	10.40	1.09	1.07
query29	12.56	3.19	3.16
query30	0.25	0.07	0.06
query31	2.87	0.37	0.38
query32	3.28	0.45	0.46
query33	3.07	3.01	3.05
query34	16.89	4.42	4.45
query35	4.51	4.49	4.51
query36	0.66	0.48	0.49
query37	0.09	0.06	0.05
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.13	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 106.53 s
Total hot run time: 32.32 s

github-actions · 2024-12-12T09:17:51Z

PR approved by at least one committer and no changes requested.

dataroaring

LGTM

Cherry-picked from #44997 Co-authored-by: Uniqueyou <[email protected]>

Cherry-picked from #44997

wyxxxcat force-pushed the tosql_column_default branch from d2d8509 to 9101839 Compare December 4, 2024 11:49

wyxxxcat force-pushed the tosql_column_default branch from 9101839 to b34ce67 Compare December 4, 2024 13:49

dataroaring changed the title ~~[Fix] Fix error result for column tosql~~ [fix](sql) Fix error result for column tosql Dec 5, 2024

dataroaring added dev/2.1.x dev/3.0.x labels Dec 5, 2024

morrySnow reviewed Dec 5, 2024

View reviewed changes

wyxxxcat force-pushed the tosql_column_default branch 3 times, most recently from ae79a75 to 7328f74 Compare December 11, 2024 02:08

wyxxxcat force-pushed the tosql_column_default branch from 7328f74 to 298c2d1 Compare December 11, 2024 03:31

github-actions bot added the reviewed label Dec 11, 2024

starocean999 reviewed Dec 11, 2024

View reviewed changes

fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java Show resolved Hide resolved

1

39a8004

wyxxxcat dismissed w41ter’s stale review via 39a8004 December 12, 2024 08:18

wyxxxcat force-pushed the tosql_column_default branch from 298c2d1 to 39a8004 Compare December 12, 2024 08:18

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 12, 2024

w41ter approved these changes Dec 12, 2024

View reviewed changes

w41ter requested a review from starocean999 December 12, 2024 09:17

github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 12, 2024

dataroaring approved these changes Dec 12, 2024

View reviewed changes

w41ter merged commit 044cb5a into apache:master Dec 13, 2024
27 of 29 checks passed

github-actions bot pushed a commit that referenced this pull request Dec 13, 2024

[fix](sql) Fix error result for column tosql (#44997)

792198f

github-actions bot mentioned this pull request Dec 13, 2024

branch-3.0: [fix](sql) Fix error result for column tosql #44997 #45395

Merged

github-actions bot pushed a commit that referenced this pull request Dec 13, 2024

[fix](sql) Fix error result for column tosql (#44997)

efb7acd

github-actions bot mentioned this pull request Dec 13, 2024

branch-2.1: [fix](sql) Fix error result for column tosql #44997 #45397

Closed

This was referenced Dec 13, 2024

[Test](ccr) add test for alter table default value selectdb/ccr-syncer#315

Merged

branch-2.1: [fix](sql) Fix error result for column tosql #44997 #45582

Merged

w41ter pushed a commit that referenced this pull request Dec 18, 2024

branch-3.0: [fix](sql) Fix error result for column tosql #44997 (#45395)

aed6d47

Cherry-picked from #44997 Co-authored-by: Uniqueyou <[email protected]>

w41ter added dev/3.0.4-merged and removed dev/3.0.x labels Dec 18, 2024

yiguolei pushed a commit that referenced this pull request Dec 19, 2024

branch-2.1: [fix](sql) Fix error result for column tosql #44997 (#45582)

55ef1a6

Cherry-picked from #44997

yiguolei added dev/2.1.8-merged and removed dev/2.1.x labels Dec 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fix](sql) Fix error result for column tosql #44997

[fix](sql) Fix error result for column tosql #44997

wyxxxcat commented Dec 4, 2024 •

edited

Loading

wyxxxcat commented Dec 4, 2024

doris-robot commented Dec 4, 2024

doris-robot commented Dec 4, 2024

wyxxxcat commented Dec 4, 2024

wyxxxcat commented Dec 4, 2024

doris-robot commented Dec 4, 2024

doris-robot commented Dec 4, 2024

doris-robot commented Dec 4, 2024

morrySnow left a comment

w41ter commented Dec 6, 2024

w41ter commented Dec 9, 2024

w41ter commented Dec 9, 2024

wyxxxcat commented Dec 11, 2024

doris-robot commented Dec 11, 2024

doris-robot commented Dec 11, 2024

doris-robot commented Dec 11, 2024

wyxxxcat commented Dec 11, 2024

doris-robot commented Dec 11, 2024

doris-robot commented Dec 11, 2024

doris-robot commented Dec 11, 2024

wyxxxcat commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

starocean999 commented Dec 12, 2024

wyxxxcat commented Dec 12, 2024

doris-robot commented Dec 12, 2024

doris-robot commented Dec 12, 2024

doris-robot commented Dec 12, 2024

github-actions bot commented Dec 12, 2024

dataroaring left a comment

[fix](sql) Fix error result for column tosql #44997

[fix](sql) Fix error result for column tosql #44997

Conversation

wyxxxcat commented Dec 4, 2024 • edited Loading

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

wyxxxcat commented Dec 4, 2024

doris-robot commented Dec 4, 2024

doris-robot commented Dec 4, 2024

wyxxxcat commented Dec 4, 2024

wyxxxcat commented Dec 4, 2024

doris-robot commented Dec 4, 2024

doris-robot commented Dec 4, 2024

doris-robot commented Dec 4, 2024

morrySnow left a comment

Choose a reason for hiding this comment

w41ter commented Dec 6, 2024

w41ter commented Dec 9, 2024

w41ter commented Dec 9, 2024

wyxxxcat commented Dec 11, 2024

doris-robot commented Dec 11, 2024

doris-robot commented Dec 11, 2024

doris-robot commented Dec 11, 2024

wyxxxcat commented Dec 11, 2024

doris-robot commented Dec 11, 2024

doris-robot commented Dec 11, 2024

doris-robot commented Dec 11, 2024

wyxxxcat commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

starocean999 commented Dec 12, 2024

wyxxxcat commented Dec 12, 2024

doris-robot commented Dec 12, 2024

doris-robot commented Dec 12, 2024

doris-robot commented Dec 12, 2024

github-actions bot commented Dec 12, 2024

dataroaring left a comment

Choose a reason for hiding this comment

wyxxxcat commented Dec 4, 2024 •

edited

Loading