Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] (nereids)implement adminRebalanceDiskCommand in nereids #45108

Merged
merged 11 commits into from
Dec 17, 2024
Merged

[Enhancement] (nereids)implement adminRebalanceDiskCommand in nereids #45108

merged 11 commits into from
Dec 17, 2024

Conversation

DongLiang-0
Copy link
Contributor

@DongLiang-0 DongLiang-0 commented Dec 6, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #42844, #42845

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@DongLiang-0
Copy link
Contributor Author

run buildall

@DongLiang-0 DongLiang-0 force-pushed the neredis-rebalance-disk branch from 323b229 to 73990ae Compare December 9, 2024 02:56
@DongLiang-0
Copy link
Contributor Author

run buildall

1 similar comment
@DongLiang-0
Copy link
Contributor Author

run buildall

@DongLiang-0 DongLiang-0 force-pushed the neredis-rebalance-disk branch from 0b18a6d to 91c587d Compare December 11, 2024 02:35
@DongLiang-0
Copy link
Contributor Author

run buildall

LiBinfeng-01
LiBinfeng-01 reviewed Dec 11, 2024
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java Outdated
if (ctx.ON() != null) {
List<String> backendList = Lists.newArrayList();
ctx.backends.forEach(backend -> backendList.add(stripQuotes(backend.getText())));
return new AdminRebalanceDiskCommand(true, backendList);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls use two commands but not one command to implement this feature. Planner also use two stmt to do so

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Binfeng said, you can create a base class like RebalanceDiskCommand and put common logic there, the use two different sub classes to implement the two commands

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out the problem here, I will do.

@DongLiang-0
Copy link
Contributor Author

run buildall

1 similar comment
@DongLiang-0
Copy link
Contributor Author

run buildall

@DongLiang-0 DongLiang-0 force-pushed the neredis-rebalance-disk branch from ef586b7 to 9f127d5 Compare December 13, 2024 08:16
@DongLiang-0
Copy link
Contributor Author

run buildall

@DongLiang-0 DongLiang-0 force-pushed the neredis-rebalance-disk branch from 070ccbc to 9f127d5 Compare December 16, 2024 06:33
@DongLiang-0
Copy link
Contributor Author

run buildall

@DongLiang-0 DongLiang-0 force-pushed the neredis-rebalance-disk branch from 11d893a to ac265ce Compare December 16, 2024 07:57
@DongLiang-0
Copy link
Contributor Author

run buildall

@DongLiang-0
Copy link
Contributor Author

run buildall

@DongLiang-0
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@starocean999 starocean999 merged commit d670ec2 into apache:master Dec 17, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiBinfeng-01 LiBinfeng-01 LiBinfeng-01 approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] (nereids)implement adminRebalanceDiskCommand in nereids
4 participants
@DongLiang-0 @doris-robot @starocean999 @LiBinfeng-01