Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] (nereids)implement alterCatalogPropertiesCommand in ner… #45164

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[Enhancement] (nereids)implement alterCatalogPropertiesCommand in ner… #45164

wants to merge 3 commits into from

Conversation

msridhar78
Copy link
Contributor

…eids

What problem does this PR solve?

Issue Number: close #42789

Related PR: #xxx

Problem Summary:
Enhancement] (nereids)implement alterCatalogPropertiesCommand in nereids

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@msridhar78
Copy link
Contributor Author

run buildall

@starocean999
Copy link
Contributor

please refer to #45160

@msridhar78 msridhar78 force-pushed the alter_catalog_properties branch from fbbe31f to 7b3de4b Compare December 20, 2024 06:20
@msridhar78 msridhar78 force-pushed the alter_catalog_properties branch from 7b3de4b to 97ee4c6 Compare December 20, 2024 06:22
@msridhar78
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40041 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 97ee4c6a9d94a6293cfb6931cb235c3efd77a009, data reload: false

------ Round 1 ----------------------------------
q1	17625	8422	7355	7355
q2	2067	187	163	163
q3	10748	1083	1243	1083
q4	10592	715	729	715
q5	7613	2778	2692	2692
q6	247	149	144	144
q7	985	635	610	610
q8	9256	1823	1965	1823
q9	6668	6478	6408	6408
q10	7010	2316	2372	2316
q11	458	271	253	253
q12	437	222	228	222
q13	17760	2955	2947	2947
q14	250	210	212	210
q15	577	503	507	503
q16	666	606	594	594
q17	990	547	546	546
q18	7414	6853	6815	6815
q19	1340	990	991	990
q20	484	191	184	184
q21	4100	3158	3212	3158
q22	401	314	310	310
Total cold run time: 107688 ms
Total hot run time: 40041 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7248	7254	7235	7235
q2	335	228	232	228
q3	2883	2958	2944	2944
q4	2042	1878	1847	1847
q5	5603	5636	5645	5636
q6	233	141	145	141
q7	2225	1877	1841	1841
q8	3384	3572	3565	3565
q9	8948	8956	9012	8956
q10	3600	3579	3585	3579
q11	611	502	489	489
q12	787	609	597	597
q13	11821	3099	3118	3099
q14	326	266	293	266
q15	564	508	501	501
q16	728	657	662	657
q17	1847	1616	1627	1616
q18	8302	7968	7624	7624
q19	1734	1484	1524	1484
q20	2141	1894	1885	1885
q21	5699	5484	5434	5434
q22	635	584	564	564
Total cold run time: 71696 ms
Total hot run time: 60188 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196392 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 97ee4c6a9d94a6293cfb6931cb235c3efd77a009, data reload: false

query1	1328	1000	930	930
query2	6253	2399	2259	2259
query3	10941	4731	4751	4731
query4	33694	23389	23481	23389
query5	4755	469	447	447
query6	299	200	186	186
query7	4003	302	303	302
query8	304	240	235	235
query9	9590	2720	2677	2677
query10	479	247	251	247
query11	18362	15237	15115	15115
query12	161	104	108	104
query13	1634	432	430	430
query14	11451	7135	7269	7135
query15	296	187	187	187
query16	8057	449	472	449
query17	1748	595	592	592
query18	2188	298	317	298
query19	363	162	151	151
query20	121	119	111	111
query21	207	109	117	109
query22	4962	4926	4729	4729
query23	34333	33610	33896	33610
query24	10403	2539	2477	2477
query25	615	390	395	390
query26	1223	161	152	152
query27	2840	332	331	331
query28	7544	2485	2492	2485
query29	851	422	408	408
query30	229	147	153	147
query31	1047	836	862	836
query32	98	62	57	57
query33	769	291	322	291
query34	970	521	529	521
query35	894	761	745	745
query36	1125	960	965	960
query37	137	83	72	72
query38	4463	4158	4203	4158
query39	1581	1456	1443	1443
query40	205	103	100	100
query41	48	45	44	44
query42	119	103	99	99
query43	527	495	481	481
query44	1255	825	822	822
query45	190	176	164	164
query46	1186	728	743	728
query47	2050	1904	1905	1904
query48	429	324	327	324
query49	880	410	419	410
query50	850	388	388	388
query51	7299	7060	7272	7060
query52	110	92	103	92
query53	273	181	185	181
query54	1073	410	421	410
query55	81	83	79	79
query56	274	247	267	247
query57	1286	1194	1150	1150
query58	229	223	235	223
query59	3350	3350	3217	3217
query60	284	245	251	245
query61	105	109	103	103
query62	892	714	710	710
query63	224	191	184	184
query64	4076	698	652	652
query65	3287	3205	3235	3205
query66	801	308	305	305
query67	16089	15696	15546	15546
query68	4903	537	548	537
query69	466	253	242	242
query70	1203	1143	1126	1126
query71	455	254	248	248
query72	6893	4178	4009	4009
query73	770	351	365	351
query74	10361	8813	8809	8809
query75	3571	2630	2643	2630
query76	3470	1109	1039	1039
query77	637	269	272	269
query78	10356	9425	9506	9425
query79	1534	599	602	599
query80	977	416	407	407
query81	568	232	222	222
query82	521	115	124	115
query83	280	142	143	142
query84	230	71	72	71
query85	1334	304	312	304
query86	449	300	300	300
query87	4438	4453	4291	4291
query88	3766	2202	2160	2160
query89	420	334	290	290
query90	2068	185	183	183
query91	141	107	106	106
query92	71	52	56	52
query93	2384	552	545	545
query94	1036	273	279	273
query95	358	248	244	244
query96	626	281	284	281
query97	2841	2652	2697	2652
query98	220	200	198	198
query99	1554	1324	1303	1303
Total cold run time: 306691 ms
Total hot run time: 196392 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.73 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 97ee4c6a9d94a6293cfb6931cb235c3efd77a009, data reload: false

query1	0.03	0.03	0.02
query2	0.07	0.03	0.03
query3	0.23	0.08	0.07
query4	1.61	0.11	0.10
query5	0.44	0.42	0.42
query6	1.17	0.66	0.68
query7	0.03	0.01	0.01
query8	0.04	0.04	0.03
query9	0.59	0.49	0.51
query10	0.57	0.58	0.56
query11	0.14	0.11	0.10
query12	0.14	0.11	0.11
query13	0.61	0.61	0.59
query14	2.79	2.83	2.75
query15	0.92	0.82	0.82
query16	0.38	0.39	0.37
query17	1.07	1.05	1.02
query18	0.22	0.21	0.19
query19	1.84	1.85	2.02
query20	0.02	0.01	0.01
query21	15.36	0.58	0.57
query22	2.32	1.60	2.20
query23	16.95	1.03	0.78
query24	3.32	0.26	0.63
query25	0.26	0.13	0.06
query26	0.43	0.14	0.14
query27	0.04	0.04	0.04
query28	11.48	1.10	1.08
query29	12.56	3.28	3.29
query30	0.24	0.06	0.06
query31	2.86	0.39	0.38
query32	3.25	0.46	0.45
query33	3.10	3.13	3.14
query34	16.99	4.45	4.45
query35	4.50	4.47	4.45
query36	0.68	0.49	0.51
query37	0.10	0.06	0.07
query38	0.05	0.04	0.03
query39	0.04	0.03	0.03
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.02	0.03
Total cold run time: 107.77 s
Total hot run time: 31.73 s

@msridhar78
Copy link
Contributor Author

run buildall

@msridhar78
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39651 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1878c683af0388357e106e0789282e4ff44688e6, data reload: false

------ Round 1 ----------------------------------
q1	17610	8092	7236	7236
q2	2056	184	165	165
q3	10598	1051	1166	1051
q4	10556	676	739	676
q5	7576	2689	2637	2637
q6	237	150	148	148
q7	964	610	605	605
q8	9257	1834	1867	1834
q9	6596	6412	6385	6385
q10	7010	2312	2305	2305
q11	473	259	255	255
q12	429	223	218	218
q13	17785	2952	2935	2935
q14	246	211	215	211
q15	546	511	497	497
q16	674	592	597	592
q17	965	559	588	559
q18	7417	6754	6921	6754
q19	1355	982	912	912
q20	466	190	190	190
q21	4284	3171	3200	3171
q22	401	319	315	315
Total cold run time: 107501 ms
Total hot run time: 39651 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7195	7187	7207	7187
q2	334	227	235	227
q3	2862	2833	2937	2833
q4	2057	1818	1763	1763
q5	5656	5644	5615	5615
q6	222	144	137	137
q7	2286	1813	1790	1790
q8	3382	3510	3452	3452
q9	8862	9008	8880	8880
q10	3577	3500	3524	3500
q11	603	513	503	503
q12	825	623	592	592
q13	12388	3193	3135	3135
q14	302	274	285	274
q15	551	514	498	498
q16	695	663	656	656
q17	1837	1624	1595	1595
q18	8409	7782	7724	7724
q19	2062	1519	1552	1519
q20	2049	1866	1917	1866
q21	5507	5452	5385	5385
q22	648	576	589	576
Total cold run time: 72309 ms
Total hot run time: 59707 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195926 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1878c683af0388357e106e0789282e4ff44688e6, data reload: false

query1	1296	981	916	916
query2	6233	2487	2425	2425
query3	10979	4427	4657	4427
query4	33386	23413	23604	23413
query5	4034	482	480	480
query6	292	201	189	189
query7	3996	306	313	306
query8	313	243	236	236
query9	9405	2749	2740	2740
query10	452	261	248	248
query11	17849	15286	15084	15084
query12	161	106	114	106
query13	1589	432	441	432
query14	8805	6620	6756	6620
query15	267	190	201	190
query16	8286	468	470	468
query17	1624	586	570	570
query18	2205	318	308	308
query19	335	154	163	154
query20	125	121	110	110
query21	208	107	105	105
query22	4798	4521	4422	4422
query23	36641	33669	34618	33669
query24	12270	2610	2528	2528
query25	539	401	405	401
query26	774	164	156	156
query27	2994	343	330	330
query28	7852	2463	2514	2463
query29	689	445	408	408
query30	237	147	158	147
query31	1040	799	821	799
query32	98	55	56	55
query33	755	296	298	296
query34	1171	522	533	522
query35	897	795	796	795
query36	1087	1009	987	987
query37	122	84	74	74
query38	4454	4150	4035	4035
query39	1517	1511	1445	1445
query40	199	101	102	101
query41	46	43	45	43
query42	119	102	106	102
query43	531	509	508	508
query44	1264	829	817	817
query45	194	174	169	169
query46	1178	747	730	730
query47	2015	1952	1942	1942
query48	441	325	327	325
query49	909	411	408	408
query50	858	390	411	390
query51	7466	7258	7084	7084
query52	110	92	92	92
query53	266	188	194	188
query54	947	406	415	406
query55	90	79	79	79
query56	274	243	230	230
query57	1269	1182	1166	1166
query58	248	233	226	226
query59	3539	3141	3258	3141
query60	273	271	276	271
query61	116	107	114	107
query62	886	703	696	696
query63	231	189	196	189
query64	4039	710	656	656
query65	3342	3267	3265	3265
query66	749	299	312	299
query67	16660	15559	15484	15484
query68	6069	561	555	555
query69	487	257	258	257
query70	1224	1151	1088	1088
query71	469	256	246	246
query72	6852	4120	4087	4087
query73	794	382	367	367
query74	10016	8860	8913	8860
query75	3607	2665	2645	2645
query76	3937	1055	1081	1055
query77	599	283	277	277
query78	10217	9462	9350	9350
query79	1133	599	585	585
query80	830	423	530	423
query81	519	232	222	222
query82	223	117	113	113
query83	198	145	144	144
query84	282	73	72	72
query85	936	304	305	304
query86	359	298	298	298
query87	4475	4497	4567	4497
query88	4199	2230	2211	2211
query89	408	295	287	287
query90	2009	183	184	183
query91	187	108	105	105
query92	69	49	53	49
query93	3294	571	556	556
query94	744	279	280	279
query95	356	254	251	251
query96	648	278	278	278
query97	2853	2623	2702	2623
query98	212	189	199	189
query99	1575	1316	1297	1297
Total cold run time: 307814 ms
Total hot run time: 195926 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.12 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1878c683af0388357e106e0789282e4ff44688e6, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.03	0.03
query3	0.23	0.08	0.07
query4	1.62	0.10	0.11
query5	0.42	0.43	0.40
query6	1.14	0.66	0.65
query7	0.02	0.02	0.02
query8	0.05	0.04	0.03
query9	0.58	0.51	0.51
query10	0.56	0.54	0.54
query11	0.15	0.10	0.10
query12	0.14	0.11	0.10
query13	0.60	0.61	0.59
query14	2.75	2.82	2.84
query15	0.91	0.83	0.83
query16	0.38	0.39	0.37
query17	1.04	1.01	1.01
query18	0.23	0.20	0.21
query19	1.98	1.89	2.01
query20	0.01	0.01	0.01
query21	15.36	0.57	0.61
query22	3.57	1.90	2.10
query23	17.00	0.92	0.75
query24	3.02	1.37	1.73
query25	0.19	0.14	0.13
query26	0.43	0.14	0.15
query27	0.05	0.04	0.04
query28	9.63	1.11	1.08
query29	12.58	3.25	3.23
query30	0.26	0.08	0.07
query31	2.83	0.38	0.38
query32	3.26	0.46	0.45
query33	3.08	3.14	3.06
query34	16.83	4.44	4.47
query35	4.47	4.49	4.44
query36	0.68	0.48	0.47
query37	0.09	0.06	0.06
query38	0.04	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.65 s
Total hot run time: 33.12 s

@msridhar78
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32728 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 417e630bcdccc5e7973a8a2874b90b088a9c7afb, data reload: false

------ Round 1 ----------------------------------
q1	17568	6131	6044	6044
q2	2044	313	181	181
q3	10426	1242	748	748
q4	10262	856	435	435
q5	8321	2177	1956	1956
q6	208	181	152	152
q7	883	770	615	615
q8	9280	1371	1224	1224
q9	5159	4897	4992	4897
q10	6793	2329	1861	1861
q11	470	282	255	255
q12	346	373	232	232
q13	17787	3602	3029	3029
q14	226	226	216	216
q15	565	524	526	524
q16	647	630	595	595
q17	591	876	348	348
q18	7101	6625	6253	6253
q19	2125	962	588	588
q20	320	330	188	188
q21	2943	2311	2073	2073
q22	369	348	314	314
Total cold run time: 104434 ms
Total hot run time: 32728 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6317	6233	6225	6225
q2	240	321	232	232
q3	2218	2704	2360	2360
q4	1452	1868	1433	1433
q5	4375	4770	4858	4770
q6	186	178	143	143
q7	2132	1981	1839	1839
q8	2689	2831	2708	2708
q9	7256	7164	7261	7164
q10	3056	3361	2764	2764
q11	571	524	490	490
q12	693	803	616	616
q13	3389	3835	3095	3095
q14	297	325	297	297
q15	559	524	499	499
q16	651	693	648	648
q17	1234	1723	1266	1266
q18	7755	7661	7398	7398
q19	901	1156	1079	1079
q20	2055	2055	1979	1979
q21	5894	5360	5077	5077
q22	637	636	622	622
Total cold run time: 54557 ms
Total hot run time: 52704 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197338 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 417e630bcdccc5e7973a8a2874b90b088a9c7afb, data reload: false

query1	1293	940	971	940
query2	6400	2337	2285	2285
query3	11003	4702	4660	4660
query4	32969	23731	23696	23696
query5	4270	623	450	450
query6	289	208	192	192
query7	3984	492	304	304
query8	306	257	233	233
query9	9329	2707	2711	2707
query10	469	311	244	244
query11	18131	15507	15200	15200
query12	163	105	99	99
query13	1557	560	416	416
query14	10446	7799	7427	7427
query15	262	221	194	194
query16	7152	647	488	488
query17	1554	782	613	613
query18	1248	377	337	337
query19	214	198	172	172
query20	119	116	118	116
query21	211	139	117	117
query22	4739	4556	4635	4556
query23	34183	33721	33745	33721
query24	6617	2258	2364	2258
query25	477	452	396	396
query26	759	272	155	155
query27	2295	465	331	331
query28	5441	2480	2482	2480
query29	536	545	417	417
query30	204	186	191	186
query31	973	904	881	881
query32	75	60	59	59
query33	473	349	292	292
query34	768	866	527	527
query35	800	840	775	775
query36	1028	1043	945	945
query37	120	93	79	79
query38	4455	4197	4270	4197
query39	1557	1498	1449	1449
query40	205	116	103	103
query41	50	44	45	44
query42	133	111	101	101
query43	520	537	486	486
query44	1332	827	827	827
query45	180	178	165	165
query46	859	1071	682	682
query47	2036	2009	1890	1890
query48	391	397	327	327
query49	724	495	407	407
query50	614	665	407	407
query51	7338	7349	7196	7196
query52	106	103	92	92
query53	228	270	191	191
query54	478	505	420	420
query55	81	76	77	76
query56	255	296	254	254
query57	1225	1237	1166	1166
query58	231	226	216	216
query59	3285	3272	3088	3088
query60	278	275	247	247
query61	109	114	107	107
query62	917	823	742	742
query63	232	194	189	189
query64	3106	1039	649	649
query65	3369	3292	3267	3267
query66	784	414	307	307
query67	16124	15789	15422	15422
query68	9920	747	518	518
query69	460	296	254	254
query70	1239	1165	1133	1133
query71	433	294	247	247
query72	6199	3736	3836	3736
query73	653	739	363	363
query74	10141	9334	8984	8984
query75	4584	3165	2679	2679
query76	5294	1187	767	767
query77	959	355	277	277
query78	10135	10317	9609	9609
query79	3424	892	582	582
query80	869	511	419	419
query81	488	266	243	243
query82	620	147	121	121
query83	198	160	202	160
query84	281	91	69	69
query85	779	377	300	300
query86	355	314	308	308
query87	4627	4389	4395	4389
query88	4239	2219	2216	2216
query89	418	328	304	304
query90	1888	187	195	187
query91	131	135	103	103
query92	68	54	53	53
query93	1797	899	526	526
query94	653	395	287	287
query95	331	269	256	256
query96	485	594	286	286
query97	2718	2850	2670	2670
query98	237	198	197	197
query99	1699	1531	1433	1433
Total cold run time: 298381 ms
Total hot run time: 197338 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.95 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 417e630bcdccc5e7973a8a2874b90b088a9c7afb, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.08	0.07
query4	1.61	0.11	0.10
query5	0.40	0.40	0.42
query6	1.18	0.65	0.65
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.60	0.49	0.52
query10	0.56	0.54	0.55
query11	0.14	0.10	0.12
query12	0.13	0.12	0.11
query13	0.62	0.61	0.59
query14	2.84	2.76	2.71
query15	0.90	0.83	0.83
query16	0.41	0.39	0.42
query17	1.01	1.00	1.05
query18	0.23	0.21	0.20
query19	1.92	1.90	1.98
query20	0.01	0.01	0.02
query21	15.37	0.86	0.58
query22	0.75	0.78	0.70
query23	15.28	1.44	0.61
query24	2.51	1.91	0.44
query25	0.20	0.14	0.22
query26	0.34	0.14	0.15
query27	0.05	0.05	0.05
query28	13.74	1.56	1.04
query29	12.59	4.15	3.39
query30	0.25	0.08	0.08
query31	2.81	0.58	0.39
query32	3.23	0.55	0.46
query33	3.11	3.16	3.04
query34	16.85	5.17	4.46
query35	4.47	4.51	4.46
query36	0.64	0.49	0.47
query37	0.10	0.07	0.06
query38	0.04	0.03	0.03
query39	0.04	0.03	0.02
query40	0.16	0.14	0.13
query41	0.08	0.02	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.02
Total cold run time: 105.65 s
Total hot run time: 30.95 s

starocean999
starocean999 reviewed Dec 30, 2024
View reviewed changes
...c/main/java/org/apache/doris/nereids/trees/plans/commands/AlterCatalogPropertiesCommand.java

@Override
public void doRun(ConnectContext ctx, StmtExecutor executor) throws Exception {
PropertyAnalyzer.checkCatalogProperties(newProperties, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think should call super class's validate method here. And please do same for AlterCatalogCommentCommand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starocean999 starocean999 starocean999 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] (nereids)implement alterCatalogPropertiesCommand in nereids
3 participants
@msridhar78 @doris-robot @starocean999