Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] (inverted index) Disallow variant columns from using inverted index format v1 (#43599) #45179

Merged
merged 4 commits into from
Dec 11, 2024
Merged

[fix] (inverted index) Disallow variant columns from using inverted index format v1 (#43599) #45179

merged 4 commits into from
Dec 11, 2024

Conversation

csun5285
Copy link
Contributor

@csun5285 csun5285 commented Dec 9, 2024 •
edited
Loading

pick from master #43599

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@csun5285
Copy link
Contributor Author

csun5285 commented Dec 9, 2024

run buildall

@csun5285
Copy link
Contributor Author

csun5285 commented Dec 9, 2024

run buildall

@csun5285
[fix] (inverted index) Disallow variant columns from using inverted i…
1b27acd 
…ndex format v1 (apache#43599)

Problem Summary:
1. When the inverted index of a variant column uses storage format v1,
schema changes can cause some segments to lack corresponding index
files.

2. By using storage format v2 for inverted indexes, all indexes
correspond to a single file, and the corresponding files will always
exist regardless of whether the variant includes subcolumn indexes.

When creating an inverted index for a variant column, file format v1 is
not supported
@csun5285
fix
6d44e68
@csun5285
remove unused pick
dffc628
@csun5285
Copy link
Contributor Author

csun5285 commented Dec 9, 2024

run buildall

@csun5285
Copy link
Contributor Author

csun5285 commented Dec 9, 2024

run buildall

airborne12
airborne12 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12 airborne12 merged commit ca85238 into apache:branch-2.1 Dec 11, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airborne12 airborne12 airborne12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csun5285 @doris-robot @airborne12