[opt](cloud) Make get tablet stats and update delete bitmap update lock be able to be in different fdb txns #45206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
bobhan1
force-pushed
the
fix-ms-get-delete-bitmap-lock-get-stats
branch
from
86d4945 to
0df6084
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bobhan1
force-pushed
the
fix-ms-get-delete-bitmap-lock-get-stats
branch
from
f74de71 to
54905d9
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
bobhan1
force-pushed
the
fix-ms-get-delete-bitmap-lock-get-stats
branch
2 times, most recently
from
ae7e0df to
fc8d9fe
Compare
|
run buildall |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
gavinchou
reviewed
Dec 12, 2024
gavinchou
reviewed
Dec 12, 2024
gavinchou
reviewed
Dec 12, 2024
gavinchou
reviewed
Dec 12, 2024
gavinchou
reviewed
Dec 12, 2024
bobhan1
force-pushed
the
fix-ms-get-delete-bitmap-lock-get-stats
branch
from
379f2f2 to
2097edc
Compare
github-actions
bot
removed
the
approved
… will not be cleared
|
run buildall |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
gavinchou
approved these changes
Dec 17, 2024
gavinchou
approved these changes
Dec 17, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
…ck be able to be in different fdb txns (#45206) #37670 let the meta service return the tablet compaction stats along with the `getDeleteBitmapUpdateLockResponse` to FE to let the BE know whether it should `sync_rowsets()` due to successful compaction on other BEs on the same tablet. That PR makes the process of reading tablets' stats and writing the delete bitmap update lock KV in one fdb txn to achieve the atomic sematic. However, when a load involves a large number of tablets, the process of reading tablets' stats may take longer than fdb txn's 5 seconds limitation and cause `TXN_TOO_OLD` error. This PR re-arrange the process so that the read of tablet stats can be not necessarily in the same fdb txn with the txn which update the lock_info.lock_id. In detail, we do as the following: 1. gain the delete bitmap update lock in MS (write delete bitmap update lock KV) 2. read tablets' stats to get the compaction counts. 3. check if the delete bitmap update lock is still held by the current load.
dataroaring
pushed a commit
that referenced
this pull request
Dec 26, 2024
…ap update lock be able to be in different fdb txns #45206 (#45559) Cherry-picked from #45206 Co-authored-by: bobhan1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#37670 let the meta service return the tablet compaction stats along with the
getDeleteBitmapUpdateLockResponseto FE to let the BE know whether it shouldsync_rowsets()due to successful compaction on other BEs on the same tablet. That PR makes the process of reading tablets' stats and writing the delete bitmap update lock KV in one fdb txn to achieve the atomic sematic. However, when a load involves a large number of tablets, the process of reading tablets' stats may take longer than fdb txn's 5 seconds limitation and causeTXN_TOO_OLDerror.This PR re-arrange the process so that the read of tablet stats can be not necessarily in the same fdb txn with the txn which update the lock_info.lock_id. In detail, we do as the following:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)