[improve](docker) add disable query for be restart #45208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
run buildall |
…t-safe-and-graceful
catpineapple
changed the title
|
run buildall |
| if [[ "x$NEED_PRE_START" == "xfalse" ]] ; then | ||
| break; | ||
| fi | ||
| enable_quer $svc |
There was a problem hiding this comment.
not have function name is "enable_quer" ，the function name is "enable_query"
| @@ -157,7 +181,23 @@ add_self() | |||
| memlist=`show_backends $svc` | |||
| if echo "$memlist" | grep -q -w "$MY_SELF" &>/dev/null ; then | |||
| log_stderr "[info] Check myself ($MY_SELF:$HEARTBEAT_PORT) exist in FE, start be directly ..." | |||
| break; | |||
| if [[ "x$NEED_PRE_START" == "xfalse" ]] ; then | |||
There was a problem hiding this comment.
what the NEED_PRE_START variable meaning
| @@ -146,6 +159,17 @@ collect_env_info() | |||
| fi | |||
| } | |||
|
|
|||
| check_enable(){ | |||
There was a problem hiding this comment.
check_enable, check what enable.
| res=`check_enable $memlist` | ||
| if [[ "x$res" == "xtrue" ]] ; then | ||
| break; | ||
| else |
There was a problem hiding this comment.
if already break. not need else.
| # disable query and check for stop | ||
| prepare_stop(){ | ||
| local svc=$1 | ||
| for ((i=1; i<=RETRY_TIMES; i++)) |
There was a problem hiding this comment.
It's so long, if time is spent in here, the graceful exit has enough time.
| } | ||
|
|
||
|
|
||
| disable_query(){ |
There was a problem hiding this comment.
set_disable_query_is_true
| disable_res=`check_disable $ENV_FE_ADDR` | ||
| if [[ "x$disable_res" == "xtrue" ]] ; then | ||
| break | ||
| else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
add disable query and load for be restart
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)