Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat](iceberg)Supports using rest type catalog to read tables in unity catalog for 2.1 (#43525) #45217

Merged
merged 3 commits into from
Dec 12, 2024
Merged

[feat](iceberg)Supports using rest type catalog to read tables in unity catalog for 2.1 (#43525) #45217

merged 3 commits into from
Dec 12, 2024

Conversation

wuwenchi
Copy link
Contributor

@wuwenchi wuwenchi commented Dec 10, 2024 •
edited
Loading

bp: #43525

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wuwenchi
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/vec/exec/format/parquet/schema_desc.cpp
@@ -147,6 +150,14 @@ Status FieldDescriptor::parse_from_thrift(const std::vector<tparquet::SchemaElem
return Status::OK();
}

const doris::Slice FieldDescriptor::get_column_name_from_field_id(int32_t id) const {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: return type 'const doris::Slice' is 'const'-qualified at the top level, which may reduce code readability without improving const correctness [readability-const-return-type]

Suggested change
const doris::Slice FieldDescriptor::get_column_name_from_field_id(int32_t id) const {
doris::Slice FieldDescriptor::get_column_name_from_field_id(int32_t id) const {

be/src/vec/exec/format/parquet/schema_desc.h:136:

-     const doris::Slice get_column_name_from_field_id(int32_t id) const;
+     doris::Slice get_column_name_from_field_id(int32_t id) const;

be/src/vec/exec/format/parquet/vparquet_reader.cpp
// This is for iceberg schema evolution.
std::vector<tparquet::KeyValue> ParquetReader::get_metadata_key_values() {
return _t_metadata->key_value_metadata;
const FieldDescriptor ParquetReader::get_file_metadata_schema() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: return type 'const std::doris::vectorized::FieldDescriptor' is 'const'-qualified at the top level, which may reduce code readability without improving const correctness [readability-const-return-type]

Suggested change
const FieldDescriptor ParquetReader::get_file_metadata_schema() {
FieldDescriptor ParquetReader::get_file_metadata_schema() {

be/src/vec/exec/format/parquet/vparquet_reader.h:150:

-     const FieldDescriptor get_file_metadata_schema();
+     FieldDescriptor get_file_metadata_schema();

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.51% (9566/26204)
Line Coverage: 27.95% (78620/281333)
Region Coverage: 26.61% (40353/151664)
Branch Coverage: 23.36% (20445/87504)
Coverage Report: http://coverage.selectdb-in.cc/coverage/fe7d020754eff468ff6ba296a4d680721bdfb6d7_fe7d020754eff468ff6ba296a4d680721bdfb6d7/report/index.html

@wuwenchi
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.50% (9569/26214)
Line Coverage: 27.94% (78634/281439)
Region Coverage: 26.61% (40368/151703)
Branch Coverage: 23.37% (20452/87532)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9d0765431fcd0c6cdd5f277fa4da97886b44262f_9d0765431fcd0c6cdd5f277fa4da97886b44262f/report/index.html

@wuwenchi
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.49% (9568/26223)
Line Coverage: 27.92% (78636/281638)
Region Coverage: 26.60% (40383/151819)
Branch Coverage: 23.35% (20450/87594)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3d5629b9ca90fd9b40c0ca11d6cc368ecd5f6da4_3d5629b9ca90fd9b40c0ca11d6cc368ecd5f6da4/report/index.html

@morningman morningman merged commit 667f5e6 into apache:branch-2.1 Dec 12, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wuwenchi @doris-robot @morningman