[fix](Nereids) fix fe folding constant of string functions and add more cases #45233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 40102 ms |
TPC-DS: Total hot run time: 198377 ms |
ClickBench: Total hot run time: 32.22 s |
LiBinfeng-01
force-pushed
the
add_fold_cases
branch
from
8e936a9 to
7a9d32b
Compare
|
run buildall |
TPC-H: Total hot run time: 40232 ms |
TPC-DS: Total hot run time: 195402 ms |
ClickBench: Total hot run time: 32.39 s |
|
run buildall |
TPC-H: Total hot run time: 39851 ms |
TPC-DS: Total hot run time: 196138 ms |
ClickBench: Total hot run time: 32.16 s |
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 39705 ms |
TPC-DS: Total hot run time: 196387 ms |
ClickBench: Total hot run time: 32.24 s |
|
run p0 |
morrySnow
reviewed
Dec 13, 2024
...n/java/org/apache/doris/nereids/trees/expressions/functions/executable/StringArithmetic.java
Show resolved
Hide resolved
|
run buildall |
morrySnow
reviewed
Dec 18, 2024
| return castStringLikeLiteral(first, trimImpl(first.getValue(), " ", false, true)); | ||
| } | ||
|
|
||
| /** | ||
| * Executable arithmetic functions rtrim | ||
| */ | ||
| @ExecFunction(name = "rtrim") | ||
| public static Expression rtrimVarcharVarchar(StringLikeLiteral first, StringLikeLiteral second) { | ||
| public static Expression rtrimVarchar(StringLikeLiteral first, StringLikeLiteral second) { |
There was a problem hiding this comment.
why remove signature in name? and give it a meaningless name?
There was a problem hiding this comment.
because Signature in name is included by StringLikeLiteral, we need this signature before to indicate it is VarcharLiteral or StringLiteral. But now we can use StringlikeLiteral to include them all. Keep one in function to indicate the difference between rtrim and rtrimVarchar
englefly
previously approved these changes
Dec 18, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
LiBinfeng-01
force-pushed
the
add_fold_cases
branch
from
8cff18a to
b607a04
Compare
TPC-H: Total hot run time: 32472 ms |
TPC-DS: Total hot run time: 189907 ms |
ClickBench: Total hot run time: 30.86 s |
morrySnow
reviewed
Jan 3, 2025
...ssion-test/suites/nereids_p0/expression/fold_constant/fold_constant_string_arithmatic.groovy
Show resolved
Hide resolved
|
run buildall |
TPC-H: Total hot run time: 32871 ms |
TPC-DS: Total hot run time: 196664 ms |
ClickBench: Total hot run time: 31.33 s |
morrySnow
approved these changes
Jan 6, 2025
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
run cloud_p0 |
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Jan 7, 2025
…re cases (apache#45233) Issue Number: apache#44666 Related PR: apache#40441 Problem Summary: - select substring_index('哈哈哈AAA','A', 1); String.split function has second parameter 'limit', which is default zero. When 'limit' is zero, it means it would remove trailing empty strings split of '哈哈哈AAA', which would be '哈哈哈' only. But what we expect is '哈哈哈', '','','' when part function is used by substring index. So we should change splitpart limit to -1 to enable trailing empty character in splitpart list - reorganize fold constant of string functions in fe and add more cases
Merged
16 tasks
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Jan 7, 2025
…re cases (apache#45233) Issue Number: apache#44666 Related PR: apache#40441 Problem Summary: - select substring_index('哈哈哈AAA','A', 1); String.split function has second parameter 'limit', which is default zero. When 'limit' is zero, it means it would remove trailing empty strings split of '哈哈哈AAA', which would be '哈哈哈' only. But what we expect is '哈哈哈', '','','' when part function is used by substring index. So we should change splitpart limit to -1 to enable trailing empty character in splitpart list - reorganize fold constant of string functions in fe and add more cases
Merged
16 tasks
morrySnow
pushed a commit
that referenced
this pull request
Jan 9, 2025
…re cases (#45233) (#46525) pick: #45233 Issue Number: #44666 Related PR: #40441 Problem Summary: - select substring_index('哈哈哈AAA','A', 1); String.split function has second parameter 'limit', which is default zero. When 'limit' is zero, it means it would remove trailing empty strings split of '哈哈哈AAA', which would be '哈哈哈' only. But what we expect is '哈哈哈', '','','' when part function is used by substring index. So we should change splitpart limit to -1 to enable trailing empty character in splitpart list - reorganize fold constant of string functions in fe and add more cases --------- Co-authored-by: Mryange <[email protected]>
morrySnow
pushed a commit
that referenced
this pull request
Jan 9, 2025
…s and add more cases #45233 (#46523) pick: #45233 Issue Number: #44666 Related PR: #40441 Problem Summary: - select substring_index('哈哈哈AAA','A', 1); String.split function has second parameter 'limit', which is default zero. When 'limit' is zero, it means it would remove trailing empty strings split of '哈哈哈AAA', which would be '哈哈哈' only. But what we expect is '哈哈哈', '','','' when part function is used by substring index. So we should change splitpart limit to -1 to enable trailing empty character in splitpart list - reorganize fold constant of string functions in fe and add more cases --------- Co-authored-by: Mryange <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: close #44666
Related PR: #40441
Problem Summary:
select substring_index('哈哈哈AAA','A', 1);
String.split function has second parameter 'limit', which is default zero. When 'limit' is zero, it means it would remove trailing
empty strings split of '哈哈哈AAA', which would be '哈哈哈' only. But what we expect is '哈哈哈', '','','' when part function is used by substring index.
So we should change splitpart limit to -1 to enable trailing empty character in splitpart list
reorganize fold constant of string functions in fe and add more cases
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)