Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-2.1: [Enhancement](compaction)Optimize compaction task permit allocation #45197 #45243

Merged
merged 1 commit into from
Dec 11, 2024
Merged

branch-2.1: [Enhancement](compaction)Optimize compaction task permit allocation #45197 #45243

merged 1 commit into from
Dec 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #45197

@Yukang-Lian
[Enhancement](compaction)Optimize compaction task permit allocation (#…
1601859 
…45197)

The current implementation of compaction task submission reserves
permits before task execution, which can lead to inefficient resource
utilization. Tasks waiting in the thread pool queue may hold permits,
potentially blocking other tasks from being executed.

## Solution

Change total_permits_for_compaction_score to 1,000,000, which will
effectively remove the limit on total permits. The original purpose of
total permits was to control the memory of compaction tasks, but
currently, memory is controlled by individual compaction tasks, so total
permits are no longer serving any purpose. If no memory issues arise in
the next two versions after making this change, we will remove the
permits mechanism.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Dec 10, 2024
@doris-robot
Copy link

run buildall

@github-actions GitHub Actions
Copy link
Contributor Author

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.50% (9567/26210)
Line Coverage: 27.93% (78600/281406)
Region Coverage: 26.60% (40340/151663)
Branch Coverage: 23.35% (20436/87506)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1601859babb16c5ce7addc6b508bdb239859e829_1601859babb16c5ce7addc6b508bdb239859e829/report/index.html

@yiguolei yiguolei merged commit 44fa860 into branch-2.1 Dec 11, 2024
20 of 22 checks passed
@github-actions github-actions bot deleted the auto-pick-45197-branch-2.1 branch December 11, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doris-robot @yiguolei @dataroaring @Yukang-Lian