-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](variant) add serialized sparse column #45252
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
56c6f60
to
3f31381
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
num_rows += length; | ||
finalize(); | ||
#ifndef NDEBUG | ||
check_consistency(); | ||
#endif | ||
} | ||
|
||
// std::map<std::string_view, Subcolumn> | ||
void ColumnObject::insert_from_sparse_column_and_fill_remaing_dense_column( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: method 'insert_from_sparse_column_and_fill_remaing_dense_column' can be made const [readability-make-member-function-const]
be/src/vec/columns/column_object.cpp:1156:
- size_t start, size_t length) {
+ size_t start, size_t length) const {
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow]
return; | |
} | |
} |
3f31381
to
35927e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)