Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-3.0: [fix] (inverted index) fix index file in gc binlogs #44994 #45440

Merged
merged 1 commit into from
Dec 17, 2024
Merged

branch-3.0: [fix] (inverted index) fix index file in gc binlogs #44994 #45440

merged 1 commit into from
Dec 17, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #44994

@csun5285
[fix] (inverted index) fix index file in gc binlogs (#44994)
ec146c1 
Problem Summary:
1. remove duplicate function `get_segment_index_filepath`
2. fix gc binlogs
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Dec 16, 2024
@hello-stephen
Copy link
Contributor

run buildall

airborne12
airborne12 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12 airborne12 merged commit c2b366e into branch-3.0 Dec 17, 2024
22 of 26 checks passed
@airborne12 airborne12 deleted the auto-pick-44994-branch-3.0 branch December 17, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airborne12 airborne12 airborne12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hello-stephen @airborne12 @dataroaring @csun5285