Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](cloud) fix error in get detached tablet stat #45449

Merged
merged 3 commits into from
Dec 17, 2024
Merged

[fix](cloud) fix error in get detached tablet stat #45449

merged 3 commits into from
Dec 17, 2024

Conversation

csun5285
Copy link
Contributor

What problem does this PR solve?

Related PR: #44120

Problem Summary:

  • detached tablet stats should maintain a fixed size.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 16, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@csun5285
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

cloud/test/meta_service_tablet_stats_test.cpp Show resolved Hide resolved
@csun5285
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

gavinchou
gavinchou previously approved these changes Dec 16, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@csun5285
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 16, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

airborne12
airborne12 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12 airborne12 merged commit 66c7445 into apache:master Dec 17, 2024
29 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
@csun5285
[fix](cloud) fix error in get detached tablet stat (#45449)
4dd8cf3 
### What problem does this PR solve?

Related PR: #44120

Problem Summary:

- `detached tablet stats` should maintain a fixed size.
@github-actions github-actions bot mentioned this pull request Dec 17, 2024
Merged
airborne12 pushed a commit that referenced this pull request Dec 18, 2024
@github-actions @csun5285
branch-3.0: [fix](cloud) fix error in get detached tablet stat #45449 (…
28f91da 
…#45506)

Cherry-picked from #45449

Co-authored-by: Sun Chenyang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

@gavinchou gavinchou gavinchou approved these changes

@airborne12 airborne12 airborne12 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csun5285 @Thearas @airborne12 @gavinchou @Yukang-Lian