Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [enhance](nereids) remove first_value and second_value second parameter if the second parameter is false #45264 #45453

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #45264

…er if the second parameter is false (#45264)

### What problem does this PR solve?
Problem Summary: remove first_value and second_value second parameter if the second parameter is false
@Thearas
Copy link
Contributor

Thearas commented Dec 16, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Dec 16, 2024
@Thearas
Copy link
Contributor

Thearas commented Dec 16, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40263 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9e8bbc68217418025ce0c39fb08120e99b1b8b01, data reload: false

------ Round 1 ----------------------------------
q1	17599	7369	7297	7297
q2	2060	165	163	163
q3	10718	1068	1155	1068
q4	10557	772	716	716
q5	7739	2750	2748	2748
q6	240	147	146	146
q7	954	611	605	605
q8	9594	1917	1977	1917
q9	8100	6326	6334	6326
q10	6993	2263	2287	2263
q11	456	262	261	261
q12	401	210	208	208
q13	17772	2960	2992	2960
q14	233	208	208	208
q15	546	513	520	513
q16	681	615	590	590
q17	956	572	563	563
q18	7105	6530	6426	6426
q19	3088	1029	1025	1025
q20	462	198	198	198
q21	3879	3247	3095	3095
q22	1040	977	967	967
Total cold run time: 111173 ms
Total hot run time: 40263 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7389	7142	7217	7142
q2	316	242	228	228
q3	2975	2843	2856	2843
q4	2047	1781	1703	1703
q5	5642	5647	5698	5647
q6	225	146	140	140
q7	2136	1777	1775	1775
q8	3248	3490	3365	3365
q9	8751	8849	8813	8813
q10	3552	3477	3516	3477
q11	593	492	503	492
q12	784	586	627	586
q13	16445	3141	3156	3141
q14	294	267	284	267
q15	566	527	511	511
q16	721	662	660	660
q17	1830	1637	1620	1620
q18	8162	7900	7522	7522
q19	1708	1606	1581	1581
q20	2083	1860	1803	1803
q21	5380	5353	5123	5123
q22	1121	1033	1004	1004
Total cold run time: 75968 ms
Total hot run time: 59443 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194231 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9e8bbc68217418025ce0c39fb08120e99b1b8b01, data reload: false

query1	1233	923	928	923
query2	6281	2037	1982	1982
query3	10809	4043	4052	4043
query4	65875	29330	23421	23421
query5	4968	441	445	441
query6	416	177	190	177
query7	5654	318	322	318
query8	314	242	232	232
query9	9145	2665	2667	2665
query10	485	274	247	247
query11	17547	15178	15750	15178
query12	156	97	103	97
query13	1595	461	423	423
query14	10281	7238	6500	6500
query15	202	177	178	177
query16	7221	476	507	476
query17	1028	543	545	543
query18	1946	309	309	309
query19	225	171	166	166
query20	116	107	111	107
query21	61	44	43	43
query22	4671	4417	4226	4226
query23	35224	34086	34143	34086
query24	6511	2974	2878	2878
query25	550	424	451	424
query26	715	169	168	168
query27	1871	301	307	301
query28	4189	2517	2510	2510
query29	704	466	455	455
query30	252	167	162	162
query31	1008	831	859	831
query32	69	60	60	60
query33	450	290	298	290
query34	915	514	516	514
query35	860	764	738	738
query36	1076	948	955	948
query37	116	83	79	79
query38	4014	3974	3986	3974
query39	1523	1444	1464	1444
query40	145	84	87	84
query41	49	49	46	46
query42	110	97	100	97
query43	513	475	501	475
query44	1174	810	795	795
query45	189	165	165	165
query46	1145	739	723	723
query47	1988	1904	1878	1878
query48	478	376	365	365
query49	717	376	370	370
query50	842	403	404	403
query51	7153	7222	7019	7019
query52	101	90	89	89
query53	260	187	180	180
query54	562	448	435	435
query55	75	75	76	75
query56	262	230	248	230
query57	1200	1097	1088	1088
query58	194	195	201	195
query59	3033	2844	2840	2840
query60	267	252	240	240
query61	106	106	106	106
query62	781	652	655	652
query63	209	187	188	187
query64	1407	653	617	617
query65	3265	3134	3184	3134
query66	710	305	323	305
query67	15767	15067	15189	15067
query68	4529	564	557	557
query69	438	250	250	250
query70	1151	1066	1050	1050
query71	402	250	253	250
query72	6226	3904	3970	3904
query73	769	345	338	338
query74	9897	8911	8820	8820
query75	3330	2607	2621	2607
query76	1937	966	1034	966
query77	507	250	260	250
query78	10651	9683	9566	9566
query79	7432	582	592	582
query80	1909	411	416	411
query81	539	240	237	237
query82	1717	121	113	113
query83	288	137	139	137
query84	286	84	76	76
query85	1106	301	287	287
query86	451	304	300	300
query87	4482	4213	4164	4164
query88	5419	2360	2405	2360
query89	419	297	286	286
query90	2119	181	186	181
query91	180	146	144	144
query92	66	48	49	48
query93	6385	549	547	547
query94	868	272	247	247
query95	354	252	246	246
query96	660	278	275	275
query97	3292	3131	3119	3119
query98	206	199	197	197
query99	2019	1300	1306	1300
Total cold run time: 333012 ms
Total hot run time: 194231 ms

@feiniaofeiafei
Copy link
Contributor

run p0

@zhangstar333 zhangstar333 merged commit 13ae167 into branch-3.0 Dec 16, 2024
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-45264-branch-3.0 branch December 16, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants