Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick](branch-21) fix first/last value return error with ignore null (#44996) #45486

Merged
merged 3 commits into from
Dec 17, 2024
Merged

[cherry-pick](branch-21) fix first/last value return error with ignore null (#44996) #45486

merged 3 commits into from
Dec 17, 2024

Conversation

zhangstar333
Copy link
Contributor

cherry-pick from master #44996

@zhangstar333
[bug](function) fix first/last value return error with ignore null (a…
839bcbb 
…pache#44996)

### What problem does this PR solve?

Problem Summary:
needs another prs of FE: apache#45065
apache#45264

1. the first value even if have set value, should not return directly,
need check it whether need arg_ignore_null, as maybe it's NULL

2. the last_value if need arg_ignore_null and not set value, should find
in while loop, if find could return directly, not find check iff has any
value before

### Release note

fix first_value/last_value return error with ignore null param is true
@zhangstar333
update
59e7c1f
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.47% (9568/26232)
Line Coverage: 27.91% (78619/281654)
Region Coverage: 26.59% (40378/151836)
Branch Coverage: 23.34% (20445/87594)
Coverage Report: http://coverage.selectdb-in.cc/coverage/59e7c1f4fb210b3c6d7c7253d774d5ddad3a22f1_59e7c1f4fb210b3c6d7c7253d774d5ddad3a22f1/report/index.html

@zhangstar333
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.47% (9566/26232)
Line Coverage: 27.91% (78607/281654)
Region Coverage: 26.59% (40369/151836)
Branch Coverage: 23.34% (20441/87594)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e8721c39385959b436f806ed5e6826b64652e6eb_e8721c39385959b436f806ed5e6826b64652e6eb/report/index.html

@zhangstar333 zhangstar333 merged commit c561bdb into apache:branch-2.1 Dec 17, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangstar333 @hello-stephen @doris-robot