Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Opt](SegmentIterator) clear and release iterators memory footprint in advance when EOF (#44768) #45734

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

eldenmoon
Copy link
Member

(#44768)

…n advance when EOF (apache#44768)

Otherwise the memory will hold until BetaRowsetReader released
@Thearas
Copy link
Contributor

Thearas commented Dec 20, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon
Copy link
Member Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.46% (9570/26245)
Line Coverage: 27.93% (78678/281716)
Region Coverage: 26.59% (40375/151835)
Branch Coverage: 23.34% (20446/87586)
Coverage Report: http://coverage.selectdb-in.cc/coverage/21a41e1c36b1db5483a4e94458b25dbb32a15a07_21a41e1c36b1db5483a4e94458b25dbb32a15a07/report/index.html

@yiguolei yiguolei merged commit 06efd5b into apache:branch-2.1 Dec 20, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants