Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](build) Fix format specifier causing compilation errors on MacOS #45755

Closed
wants to merge 1 commit into from

Conversation

zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Dec 21, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zy-kkk
Copy link
Member Author

zy-kkk commented Dec 21, 2024

run buildall

@zy-kkk
Copy link
Member Author

zy-kkk commented Dec 23, 2024

run buildall

@zy-kkk
Copy link
Member Author

zy-kkk commented Dec 23, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39726 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c0daaafcb4216f9307eaf75b5de25cd8c020fb88, data reload: false

------ Round 1 ----------------------------------
q1	17580	7430	7232	7232
q2	2049	173	165	165
q3	10689	1076	1171	1076
q4	10577	781	748	748
q5	7632	2687	2666	2666
q6	259	152	145	145
q7	966	622	594	594
q8	9246	1866	1875	1866
q9	6575	6353	6452	6353
q10	6990	2295	2266	2266
q11	469	261	257	257
q12	435	225	224	224
q13	17778	2973	2947	2947
q14	247	217	213	213
q15	551	507	502	502
q16	657	580	597	580
q17	985	565	468	468
q18	7193	6711	6780	6711
q19	1343	1012	1120	1012
q20	481	187	180	180
q21	4105	3250	3215	3215
q22	379	317	306	306
Total cold run time: 107186 ms
Total hot run time: 39726 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7209	7238	7246	7238
q2	326	227	229	227
q3	2936	2799	2958	2799
q4	2088	1802	1838	1802
q5	5686	5647	5641	5641
q6	229	143	144	143
q7	2259	1902	1809	1809
q8	3381	3537	3472	3472
q9	8787	8957	8883	8883
q10	3588	3560	3530	3530
q11	601	508	531	508
q12	787	601	630	601
q13	13152	3098	3075	3075
q14	301	268	287	268
q15	563	500	500	500
q16	685	646	645	645
q17	1854	1600	1599	1599
q18	8340	7729	7569	7569
q19	1725	1550	1626	1550
q20	2110	1869	1853	1853
q21	5589	5463	5481	5463
q22	640	575	568	568
Total cold run time: 72836 ms
Total hot run time: 59743 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.89% (10132/26056)
Line Coverage: 29.82% (85298/286039)
Region Coverage: 28.93% (43529/150483)
Branch Coverage: 25.45% (22185/87164)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c0daaafcb4216f9307eaf75b5de25cd8c020fb88_c0daaafcb4216f9307eaf75b5de25cd8c020fb88/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 195985 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c0daaafcb4216f9307eaf75b5de25cd8c020fb88, data reload: false

query1	1325	972	936	936
query2	6261	2383	2402	2383
query3	11006	4745	4521	4521
query4	33533	23488	23203	23203
query5	5151	477	456	456
query6	289	193	169	169
query7	3992	300	301	300
query8	292	226	225	225
query9	9299	2766	2755	2755
query10	508	239	246	239
query11	18086	15000	15103	15000
query12	167	104	103	103
query13	1607	429	429	429
query14	9366	7277	7062	7062
query15	272	184	186	184
query16	8121	453	469	453
query17	1531	623	633	623
query18	2121	305	309	305
query19	329	157	167	157
query20	125	109	120	109
query21	208	112	110	110
query22	4830	4729	4465	4465
query23	34747	33846	33933	33846
query24	10566	2497	2504	2497
query25	610	418	413	413
query26	1179	155	186	155
query27	2396	345	328	328
query28	7611	2518	2498	2498
query29	817	405	415	405
query30	231	150	146	146
query31	1040	816	830	816
query32	91	57	56	56
query33	772	285	296	285
query34	1128	541	522	522
query35	927	761	776	761
query36	1111	967	970	967
query37	145	75	80	75
query38	4529	4235	4178	4178
query39	1535	1470	1449	1449
query40	228	116	108	108
query41	49	48	47	47
query42	122	111	105	105
query43	552	505	513	505
query44	1345	842	846	842
query45	199	177	172	172
query46	1205	741	730	730
query47	2035	1986	1938	1938
query48	433	342	342	342
query49	972	452	374	374
query50	822	393	417	393
query51	7309	7155	6994	6994
query52	113	97	95	95
query53	272	193	188	188
query54	1150	413	422	413
query55	83	75	81	75
query56	268	260	240	240
query57	1313	1161	1140	1140
query58	235	229	222	222
query59	3452	3130	3276	3130
query60	264	245	238	238
query61	107	106	101	101
query62	911	664	647	647
query63	211	193	187	187
query64	3979	663	696	663
query65	3215	3182	3182	3182
query66	756	294	309	294
query67	16008	15603	15518	15518
query68	5496	575	534	534
query69	475	248	249	248
query70	1246	1123	1153	1123
query71	474	256	249	249
query72	7022	4101	4046	4046
query73	796	362	370	362
query74	10118	8777	8763	8763
query75	3610	2642	2678	2642
query76	3696	1169	1060	1060
query77	561	274	287	274
query78	10210	9537	9351	9351
query79	2308	611	611	611
query80	950	429	427	427
query81	561	234	225	225
query82	1208	117	118	117
query83	280	148	143	143
query84	248	73	70	70
query85	1591	297	295	295
query86	472	314	298	298
query87	4466	4319	4390	4319
query88	3616	2262	2233	2233
query89	449	290	291	290
query90	2038	194	186	186
query91	137	109	105	105
query92	71	51	52	51
query93	2494	548	553	548
query94	877	291	282	282
query95	356	256	240	240
query96	629	292	283	283
query97	2862	2719	2666	2666
query98	265	199	187	187
query99	1566	1290	1316	1290
Total cold run time: 306610 ms
Total hot run time: 195985 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.33 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c0daaafcb4216f9307eaf75b5de25cd8c020fb88, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.03	0.03
query3	0.24	0.07	0.07
query4	1.61	0.11	0.10
query5	0.43	0.40	0.43
query6	1.14	0.65	0.65
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.57	0.52	0.52
query10	0.55	0.58	0.55
query11	0.15	0.11	0.10
query12	0.13	0.11	0.11
query13	0.61	0.61	0.59
query14	2.72	2.75	2.76
query15	0.91	0.83	0.83
query16	0.40	0.39	0.38
query17	1.05	1.01	1.06
query18	0.22	0.20	0.20
query19	1.87	1.87	2.00
query20	0.02	0.01	0.01
query21	15.36	0.62	0.60
query22	2.52	2.03	1.70
query23	17.12	0.97	0.79
query24	2.67	0.94	0.80
query25	0.18	0.29	0.06
query26	0.40	0.13	0.14
query27	0.05	0.04	0.04
query28	11.37	1.09	1.07
query29	12.65	3.26	3.24
query30	0.25	0.06	0.06
query31	2.87	0.39	0.39
query32	3.25	0.47	0.47
query33	3.03	3.05	3.22
query34	17.15	4.48	4.46
query35	4.49	4.49	4.45
query36	0.67	0.49	0.48
query37	0.10	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 107.33 s
Total hot run time: 32.33 s

@zy-kkk
Copy link
Member Author

zy-kkk commented Dec 24, 2024

fixed by #40202

@zy-kkk zy-kkk closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants