-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve](move-memtable) reduce memory usage by sharing flush tokens #45813
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 40024 ms
|
TPC-DS: Total hot run time: 189851 ms
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 31.63 s
|
@@ -79,6 +79,7 @@ class TabletStream { | |||
RuntimeProfile::Counter* _add_segment_timer = nullptr; | |||
RuntimeProfile::Counter* _close_wait_timer = nullptr; | |||
LoadStreamMgr* _load_stream_mgr = nullptr; | |||
std::shared_ptr<FlushTokens> _flush_tokens; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to use one flush token for one tablet.
What problem does this PR solve?
Fix OOM due to too many flush tokens being created.
Share downstream flush tokens by index.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)