Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](row store) forbit short circuit row store cache temporaryly #45842

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

[fix](row store) forbit short circuit row store cache temporaryly #45842

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f06df46
[fix](row store) forbit short circuit row store cache temporaryly
eldenmoon Dec 24, 2024
e6c03d0
Merge branch 'master' into cloud-rs-cache
eldenmoon Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions be/src/service/point_query_executor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ Status PointQueryExecutor::_lookup_row_key() {
std::vector<std::unique_ptr<SegmentCacheHandle>> segment_caches(specified_rowsets.size());
for (size_t i = 0; i < _row_read_ctxs.size(); ++i) {
RowLocation location;
if (!config::disable_storage_row_cache) {
if (!config::disable_storage_row_cache && !config::is_cloud_mode()) {
RowCache::CacheHandle cache_handle;
auto hit_cache = RowCache::instance()->lookup(
{_tablet->tablet_id(), _row_read_ctxs[i]._primary_key}, &cache_handle);
Expand Down Expand Up @@ -448,7 +448,7 @@ Status PointQueryExecutor::_lookup_row_data() {
std::string value;
// fill block by row store
if (_reusable->rs_column_uid() != -1) {
bool use_row_cache = !config::disable_storage_row_cache;
bool use_row_cache = !config::disable_storage_row_cache && !config::is_cloud_mode();
RETURN_IF_ERROR(_tablet->lookup_row_data(
_row_read_ctxs[i]._primary_key, _row_read_ctxs[i]._row_location.value(),
*(_row_read_ctxs[i]._rowset_ptr), _reusable->tuple_desc(),
Expand Down
Loading