Fix threadpool blocked when create thread failed in init() #46366

wangbo · 2025-01-03T07:19:02Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
Threadpool's _num_threads_pending_start field means a thread is created successfully, but has not begin executing, it increments when create thread succ, and then decrements when the thread begin runs.
Currently init and set_min/max_threads method create threads and increment _num_threads_pending_start, but not decrement it if some threads create failed.
This means _num_threads_pending_start can not be zero even all threads finish, then calling threadpool.shutdown could be blocked.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-01-03T07:19:26Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

be/src/util/threadpool.cpp

wangbo · 2025-01-03T08:18:19Z

run buildall

wangbo · 2025-01-03T09:29:46Z

run buildall

doris-robot · 2025-01-03T10:51:14Z

TPC-H: Total hot run time: 32534 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 177a52f6a778e96ea003ba62e3939af1c9e2453e, data reload: false

------ Round 1 ----------------------------------
q1	17526	6175	6037	6037
q2	2042	326	177	177
q3	10375	1344	749	749
q4	10215	878	452	452
q5	7531	2198	1966	1966
q6	209	184	143	143
q7	902	751	602	602
q8	9241	1363	1125	1125
q9	5305	4870	4896	4870
q10	6755	2324	1856	1856
q11	475	283	254	254
q12	350	367	230	230
q13	17760	3609	3011	3011
q14	239	250	222	222
q15	557	511	488	488
q16	650	618	591	591
q17	590	857	324	324
q18	7201	6486	6415	6415
q19	2901	988	569	569
q20	309	314	186	186
q21	2837	2199	1950	1950
q22	365	334	317	317
Total cold run time: 104335 ms
Total hot run time: 32534 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6431	6281	6263	6263
q2	251	329	239	239
q3	2276	2647	2319	2319
q4	1395	1818	1355	1355
q5	4346	4765	4657	4657
q6	183	177	139	139
q7	1938	1853	1668	1668
q8	2555	2699	2640	2640
q9	6896	6930	6846	6846
q10	2950	3230	2709	2709
q11	580	512	488	488
q12	641	756	583	583
q13	3312	3701	3091	3091
q14	275	305	268	268
q15	561	515	492	492
q16	654	692	628	628
q17	1201	1694	1237	1237
q18	7381	6979	7098	6979
q19	823	1099	1081	1081
q20	1909	1953	1849	1849
q21	5364	5074	4902	4902
q22	603	615	577	577
Total cold run time: 52525 ms
Total hot run time: 51010 ms

doris-robot · 2025-01-03T11:03:18Z

TPC-DS: Total hot run time: 189849 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 177a52f6a778e96ea003ba62e3939af1c9e2453e, data reload: false

query1	956	367	375	367
query2	6526	2255	2286	2255
query3	6708	218	211	211
query4	34234	23554	23446	23446
query5	4381	632	459	459
query6	291	208	185	185
query7	4627	509	303	303
query8	307	241	260	241
query9	9358	2683	2673	2673
query10	476	312	263	263
query11	18174	15593	15205	15205
query12	171	111	106	106
query13	1678	545	407	407
query14	12168	6717	7351	6717
query15	238	189	192	189
query16	7903	649	473	473
query17	1593	746	577	577
query18	2060	411	315	315
query19	259	176	149	149
query20	117	113	110	110
query21	207	128	102	102
query22	4227	4450	4251	4251
query23	35463	33218	34179	33218
query24	6158	2235	2254	2235
query25	442	436	377	377
query26	1066	252	153	153
query27	2008	466	348	348
query28	5254	2412	2405	2405
query29	530	514	418	418
query30	230	181	153	153
query31	1004	948	816	816
query32	72	63	59	59
query33	497	358	285	285
query34	745	840	516	516
query35	804	840	735	735
query36	1017	1057	961	961
query37	117	100	71	71
query38	4104	4141	4090	4090
query39	1505	1436	1429	1429
query40	202	113	99	99
query41	48	43	46	43
query42	116	102	103	102
query43	538	517	490	490
query44	1287	813	811	811
query45	181	173	162	162
query46	876	1052	642	642
query47	1909	1926	1881	1881
query48	372	404	318	318
query49	772	481	396	396
query50	645	657	400	400
query51	7257	7189	7006	7006
query52	102	104	93	93
query53	224	256	193	193
query54	492	493	406	406
query55	82	81	81	81
query56	247	272	235	235
query57	1170	1148	1132	1132
query58	232	227	254	227
query59	3053	3049	2890	2890
query60	284	261	253	253
query61	109	109	114	109
query62	910	849	746	746
query63	234	197	194	194
query64	4000	990	667	667
query65	3301	3196	3193	3193
query66	1024	428	314	314
query67	16028	15793	15648	15648
query68	7612	697	515	515
query69	459	288	246	246
query70	1250	1110	1145	1110
query71	445	297	249	249
query72	6422	3827	3848	3827
query73	659	762	359	359
query74	10277	9327	8925	8925
query75	4142	3121	2655	2655
query76	3760	1192	781	781
query77	765	359	273	273
query78	10060	10331	9416	9416
query79	3586	804	590	590
query80	743	515	508	508
query81	476	268	227	227
query82	562	151	119	119
query83	195	164	154	154
query84	277	87	71	71
query85	791	373	299	299
query86	359	317	305	305
query87	4534	4674	4552	4552
query88	4518	2163	2182	2163
query89	407	333	309	309
query90	1892	187	188	187
query91	137	134	104	104
query92	70	54	49	49
query93	1565	854	540	540
query94	670	388	276	276
query95	335	260	246	246
query96	483	601	282	282
query97	2902	2977	2879	2879
query98	224	207	201	201
query99	1667	1569	1428	1428
Total cold run time: 295614 ms
Total hot run time: 189849 ms

doris-robot · 2025-01-03T11:08:40Z

ClickBench: Total hot run time: 31.93 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 177a52f6a778e96ea003ba62e3939af1c9e2453e, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.03
query3	0.24	0.06	0.07
query4	1.60	0.10	0.10
query5	0.42	0.42	0.41
query6	1.15	0.64	0.65
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.50	0.50
query10	0.53	0.57	0.55
query11	0.15	0.12	0.10
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	2.83	2.73	2.75
query15	0.89	0.82	0.82
query16	0.39	0.37	0.38
query17	1.07	1.03	1.07
query18	0.23	0.23	0.20
query19	1.90	1.86	2.02
query20	0.01	0.01	0.00
query21	15.39	0.94	0.57
query22	0.76	0.76	0.61
query23	15.36	1.43	0.52
query24	2.93	1.72	1.85
query25	0.20	0.17	0.06
query26	0.22	0.15	0.13
query27	0.07	0.05	0.06
query28	14.93	1.48	1.05
query29	12.60	4.00	3.32
query30	0.25	0.09	0.06
query31	2.85	0.61	0.39
query32	3.23	0.53	0.46
query33	3.13	3.09	3.13
query34	16.65	5.14	4.50
query35	4.45	4.46	4.51
query36	0.80	0.47	0.50
query37	0.10	0.06	0.05
query38	0.04	0.03	0.04
query39	0.04	0.02	0.02
query40	0.17	0.12	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 107.24 s
Total hot run time: 31.93 s

doris-robot · 2025-01-03T11:29:48Z

TeamCity be ut coverage result:
Function Coverage: 38.88% (10128/26049)
Line Coverage: 29.92% (85694/286384)
Region Coverage: 29.01% (43709/150659)
Branch Coverage: 25.55% (22310/87304)
Coverage Report: http://coverage.selectdb-in.cc/coverage/177a52f6a778e96ea003ba62e3939af1c9e2453e_177a52f6a778e96ea003ba62e3939af1c9e2453e/report/index.html

wangbo · 2025-01-06T03:42:51Z

run buildall

doris-robot · 2025-01-06T05:07:58Z

TPC-H: Total hot run time: 32784 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 63188723e758728d5a6d1b6f7c524a500b981152, data reload: false

------ Round 1 ----------------------------------
q1	17598	6156	6047	6047
q2	2060	312	166	166
q3	10408	1249	763	763
q4	10207	879	441	441
q5	7511	2243	2000	2000
q6	211	183	144	144
q7	907	763	606	606
q8	9253	1392	1214	1214
q9	5308	4999	4983	4983
q10	6781	2344	1881	1881
q11	475	274	254	254
q12	354	366	220	220
q13	17784	3640	3040	3040
q14	241	241	212	212
q15	569	508	497	497
q16	636	604	595	595
q17	587	856	344	344
q18	7117	6369	6393	6369
q19	1611	989	563	563
q20	310	316	181	181
q21	3005	2224	1967	1967
q22	371	337	297	297
Total cold run time: 103304 ms
Total hot run time: 32784 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6283	6213	6241	6213
q2	240	330	233	233
q3	2242	2686	2345	2345
q4	1418	1836	1420	1420
q5	4359	4783	4841	4783
q6	192	176	143	143
q7	2067	2039	1842	1842
q8	2671	2846	2716	2716
q9	7357	7239	7321	7239
q10	3097	3381	2873	2873
q11	578	516	494	494
q12	652	745	576	576
q13	3554	3862	3256	3256
q14	285	319	299	299
q15	570	524	528	524
q16	667	696	643	643
q17	1220	1744	1258	1258
q18	7883	7558	7419	7419
q19	849	1095	1159	1095
q20	2015	2008	1872	1872
q21	5745	5287	4947	4947
q22	605	638	582	582
Total cold run time: 54549 ms
Total hot run time: 52772 ms

doris-robot · 2025-01-06T05:20:16Z

TPC-DS: Total hot run time: 197363 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 63188723e758728d5a6d1b6f7c524a500b981152, data reload: false

query1	1314	941	924	924
query2	6259	2410	2352	2352
query3	11136	4878	4778	4778
query4	33097	23891	23514	23514
query5	3688	619	477	477
query6	271	203	191	191
query7	4002	500	304	304
query8	317	237	230	230
query9	9238	2622	2617	2617
query10	473	315	246	246
query11	17939	15500	15201	15201
query12	162	103	109	103
query13	1579	541	415	415
query14	10034	7296	8138	7296
query15	252	205	218	205
query16	8449	644	493	493
query17	1615	805	612	612
query18	2007	412	337	337
query19	227	188	178	178
query20	127	117	118	117
query21	211	130	109	109
query22	4556	4783	4636	4636
query23	35077	33527	33415	33415
query24	6564	2325	2345	2325
query25	482	463	391	391
query26	801	285	161	161
query27	2007	469	336	336
query28	5497	2481	2437	2437
query29	651	548	412	412
query30	212	187	161	161
query31	998	919	824	824
query32	78	57	57	57
query33	481	341	305	305
query34	776	889	517	517
query35	818	829	742	742
query36	1012	1074	984	984
query37	115	103	78	78
query38	4440	4272	4306	4272
query39	1514	1465	1470	1465
query40	205	116	100	100
query41	44	43	46	43
query42	144	101	100	100
query43	520	521	489	489
query44	1319	818	839	818
query45	184	178	173	173
query46	880	1046	655	655
query47	2021	1980	1949	1949
query48	390	419	329	329
query49	740	491	401	401
query50	646	662	398	398
query51	7273	7227	7273	7227
query52	106	119	95	95
query53	228	265	184	184
query54	488	484	419	419
query55	84	78	81	78
query56	266	268	261	261
query57	1266	1220	1179	1179
query58	237	239	233	233
query59	3321	3308	3183	3183
query60	280	290	244	244
query61	114	112	106	106
query62	851	844	758	758
query63	238	195	192	192
query64	3106	1015	704	704
query65	3302	3280	3241	3241
query66	819	406	315	315
query67	16444	15878	15435	15435
query68	8479	710	520	520
query69	490	293	250	250
query70	1167	1165	1088	1088
query71	425	285	253	253
query72	6264	3720	3826	3720
query73	675	749	354	354
query74	10136	9152	9104	9104
query75	4167	3186	2714	2714
query76	3734	1165	767	767
query77	753	372	281	281
query78	11291	10101	9509	9509
query79	3368	768	576	576
query80	721	539	410	410
query81	479	279	229	229
query82	459	156	121	121
query83	184	156	145	145
query84	285	93	71	71
query85	748	356	314	314
query86	362	316	307	307
query87	4457	4447	4515	4447
query88	2992	2198	2178	2178
query89	418	317	294	294
query90	1917	184	183	183
query91	134	146	107	107
query92	73	55	52	52
query93	1009	705	538	538
query94	661	381	296	296
query95	330	319	250	250
query96	471	620	290	290
query97	2929	3002	2839	2839
query98	226	201	197	197
query99	1657	1568	1433	1433
Total cold run time: 295453 ms
Total hot run time: 197363 ms

doris-robot · 2025-01-06T05:22:06Z

TeamCity be ut coverage result:
Function Coverage: 38.89% (10130/26049)
Line Coverage: 29.92% (85693/286400)
Region Coverage: 29.02% (43728/150668)
Branch Coverage: 25.56% (22316/87314)
Coverage Report: http://coverage.selectdb-in.cc/coverage/63188723e758728d5a6d1b6f7c524a500b981152_63188723e758728d5a6d1b6f7c524a500b981152/report/index.html

doris-robot · 2025-01-06T05:25:36Z

ClickBench: Total hot run time: 31.1 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 63188723e758728d5a6d1b6f7c524a500b981152, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.03	0.03
query3	0.23	0.07	0.06
query4	1.63	0.11	0.11
query5	0.41	0.42	0.39
query6	1.14	0.65	0.65
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.50	0.52
query10	0.56	0.55	0.55
query11	0.15	0.11	0.11
query12	0.14	0.11	0.10
query13	0.61	0.61	0.60
query14	2.75	2.76	2.75
query15	0.90	0.82	0.82
query16	0.39	0.38	0.38
query17	0.96	1.01	1.07
query18	0.24	0.22	0.21
query19	1.80	1.88	1.94
query20	0.02	0.01	0.02
query21	15.36	0.96	0.55
query22	0.75	0.83	0.67
query23	15.23	1.39	0.58
query24	2.85	0.71	1.78
query25	0.17	0.20	0.05
query26	0.31	0.15	0.14
query27	0.08	0.06	0.05
query28	13.82	1.52	1.04
query29	12.53	3.98	3.30
query30	0.25	0.09	0.07
query31	2.83	0.57	0.38
query32	3.23	0.54	0.46
query33	3.06	3.07	3.03
query34	16.90	5.18	4.57
query35	4.66	4.50	4.52
query36	0.82	0.47	0.47
query37	0.09	0.06	0.05
query38	0.04	0.04	0.03
query39	0.04	0.02	0.03
query40	0.17	0.14	0.13
query41	0.07	0.02	0.02
query42	0.03	0.02	0.03
query43	0.04	0.02	0.03
Total cold run time: 106.01 s
Total hot run time: 31.1 s

yiguolei · 2025-01-06T09:19:35Z

be/src/util/threadpool.cpp

@@ -273,19 +273,32 @@ ThreadPool::~ThreadPool() {
    shutdown();
 }

+Status ThreadPool::try_create_thread(int thread_num) {


参数里加一个lock

wangbo · 2025-01-06T12:19:32Z

run buildall

wangbo · 2025-01-06T12:20:51Z

run buildall

github-actions · 2025-01-06T13:09:46Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-01-06T13:09:48Z

PR approved by anyone and no changes requested.

doris-robot · 2025-01-06T13:29:40Z

TPC-H: Total hot run time: 32747 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1b6a4ec7dbfc1f7e009029b8902610886da8d280, data reload: false

------ Round 1 ----------------------------------
q1	17612	6467	6037	6037
q2	2052	299	165	165
q3	10426	1307	714	714
q4	10214	902	445	445
q5	7497	2282	2011	2011
q6	204	181	149	149
q7	914	742	625	625
q8	9260	1398	1184	1184
q9	5342	5050	5070	5050
q10	6750	2332	1856	1856
q11	469	289	252	252
q12	337	367	219	219
q13	17746	3762	3086	3086
q14	223	234	210	210
q15	565	519	514	514
q16	620	630	591	591
q17	563	868	333	333
q18	7134	6547	6254	6254
q19	1962	968	573	573
q20	313	315	191	191
q21	3042	2175	1971	1971
q22	367	335	317	317
Total cold run time: 103612 ms
Total hot run time: 32747 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6363	6194	6233	6194
q2	244	333	230	230
q3	2248	2600	2312	2312
q4	1448	1873	1322	1322
q5	4485	4820	4959	4820
q6	186	184	152	152
q7	2109	1984	1796	1796
q8	2629	3098	2709	2709
q9	7361	7245	7265	7245
q10	3044	3315	2780	2780
q11	598	509	514	509
q12	692	747	609	609
q13	3459	3841	3261	3261
q14	272	314	264	264
q15	579	509	516	509
q16	654	692	660	660
q17	1204	1742	1258	1258
q18	7732	7523	7004	7004
q19	822	1090	1069	1069
q20	1905	1976	1821	1821
q21	5498	5106	4829	4829
q22	605	639	566	566
Total cold run time: 54137 ms
Total hot run time: 51919 ms

doris-robot · 2025-01-06T13:41:44Z

TPC-DS: Total hot run time: 190610 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1b6a4ec7dbfc1f7e009029b8902610886da8d280, data reload: false

query1	987	394	362	362
query2	6519	2372	2335	2335
query3	6706	214	218	214
query4	33843	23631	23415	23415
query5	4373	618	454	454
query6	294	190	191	190
query7	4622	501	307	307
query8	300	237	222	222
query9	9585	2678	2690	2678
query10	478	328	253	253
query11	18011	15531	15081	15081
query12	161	107	107	107
query13	1678	540	405	405
query14	10758	7680	7037	7037
query15	245	208	196	196
query16	8316	656	447	447
query17	1638	767	588	588
query18	2140	402	329	329
query19	226	180	165	165
query20	120	124	114	114
query21	219	123	108	108
query22	4410	4386	4237	4237
query23	34376	33594	33114	33114
query24	6794	2275	2234	2234
query25	503	447	385	385
query26	810	270	159	159
query27	2072	460	330	330
query28	5337	2435	2418	2418
query29	673	571	419	419
query30	231	184	147	147
query31	974	901	808	808
query32	94	63	61	61
query33	499	357	307	307
query34	732	819	515	515
query35	798	815	763	763
query36	1004	1027	955	955
query37	125	97	78	78
query38	4290	4141	4130	4130
query39	1503	1454	1437	1437
query40	198	116	98	98
query41	53	45	47	45
query42	113	102	103	102
query43	540	528	488	488
query44	1276	803	809	803
query45	180	182	167	167
query46	862	1038	652	652
query47	1913	1930	1854	1854
query48	372	400	321	321
query49	721	488	403	403
query50	638	638	396	396
query51	7136	7016	7124	7016
query52	102	102	92	92
query53	223	254	185	185
query54	485	484	402	402
query55	84	79	79	79
query56	245	252	239	239
query57	1243	1172	1133	1133
query58	235	227	229	227
query59	3080	3268	3208	3208
query60	303	268	256	256
query61	115	114	109	109
query62	877	787	739	739
query63	225	192	191	191
query64	3727	992	650	650
query65	3294	3209	3214	3209
query66	857	416	320	320
query67	15933	15843	15498	15498
query68	8026	713	513	513
query69	535	293	267	267
query70	1175	1176	1139	1139
query71	434	293	271	271
query72	6413	3858	4016	3858
query73	660	736	355	355
query74	10264	9426	9287	9287
query75	3965	3174	2679	2679
query76	3615	1193	785	785
query77	769	354	277	277
query78	10231	10259	9530	9530
query79	2967	846	596	596
query80	689	519	444	444
query81	487	278	238	238
query82	657	152	114	114
query83	169	169	148	148
query84	244	91	80	80
query85	755	366	305	305
query86	413	328	296	296
query87	4388	4428	4357	4357
query88	4647	2189	2190	2189
query89	416	334	300	300
query90	1835	190	193	190
query91	138	147	105	105
query92	69	57	53	53
query93	1723	852	527	527
query94	659	388	273	273
query95	330	266	253	253
query96	525	611	286	286
query97	2932	2981	2873	2873
query98	220	201	202	201
query99	1658	1561	1435	1435
Total cold run time: 293482 ms
Total hot run time: 190610 ms

doris-robot · 2025-01-06T13:47:05Z

ClickBench: Total hot run time: 30.8 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1b6a4ec7dbfc1f7e009029b8902610886da8d280, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.23	0.07	0.07
query4	1.61	0.10	0.11
query5	0.42	0.39	0.40
query6	1.18	0.65	0.65
query7	0.02	0.01	0.01
query8	0.04	0.03	0.04
query9	0.58	0.52	0.51
query10	0.54	0.57	0.54
query11	0.14	0.11	0.11
query12	0.14	0.11	0.11
query13	0.60	0.61	0.60
query14	2.82	2.72	2.81
query15	0.90	0.82	0.80
query16	0.38	0.39	0.37
query17	1.05	1.06	1.05
query18	0.22	0.21	0.20
query19	1.94	2.04	1.80
query20	0.01	0.01	0.01
query21	15.36	0.94	0.58
query22	0.74	0.86	0.80
query23	15.14	1.47	0.55
query24	2.88	0.47	1.04
query25	0.12	0.14	0.09
query26	0.41	0.15	0.13
query27	0.04	0.05	0.04
query28	13.62	1.59	1.05
query29	12.59	3.98	3.21
query30	0.25	0.09	0.06
query31	2.83	0.57	0.38
query32	3.24	0.54	0.47
query33	3.11	3.18	3.10
query34	16.65	5.15	4.47
query35	4.50	4.48	4.47
query36	0.65	0.49	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.04	0.03	0.03
query40	0.18	0.14	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 105.55 s
Total hot run time: 30.8 s

doris-robot · 2025-01-06T14:03:23Z

TeamCity be ut coverage result:
Function Coverage: 38.89% (10130/26049)
Line Coverage: 29.93% (85716/286391)
Region Coverage: 29.02% (43725/150661)
Branch Coverage: 25.56% (22319/87306)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1b6a4ec7dbfc1f7e009029b8902610886da8d280_1b6a4ec7dbfc1f7e009029b8902610886da8d280/report/index.html

xinyiZzz

LGTM

)

yiguolei added p0_b dev/2.1.x dev/3.0.x labels Jan 3, 2025

yiguolei reviewed Jan 3, 2025

View reviewed changes

be/src/util/threadpool.cpp Outdated Show resolved Hide resolved

wangbo force-pushed the 0103_fix_tpool_hang branch 2 times, most recently from 50674ee to afc37a7 Compare January 3, 2025 08:01

Fix threadpool hang when create thread failed in init()

177a52f

wangbo force-pushed the 0103_fix_tpool_hang branch from afc37a7 to 177a52f Compare January 3, 2025 09:29

wangbo changed the title ~~Fix threadpool hang when create thread failed in init()~~ Fix threadpool blocked when create thread failed in init() Jan 3, 2025

fix pool dcheck failed

6318872

yiguolei reviewed Jan 6, 2025

View reviewed changes

add args

1b6a4ec

wangbo force-pushed the 0103_fix_tpool_hang branch from 2e05d6b to 1b6a4ec Compare January 6, 2025 12:20

yiguolei approved these changes Jan 6, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 6, 2025

github-actions bot added the reviewed label Jan 6, 2025

xinyiZzz approved these changes Jan 7, 2025

View reviewed changes

wangbo merged commit 5725d52 into apache:master Jan 7, 2025
23 of 26 checks passed

github-actions bot pushed a commit that referenced this pull request Jan 7, 2025

Fix threadpool blocked when create thread failed in init() (#46366)

1b2c650

github-actions bot mentioned this pull request Jan 7, 2025

branch-3.0: Fix threadpool blocked when create thread failed in init() #46366 #46512

Closed

github-actions bot added the dev/2.1.x-conflict label Jan 7, 2025

yiguolei removed dev/2.1.x dev/2.1.x-conflict p0_b dev/3.0.x labels Jan 13, 2025

wangbo added a commit to wangbo/incubator-doris that referenced this pull request Jan 20, 2025

Fix threadpool blocked when create thread failed in init() (apache#46366

ff7de30

)

wangbo mentioned this pull request Jan 20, 2025

[branch-2.1]Fix threadpool blocked when create thread failed in init() (#46366) #47236

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix threadpool blocked when create thread failed in init() #46366

Fix threadpool blocked when create thread failed in init() #46366

wangbo commented Jan 3, 2025 •

edited

Loading

hello-stephen commented Jan 3, 2025

wangbo commented Jan 3, 2025

wangbo commented Jan 3, 2025

doris-robot commented Jan 3, 2025

doris-robot commented Jan 3, 2025

doris-robot commented Jan 3, 2025

doris-robot commented Jan 3, 2025

wangbo commented Jan 6, 2025

doris-robot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

yiguolei Jan 6, 2025

wangbo commented Jan 6, 2025

wangbo commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

xinyiZzz left a comment

Fix threadpool blocked when create thread failed in init() #46366

Fix threadpool blocked when create thread failed in init() #46366

Conversation

wangbo commented Jan 3, 2025 • edited Loading

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

hello-stephen commented Jan 3, 2025

wangbo commented Jan 3, 2025

wangbo commented Jan 3, 2025

doris-robot commented Jan 3, 2025

doris-robot commented Jan 3, 2025

doris-robot commented Jan 3, 2025

doris-robot commented Jan 3, 2025

wangbo commented Jan 6, 2025

doris-robot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

yiguolei Jan 6, 2025

Choose a reason for hiding this comment

wangbo commented Jan 6, 2025

wangbo commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

xinyiZzz left a comment

Choose a reason for hiding this comment

wangbo commented Jan 3, 2025 •

edited

Loading