Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](regression) Fix unstable regression test test_alter_table_property and test_compaction_score_action #46394

Merged
merged 1 commit into from
Jan 5, 2025
Merged

[opt](regression) Fix unstable regression test test_alter_table_property and test_compaction_score_action #46394

merged 1 commit into from
Jan 5, 2025

Conversation

gavinchou
Copy link
Contributor

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou
Copy link
Contributor Author

run buildall

@gavinchou gavinchou force-pushed the gavin-fix-compaction-score-topn branch from 2a79dcb to f1df204 Compare January 3, 2025 17:24
@gavinchou
Copy link
Contributor Author

run buildall

dataroaring
dataroaring previously approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

PR approved by anyone and no changes requested.

@gavinchou
[opt](regression) Fix unstable regression test test_alter_table_prope…
662981d 
…rty and test_compaction_score_action

* Enlarge regression test timeout to 100 sec for test_compaction_score_action
* Fix test_alter_table_property for local mode
@gavinchou gavinchou force-pushed the gavin-fix-compaction-score-topn branch from f1df204 to 662981d Compare January 5, 2025 03:40
@gavinchou gavinchou changed the title [opt](regression) Enlarge timeout to 100 sec to fix unstable test_compaction_score_action regression test [opt](regression) Fix unstable regression test test_alter_table_property and test_compaction_score_action Jan 5, 2025
@gavinchou
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 5, 2025
@gavinchou
Copy link
Contributor Author

run p0

@gavinchou
Copy link
Contributor Author

run cloud_p0

dataroaring
dataroaring approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 5, 2025
@gavinchou gavinchou merged commit 26d68d7 into apache:master Jan 5, 2025
26 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 5, 2025
@gavinchou
[opt](regression) Fix unstable regression test test_alter_table_prope…
c0a6d97 
…rty and test_compaction_score_action (#46394)

* Enlarge regression test timeout to 100 sec for test_compaction_score_action 
* Fix test_alter_table_property for local mode
@github-actions github-actions bot mentioned this pull request Jan 5, 2025
Merged
yiguolei pushed a commit that referenced this pull request Jan 6, 2025
@github-actions @gavinchou
branch-3.0: [opt](regression) Fix unstable regression test test_alter…
262e185 
…_table_property and test_compaction_score_action #46394 (#46426)

Cherry-picked from #46394

Co-authored-by: Gavin Chou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@luwei16 luwei16 luwei16 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gavinchou @hello-stephen @luwei16 @dataroaring @yiguolei