[fix](mem) heap-buffer-overflow for function convert_to #46405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
TeamCity be ut coverage result: |
be/src/clucene
Outdated
There was a problem hiding this comment.
Seems that this file should not be updated in this PR.
cambyzju
force-pushed
the
fix-master-0103
branch
from
d940ac5 to
c22c243
Compare
|
run buildall |
TPC-H: Total hot run time: 32346 ms |
TPC-DS: Total hot run time: 190695 ms |
ClickBench: Total hot run time: 31.47 s |
|
TeamCity be ut coverage result: |
zhangstar333
reviewed
Jan 6, 2025
zhangstar333
approved these changes
Jan 6, 2025
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
yiguolei
approved these changes
Jan 6, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
### What problem does this PR solve?
Reproduce SQL with ASAN version:
`select convert('装装装装装' using gbk);`
Then be crashed:
```
=================================================================
==1830466==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x606002aeec20 at pc 0x560826fb3e66 bp 0x7fc3816a5890 sp 0x7fc3816a5058
WRITE of size 10 at 0x606002aeec20 thread T711 (brpc_light)
```
But if we use release version, we found the result is not correct, and
the memory maybe already corrupted:
```
> select convert('装装装装装' using gbk);
+---------------------------------------------------------+
| convert_to('装装装装装', 'gbk') |
+---------------------------------------------------------+
| ~zhuangdang~zhuangdang~zhuangdang~zhuangdang~zhu |
+---------------------------------------------------------+
1 row in set (0.04 sec)
```
The correct answer should be:
```
> select convert('装装装装装' using gbk);
+--------------------------------------+
| convert_to('装装装装装', 'gbk') |
+--------------------------------------+
| ~zhuang~zhuang~zhuang~zhuang~zhuang |
+--------------------------------------+
1 row in set (0.06 sec)
```
cambyzju
added a commit
to cambyzju/incubator-doris
that referenced
this pull request
Jan 7, 2025
Reproduce SQL with ASAN version:
`select convert('装装装装装' using gbk);`
Then be crashed:
```
=================================================================
==1830466==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x606002aeec20 at pc 0x560826fb3e66 bp 0x7fc3816a5890 sp 0x7fc3816a5058
WRITE of size 10 at 0x606002aeec20 thread T711 (brpc_light)
```
But if we use release version, we found the result is not correct, and
the memory maybe already corrupted:
```
> select convert('装装装装装' using gbk);
+---------------------------------------------------------+
| convert_to('装装装装装', 'gbk') |
+---------------------------------------------------------+
| ~zhuangdang~zhuangdang~zhuangdang~zhuangdang~zhu |
+---------------------------------------------------------+
1 row in set (0.04 sec)
```
The correct answer should be:
```
> select convert('装装装装装' using gbk);
+--------------------------------------+
| convert_to('装装装装装', 'gbk') |
+--------------------------------------+
| ~zhuang~zhuang~zhuang~zhuang~zhuang |
+--------------------------------------+
1 row in set (0.06 sec)
```
yiguolei
pushed a commit
that referenced
this pull request
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Reproduce SQL with ASAN version:
select convert('装装装装装' using gbk);Then be crashed:
But if we use release version, we found the result is not correct, and the memory maybe already corrupted:
The correct answer should be:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)