-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor][profile] log enhancement and minor change of profile #46564
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
run compile |
TPC-H: Total hot run time: 32839 ms
|
TPC-DS: Total hot run time: 192277 ms
|
ClickBench: Total hot run time: 31.19 s
|
TeamCity be ut coverage result: |
run p0 10 |
run p0 |
2 similar comments
run p0 |
run p0 |
968b793
to
01ed312
Compare
01ed312
to
a85f630
Compare
run buildall |
TeamCity be ut coverage result: |
fcab7bd
to
f6500eb
Compare
run buildall |
TPC-H: Total hot run time: 32316 ms
|
TPC-DS: Total hot run time: 187155 ms
|
ClickBench: Total hot run time: 30.98 s
|
TeamCity be ut coverage result: |
f6500eb
to
6f8f0f0
Compare
TeamCity be ut coverage result: |
run buildall |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 32811 ms
|
TPC-DS: Total hot run time: 194411 ms
|
ClickBench: Total hot run time: 31.22 s
|
run buildall |
TPC-H: Total hot run time: 32556 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 195478 ms
|
ClickBench: Total hot run time: 31.21 s
|
} catch (Exception e) { | ||
LOG.warn("Failed to submit profile write task, query {} be {}", | ||
DebugUtil.printId(profile.query_id), address.toString()); | ||
return new Status(TStatusCode.INTERNAL_ERROR, "Failed to submit profile write task"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果这里返回失败,会不会BE 收到这个错误,导致查询失败?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果这里返回失败,会不会BE 收到这个错误,导致查询失败?
不会,referenct
// actually be does not care the process status of profile on fe. |
@@ -65,6 +65,8 @@ static Status _do_report_exec_stats_rpc(const TNetworkAddress& coor_addr, | |||
return Status::RpcError("Client rpc client failed"); | |||
} | |||
|
|||
VLOG_DEBUG << fmt::format("Sending profile"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not need format
run buildall |
TPC-H: Total hot run time: 32500 ms
|
TPC-DS: Total hot run time: 195456 ms
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 31.29 s
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)