Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-3.0: [Fix](schema change) Fix NPE when rename column on table which has sequence type column #46906 #46935

Merged
merged 1 commit into from
Jan 15, 2025
Merged

branch-3.0: [Fix](schema change) Fix NPE when rename column on table which has sequence type column #46906 #46935

merged 1 commit into from
Jan 15, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #46906

@bobhan1
[Fix](schema change) Fix NPE when rename column on table which has se…
67ed50b 
…quence type column (#46906)

### What problem does this PR solve?
Problem Summary:
```mysql
CREATE TABLE `tbl` (
  `c` tinyint NULL,
) ENGINE=OLAP
UNIQUE KEY(`c`)
DISTRIBUTED BY HASH(`c`) BUCKETS 10
PROPERTIES (
  "function_column.sequence_type" = "bigint"
);

mysql> alter table tbl rename column c c_bk;                                                         
ERROR 1105 (HY000): errCode = 2, detailMessage = Cannot invoke "String.equalsIgnoreCase(String)" because the return value of "org.apache.doris.catalog.OlapTable.getSequenceMapCol()" is null
```
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jan 14, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41132 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 67ed50bd3c64d1b17699a959c4ed4f4dccd88215, data reload: false

------ Round 1 ----------------------------------
q1	17622	8324	7269	7269
q2	2072	181	179	179
q3	10532	1123	1131	1123
q4	10567	829	736	736
q5	7788	2895	2852	2852
q6	236	148	148	148
q7	980	620	606	606
q8	9375	2031	1992	1992
q9	6631	6436	6454	6436
q10	7029	2301	2309	2301
q11	464	275	272	272
q12	403	212	209	209
q13	17809	3023	2996	2996
q14	252	207	211	207
q15	565	523	533	523
q16	718	618	629	618
q17	993	560	571	560
q18	7397	6784	6655	6655
q19	1407	1044	1143	1044
q20	486	218	208	208
q21	4045	3244	3212	3212
q22	1107	1055	986	986
Total cold run time: 108478 ms
Total hot run time: 41132 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7326	7265	7327	7265
q2	333	234	240	234
q3	3066	2939	2993	2939
q4	2100	1819	1805	1805
q5	5768	5823	5798	5798
q6	224	146	147	146
q7	2247	1843	1813	1813
q8	3410	3547	3426	3426
q9	8967	8960	8842	8842
q10	3597	3563	3590	3563
q11	656	496	488	488
q12	798	634	618	618
q13	9468	3177	3193	3177
q14	315	270	269	269
q15	587	530	517	517
q16	710	689	687	687
q17	1861	1634	1622	1622
q18	8362	7601	7570	7570
q19	1688	1633	1632	1632
q20	2139	1865	1889	1865
q21	5667	5484	5308	5308
q22	1148	1071	1085	1071
Total cold run time: 70437 ms
Total hot run time: 60655 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 199737 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 67ed50bd3c64d1b17699a959c4ed4f4dccd88215, data reload: false

query1	1327	942	914	914
query2	6245	2137	2079	2079
query3	10938	4426	4180	4180
query4	66484	28856	23551	23551
query5	5095	484	488	484
query6	437	204	188	188
query7	5613	319	325	319
query8	329	244	243	243
query9	8977	2705	2691	2691
query10	448	267	262	262
query11	17504	15200	15780	15200
query12	164	103	98	98
query13	1503	448	435	435
query14	10931	8212	7894	7894
query15	206	190	182	182
query16	6943	540	526	526
query17	1067	585	590	585
query18	1743	319	324	319
query19	229	151	152	151
query20	118	108	104	104
query21	224	106	103	103
query22	4785	4483	4550	4483
query23	34951	34205	34996	34205
query24	6272	3049	3060	3049
query25	546	462	431	431
query26	671	180	178	178
query27	1826	363	358	358
query28	4396	2515	2454	2454
query29	731	487	489	487
query30	243	183	178	178
query31	1019	861	841	841
query32	68	62	59	59
query33	482	325	297	297
query34	935	536	548	536
query35	879	759	757	757
query36	1127	973	971	971
query37	125	76	80	76
query38	4071	4091	4042	4042
query39	1539	1489	1494	1489
query40	216	104	103	103
query41	49	49	48	48
query42	117	110	110	110
query43	559	528	517	517
query44	1207	840	816	816
query45	192	175	177	175
query46	1158	784	771	771
query47	2013	1909	1939	1909
query48	480	401	397	397
query49	726	406	398	398
query50	837	443	429	429
query51	7436	7212	7206	7206
query52	104	90	89	89
query53	267	194	187	187
query54	575	460	465	460
query55	82	78	77	77
query56	277	247	257	247
query57	1220	1118	1106	1106
query58	217	206	218	206
query59	3256	3242	3184	3184
query60	281	256	251	251
query61	109	105	107	105
query62	778	674	674	674
query63	227	199	194	194
query64	1388	712	643	643
query65	3263	3232	3191	3191
query66	732	300	324	300
query67	16036	15579	15943	15579
query68	3748	617	591	591
query69	447	278	290	278
query70	1176	1130	1154	1130
query71	364	263	273	263
query72	6258	4151	4113	4113
query73	779	363	362	362
query74	10055	9059	8999	8999
query75	3394	2656	2675	2656
query76	1921	1071	1137	1071
query77	495	306	310	306
query78	10494	9568	9599	9568
query79	1669	623	609	609
query80	1163	461	455	455
query81	531	248	243	243
query82	255	118	122	118
query83	211	149	159	149
query84	297	100	87	87
query85	1058	304	292	292
query86	390	310	304	304
query87	4563	4385	4319	4319
query88	4053	2429	2376	2376
query89	423	298	293	293
query90	1965	188	191	188
query91	191	151	151	151
query92	68	50	51	50
query93	2423	553	578	553
query94	849	310	268	268
query95	367	263	266	263
query96	639	287	292	287
query97	3279	3170	3149	3149
query98	217	206	195	195
query99	1581	1280	1349	1280
Total cold run time: 320316 ms
Total hot run time: 199737 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.17 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 67ed50bd3c64d1b17699a959c4ed4f4dccd88215, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.62	0.10	0.10
query5	0.54	0.49	0.53
query6	1.14	0.74	0.73
query7	0.02	0.01	0.02
query8	0.04	0.05	0.03
query9	0.56	0.51	0.50
query10	0.56	0.54	0.57
query11	0.15	0.10	0.11
query12	0.15	0.11	0.11
query13	0.61	0.59	0.60
query14	2.98	2.94	3.05
query15	0.90	0.84	0.82
query16	0.37	0.39	0.37
query17	1.05	1.03	1.06
query18	0.24	0.23	0.22
query19	1.98	1.93	1.92
query20	0.02	0.01	0.01
query21	15.35	0.62	0.63
query22	2.32	2.03	2.42
query23	16.78	1.03	0.83
query24	2.70	0.98	0.67
query25	0.18	0.09	0.16
query26	0.44	0.15	0.15
query27	0.04	0.04	0.04
query28	11.23	1.11	1.07
query29	12.57	3.28	3.30
query30	0.25	0.05	0.05
query31	2.88	0.40	0.38
query32	3.23	0.46	0.47
query33	2.98	2.99	3.07
query34	17.14	4.61	4.53
query35	4.60	4.56	4.56
query36	0.67	0.49	0.49
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.03
query40	0.17	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.1 s
Total hot run time: 33.17 s

@bobhan1
Copy link
Contributor

bobhan1 commented Jan 14, 2025

run p0

@dataroaring dataroaring merged commit 626c8c5 into branch-3.0 Jan 15, 2025
22 checks passed
@github-actions github-actions bot deleted the auto-pick-46906-branch-3.0 branch January 15, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

@CalvinKirs CalvinKirs Awaiting requested review from CalvinKirs

@morningman morningman Awaiting requested review from morningman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hello-stephen @doris-robot @bobhan1 @dataroaring