BrokerServiceModule.

apache · Oct 16, 2024 · 23d73de · 23d73de
1 parent 8a0d660
commit 23d73de
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/services/src/main/java/org/apache/druid/cli/CliOverlord.java b/services/src/main/java/org/apache/druid/cli/CliOverlord.java
@@ -133,7 +133,7 @@
 import org.apache.druid.server.security.AuthenticationUtils;
 import org.apache.druid.server.security.Authenticator;
 import org.apache.druid.server.security.AuthenticatorMapper;
-import org.apache.druid.sql.guice.SqlServiceModule;
+import org.apache.druid.sql.guice.BrokerServiceModule;
 import org.apache.druid.tasklogs.TaskLogStreamer;
 import org.apache.druid.tasklogs.TaskLogs;
 import org.eclipse.jetty.rewrite.handler.RewriteHandler;
@@ -462,7 +462,7 @@ private void configureOverlordHelpers(Binder binder)
         new SupervisorModule(),
         new LookupSerdeModule(),
         new SamplerModule(),
-        new SqlServiceModule()
+        new BrokerServiceModule()
     );
   }
 

diff --git a/...che/druid/sql/guice/SqlServiceModule.java → .../druid/sql/guice/BrokerServiceModule.java b/...che/druid/sql/guice/SqlServiceModule.java → .../druid/sql/guice/BrokerServiceModule.java
@@ -36,19 +36,23 @@
 import org.apache.druid.sql.client.BrokerClient;
 import org.apache.druid.sql.client.BrokerClientImpl;
 
-public class SqlServiceModule extends ServiceClientModule
+/**
+ * This is an extension of {@link ServiceClientModule} because of module dependencies.
+ * The {@link BrokerClientImpl} requires classes present in the sql module.
+ */
+public class BrokerServiceModule extends ServiceClientModule
 {
   @Provides
   @ManageLifecycle
   @Broker
-  public ServiceLocator makeSqlBrokerServiceLocator(final DruidNodeDiscoveryProvider discoveryProvider)
+  public ServiceLocator makeBrokerServiceLocator(final DruidNodeDiscoveryProvider discoveryProvider)
   {
     return new DiscoveryServiceLocator(discoveryProvider, NodeRole.BROKER);
   }
 
   @Provides
   @LazySingleton
-  public BrokerClient makeSqlBrokerClient(
+  public BrokerClient makeBrokerClient(
       @Json final ObjectMapper jsonMapper,
       @EscalatedGlobal final ServiceClientFactory clientFactory,
       @Broker final ServiceLocator serviceLocator