fix greatest/least function non-vectorized processing to ignore null …

…argument types (#16649)
apache · Jun 26, 2024 · d4f2636 · d4f2636
1 parent ab76d85
commit d4f2636
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/processing/src/main/java/org/apache/druid/math/expr/Function.java b/processing/src/main/java/org/apache/druid/math/expr/Function.java
@@ -622,11 +622,10 @@ public ExprEval apply(List<Expr> args, Expr.ObjectBinding bindings)
         ExprEval<?> exprEval = expr.eval(bindings);
         ExpressionType exprType = exprEval.type();
 
-        if (isValidType(exprType)) {
-          outputType = ExpressionTypeConversion.function(outputType, exprType);
-        }
-
         if (exprEval.value() != null) {
+          if (isValidType(exprType)) {
+            outputType = ExpressionTypeConversion.function(outputType, exprType);
+          }
           evals.add(exprEval);
         }
       }

diff --git a/processing/src/test/java/org/apache/druid/math/expr/FunctionTest.java b/processing/src/test/java/org/apache/druid/math/expr/FunctionTest.java
@@ -677,6 +677,7 @@ public void testGreatest()
     assertExpr("greatest()", null);
     assertExpr("greatest(null, null)", null);
     assertExpr("greatest(1, null, 'A')", "A");
+    assertExpr("greatest(1.0, 1, null)", 1.0);
   }
 
   @Test
@@ -703,6 +704,7 @@ public void testLeast()
     assertExpr("least()", null);
     assertExpr("least(null, null)", null);
     assertExpr("least(1, null, 'A')", "1");
+    assertExpr("least(1.0, 1, null)", 1.0);
   }
 
   @Test

diff --git a/sql/src/test/java/org/apache/druid/sql/calcite/expression/GreatestExpressionTest.java b/sql/src/test/java/org/apache/druid/sql/calcite/expression/GreatestExpressionTest.java
@@ -214,7 +214,7 @@ public void testDecimal()
   }
 
   @Test
-  public void testDecimalWithNullShouldReturnString()
+  public void testDecimalWithNullShouldNotReturnString()
   {
     testExpression(
         Arrays.asList(
@@ -227,7 +227,7 @@ public void testDecimalWithNullShouldReturnString()
             null,
             3.4
         ),
-        "3.4"
+        3.4
     );
   }
   @Test

diff --git a/sql/src/test/java/org/apache/druid/sql/calcite/expression/LeastExpressionTest.java b/sql/src/test/java/org/apache/druid/sql/calcite/expression/LeastExpressionTest.java
@@ -214,7 +214,7 @@ public void testDecimal()
   }
 
   @Test
-  public void testDecimalWithNullShouldReturnString()
+  public void testDecimalWithNullShouldNotReturnString()
   {
     testExpression(
         Arrays.asList(
@@ -227,7 +227,7 @@ public void testDecimalWithNullShouldReturnString()
             3.4,
             null
         ),
-        "1.2"
+        1.2
     );
   }