Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc for dynamic parameters supporting array #16660

Merged
merged 15 commits into from
Aug 7, 2024
Merged

Update doc for dynamic parameters supporting array #16660

merged 15 commits into from
Aug 7, 2024

Conversation

sreemanamala
Copy link
Contributor

@sreemanamala sreemanamala commented Jun 26, 2024 •
edited
Loading

Description

Update dynamic parameter docs to provide how it can used to replace an Array

Key changed/added classes in this PR
  • sql.md
  • sql-api.md
  • sql-jdbc.md

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

abhishekrb19
abhishekrb19 reviewed Jun 26, 2024
View reviewed changes
docs/querying/sql.md Outdated Show resolved Hide resolved
docs/querying/sql.md Outdated Show resolved Hide resolved
docs/querying/sql.md Outdated Show resolved Hide resolved
kfaraz
kfaraz reviewed Jun 27, 2024
View reviewed changes
docs/querying/sql.md Outdated Show resolved Hide resolved
asdf2014
asdf2014 reviewed Jul 8, 2024
View reviewed changes
docs/querying/sql.md Outdated Show resolved Hide resolved
docs/querying/sql.md Outdated Show resolved Hide resolved
kgyrtkirk
kgyrtkirk reviewed Jul 11, 2024
View reviewed changes
docs/querying/sql.md Outdated Show resolved Hide resolved
docs/querying/sql.md Show resolved Hide resolved
@sreemanamala sreemanamala deleted the dyn-param-doc branch August 6, 2024 08:19
@sreemanamala sreemanamala restored the dyn-param-doc branch August 6, 2024 08:20
@sreemanamala sreemanamala reopened this Aug 6, 2024
kgyrtkirk
kgyrtkirk approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@kgyrtkirk kgyrtkirk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
pending checks; seems like there is some spelling issue

@abhishekagarwal87 abhishekagarwal87 merged commit 1f6d2c4 into apache:master Aug 7, 2024
8 checks passed
@sreemanamala sreemanamala deleted the dyn-param-doc branch August 7, 2024 09:24
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishekagarwal87 abhishekagarwal87 abhishekagarwal87 left review comments

@asdf2014 asdf2014 asdf2014 left review comments

@abhishekrb19 abhishekrb19 abhishekrb19 left review comments

@kfaraz kfaraz kfaraz left review comments

@kgyrtkirk kgyrtkirk kgyrtkirk approved these changes

Assignees
No one assigned
Labels
Area - Batch Ingestion Area - Dependencies Area - Documentation Area - Ingestion Area - Metrics/Event Emitting Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Area - Querying Area - Segment Format and Ser/De Area - Streaming Ingestion Area - Web Console GHA Kubernetes
Projects
None yet
Milestone
31.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sreemanamala @abhishekagarwal87 @kgyrtkirk @asdf2014 @abhishekrb19 @kfaraz