fix vector grouping expression deferred evaluation to only consider dictionary encoded strings as fixed width #16666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ictionary encoded strings as fixed width
gianm
approved these changes
Jun 27, 2024
| @@ -71,7 +71,7 @@ public boolean useDeferredGroupBySelector( | |||
| return false; | |||
| } | |||
|
|
|||
| if (!capabilities.isNumeric() && !capabilities.isDictionaryEncoded().isTrue()) { | |||
| if (!capabilities.isNumeric() && !DeferExpressionDimensions.isDictionaryEncodedScalarString(capabilities)) { | |||
There was a problem hiding this comment.
I don't see why DeferExpressionDimensions. is needed?
There was a problem hiding this comment.
oh i guess it isn't, for some reason intellij did that for code-completion so i just went with it, will fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #16338, modifies the logic to only consider
STRINGtype columns as dictionary encoded instead of anything withColumnCapabilities.isDictionaryEncodedset to true. This was a problem because currentlyVectorColumnSelectorFactorycan only make dictionary encoded selectors forSTRINGtyped columns, so any other type that is non-numeric but dictionary encoded cannot currently take advantage of this functionality.