Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web console: eslint@9, stylelint@16 #17365

Merged
merged 8 commits into from
Oct 17, 2024

Conversation

jgoz
Copy link
Contributor

@jgoz jgoz commented Oct 16, 2024

Description

Uses the latest lint tools & configuration from @awesome-code-style (ESLint 9, Stylelint 16). Also switches to the new JSX transform that was introduced with React 17.

Notable changes:

  • import React from 'react' no longer required due to new transform
  • Unnecessary fragments (<> </> blocks with one child) are automatically stripped away by ESLint
  • JSX conditionals that could theoretically print 0 instead of nothing are converted to boolean expressions

I tried to follow the principle of "break the least number of things" and suppressed lint messages that would have otherwise introduced a logic change.

Release note

  • Internal dependency updates in the web console project

This PR has:

  • been self-reviewed.
  • a release note entry in the PR description.
  • added or updated version, license, or notice information in licenses.yaml

Copy link
Contributor

@vogievetsky vogievetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making it a little less out of date!

@vogievetsky vogievetsky merged commit dceff89 into apache:master Oct 17, 2024
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants