Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: visual test support compare with a PR id #20676

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Jan 10, 2025

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Supports using PRs on GitHub in visual tests.

Fixed issues

Details

Before: What was the problem?

We can use only a released version or nightly build to do visual tests.

After: How does it behave after the fixing?

image

We can input a PR id on GitHub to do the visual test and the artifact of PR preview of dist/echarts.js will be used. This is helpful because I want to compare the changes of a v6 feature and want to compare with v6 branch.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Jan 10, 2025

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Copy link
Contributor

github-actions bot commented Jan 10, 2025

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20676@271f9db

@Ovilia Ovilia changed the title test: visual test support compare with a remote branch test: visual test support compare with a PR id Jan 14, 2025
@plainheart plainheart merged commit 1d4895f into master Jan 16, 2025
2 checks passed
@plainheart plainheart deleted the chore/visualTest branch January 16, 2025 06:42
Copy link

echarts-bot bot commented Jan 16, 2025

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants