-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-33557] Externalize Cassandra Python connector code #26
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
@pvary @gaborgsomogyi JAR included, CI run passed. |
|
||
os.makedirs(LIB_PATH) | ||
connector_jar = \ | ||
glob.glob(CURRENT_DIR + '/target/test-dependencies/flink-connector-cassandra*.jar')[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ: Is this an uber jar for the connector?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it includes the necessary cassandra related deps:
<artifactId>maven-shade-plugin</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The packaging part looks good.
I have limited experience with the Cassandra connector, so I would like to have someone with Cassandra experience to review it too.
@echauchot Sorry to ping you out of the blue, I saw that you were an active contributor to the Cassandra connector. If you have some time, would you mind reviewing this PR? Thanks in advance! |
Hi @ferenc-csaky it would be with pleasure but I know nothing about python so I might not be the good person to review this PR |
fdab870
to
05fc150
Compare
Purpose of the change
Inspired by apache/flink-connector-kafka#69, and apache/flink-connector-aws#121. Moves
cassandra.py
andtest_cassandra.py
from the core https://github.com/apache/flink repo to this one.When running
mvn clean install
, downloads the testing infra scripts from the main Flink repo:flink-python/dev/build-wheels.sh
flink-python/dev/install_command.sh
flink-python/dev/lint-python.sh
Verifying this change
The python tests can be run by the following commands: