-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix][docs] Fix Apache Avro Specification Link. #25769
Conversation
Please add [hotfix] at the start of the title as per the process when there is no associated Jira. |
562cb43
to
378f7bf
Compare
@davidradl I made the changes, could you review it again? |
@@ -218,4 +218,4 @@ So the following table lists the type mapping from Flink type to Avro type. | |||
|
|||
In addition to the types listed above, Flink supports reading/writing nullable types. Flink maps nullable types to Avro `union(something, null)`, where `something` is the Avro type converted from Flink type. | |||
|
|||
You can refer to [Avro Specification](https://avro.apache.org/docs/current/spec.html) for more information about Avro types. | |||
You can refer to [Avro Specification](https://avro.apache.org/docs/++version++/specification/) for more information about Avro types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - I notice that there is. reference in parquet.md as well to the spec for 1.10. should we align that link here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I changed all values from version "1.10.0" to "++version++".
can you also change it at Line 169 in 72b32fc
|
|
run
as mentioned at https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=64325&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb&l=12927 (the reason of failure) |
@flinkbot run azure |
Reviewed by Chi on 12/12/24 Approve - looking for committer to merge |
使用 JSON 定义 Avro schemas。你可以从 [Avro specification](https://avro.apache.org/docs/1.10.0/spec.html) 获取更多关于 Avro schemas 和类型的信息。 | ||
此示例使用了一个在 [official Avro tutorial](https://avro.apache.org/docs/1.10.0/gettingstartedjava.html) 中描述的示例相似的 Avro schema: | ||
使用 JSON 定义 Avro schemas。你可以从 [Avro specification](https://avro.apache.org/docs/++version++/spec.html) 获取更多关于 Avro schemas 和类型的信息。 | ||
此示例使用了一个在 [official Avro tutorial](https://avro.apache.org/docs/++version++/gettingstartedjava.html) 中描述的示例相似的 Avro schema: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link seems broken
Flink is using Avro 1.11.4. Wouldn't it make more sense to link to the docs of that version, then add a note to the pom file where the avro version is defined to make sure folks update the docs when updating the avro version in the pom file? Also, I believe our docs system supports variables -- it would be much easier to have one variable defining the avro version, instead of having this spread all over the place. |
Apparently most of the avro documentation has broken links above 1.13.0. Could you give me a reference on how to use variables to set the url in the documentation? |
@flinkbot run azure |
@rmetzger @donPain I had a quick look at the docs, it seems that Hugo does allow templating which supports variables. I can see the Flink code referencing the predefined variables with {{ }}. I see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this.
Let's intro the variable in a separate JIRA / PR.
@donPain could you raise a PR forward-porting the commit to the |
Sure, here it is: #25850 |
Just correcting the url reference to access the Avro specification.