Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36957][Datastream] Implement asyc state version of stream flatmap #25848

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fredia
Copy link
Contributor

@fredia fredia commented Dec 24, 2024

What is the purpose of the change

This PR implements the asyc state version of stream flatmap.

Brief change log

  • Introduce StreamFlatMapAsync
  • Update the behavior of KeyedStream#flatmap

Verifying this change

This change can be verified as follows:

  • KeyedStateInputFormatTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 24, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@davidradl
Copy link
Contributor

davidradl commented Jan 9, 2025

@fredia I am unsure what this change is for - please could you add the motivation of the fix in the Jira and the impact on the Datastream API. Does this require a docs change?

@fredia fredia changed the title [FLINK-36957][Datastream] Implement asyc stream flatmap [FLINK-36957][Datastream] Implement asyc state version of stream flatmap Jan 10, 2025
@fredia
Copy link
Contributor Author

fredia commented Jan 10, 2025

@fredia I am unsure what this change it - please could you add the motivation of the fix in the Jira and the impact on the Datastream API. Does this require a docs change?

@davidradl Sorry for the confusion, this pr provides the async state version of stream flatmap, I changed the title and description.

@davidradl
Copy link
Contributor

davidradl commented Jan 10, 2025

Reviewed by Chi on 09/01/2025 Need a committer to review

Thanks @fredia it looks ok from a quick glance - but would like someone more expert to review this

Copy link
Contributor

@Zakelly Zakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, overall looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants