[GOBBLIN-1844] Ignore workflows marked for deletion when calculating container count #3709

homatthew · 2023-06-21T19:40:31Z

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-1844] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1844

Description

Here are some details about my PR, including screenshots (if applicable):
When the GobblinClusterManager starts, it will do an asynchronous deletion of workflows (all workflow deletions are technically async). And we do not want the yarn service to acknowledge these workflows while the controller processes the request asynchronously.

When there is heavy load on the zookeeper cluster, the deletes will be slow and there will be significant overlap of having 2 of the same workflows

Tests

My PR adds the following unit tests OR does not need testing for this extremely good reason:

Modified existing unit to cover edge case of workflows that marked for deletion. Also refactored the testing code to improve the readability since there is a ton of copy paste involved for creating a workflow which is difficult to read

Commits

My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

…container count

homatthew · 2023-06-21T19:43:24Z

gobblin-yarn/src/test/java/org/apache/gobblin/yarn/YarnAutoScalingManagerTest.java

   */
  @Test
-  public void testNotInProgress() throws IOException {
+  public void testNotInProgressOrBeingDeleted()  {


This is the test that covers the related impl changes. The changes in the other test methods are all refactors

gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnAutoScalingManager.java

ZihanLi58

LGTM overall, just a minor comment

ZihanLi58

+1, thanks for addressing the comments

codecov-commenter · 2023-06-23T17:26:20Z

Codecov Report

Merging #3709 (33674da) into master (fc508ca) will decrease coverage by 0.05%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #3709      +/-   ##
============================================
- Coverage     46.87%   46.82%   -0.05%     
- Complexity    10771    10801      +30     
============================================
  Files          2138     2141       +3     
  Lines         84139    84431     +292     
  Branches       9357     9385      +28     
============================================
+ Hits          39436    39539     +103     
- Misses        41102    41290     +188     
- Partials       3601     3602       +1

Impacted Files	Coverage Δ
...rg/apache/gobblin/yarn/YarnAutoScalingManager.java	`57.24% <75.00%> (+0.62%)`	⬆️

... and 43 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

* upstream/master: Fix bug with total count watermark whitelist (apache#3724) [GOBBLIN-1858] Fix logs relating to multi-active lease arbiter (apache#3720) [GOBBLIN-1838] Introduce total count based completion watermark (apache#3701) Correct num of failures (apache#3722) [GOBBLIN- 1856] Add flow trigger handler leasing metrics (apache#3717) [GOBBLIN-1857] Add override flag to force generate a job execution id based on gobbl… (apache#3719) [GOBBLIN-1855] Metadata writer tests do not work in isolation after upgrading to Iceberg 1.2.0 (apache#3718) Remove unused ORC writer code (apache#3710) [GOBBLIN-1853] Reduce # of Hive calls during schema related updates (apache#3716) [GOBBLIN-1851] Unit tests for MysqlMultiActiveLeaseArbiter with Single Participant (apache#3715) [GOBBLIN-1848] Add tags to dagmanager metrics for extensibility (apache#3712) [GOBBLIN-1849] Add Flow Group & Name to Job Config for Job Scheduler (apache#3713) [GOBBLIN-1841] Move disabling of current live instances to the GobblinClusterManager startup (apache#3708) [GOBBLIN-1840] Helix Job scheduler should not try to replace running workflow if within configured time (apache#3704) [GOBBLIN-1847] Exceptions in the JobLauncher should try to delete the existing workflow if it is launched (apache#3711) [GOBBLIN-1842] Add timers to GobblinMCEWriter (apache#3703) [GOBBLIN-1844] Ignore workflows marked for deletion when calculating container count (apache#3709) [GOBBLIN-1846] Validate Multi-active Scheduler with Logs (apache#3707) [GOBBLIN-1845] Changes parallelstream to stream in DatasetsFinderFilteringDecorator to avoid classloader issues in spark (apache#3706) [GOBBLIN-1843] Utility for detecting non optional unions should convert dataset urn to hive compatible format (apache#3705) [GOBBLIN-1837] Implement multi-active, non blocking for leader host (apache#3700) [GOBBLIN-1835]Upgrade Iceberg Version from 0.11.1 to 1.2.0 (apache#3697) Update CHANGELOG to reflect changes in 0.17.0 Reserving 0.18.0 version for next release [GOBBLIN-1836] Ensuring Task Reliability: Handling Job Cancellation and Graceful Exits for Error-Free Completion (apache#3699) [GOBBLIN-1805] Check watermark for the most recent hour for quiet topics (apache#3698) [GOBBLIN-1825]Hive retention job should fail if deleting underlying files fail (apache#3687) [GOBBLIN-1823] Improving Container Calculation and Allocation Methodology (apache#3692) [GOBBLIN-1830] Improving Container Transition Tracking in Streaming Data Ingestion (apache#3693) [GOBBLIN-1833]Emit Completeness watermark information in snapshotCommitEvent (apache#3696)

[GOBBLIN-1844] Ignore workflows marked for deletion when calculating …

23baa94

…container count

homatthew force-pushed the mh-ignore-deleted-workflows-GOBBLIN-1844 branch from 718af52 to 23baa94 Compare June 21, 2023 19:42

homatthew commented Jun 21, 2023

View reviewed changes

homatthew changed the title ~~[GOBBLIN-1844] Ignore workflows marked for deletion when calculating …~~ [GOBBLIN-1844] Ignore workflows marked for deletion when calculating container count Jun 21, 2023

ZihanLi58 reviewed Jun 22, 2023

View reviewed changes

gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnAutoScalingManager.java Outdated Show resolved Hide resolved

ZihanLi58 reviewed Jun 22, 2023

View reviewed changes

Add comment

33674da

homatthew force-pushed the mh-ignore-deleted-workflows-GOBBLIN-1844 branch from 43a3e69 to 33674da Compare June 23, 2023 16:45

ZihanLi58 approved these changes Jun 23, 2023

View reviewed changes

ZihanLi58 merged commit 702cadf into apache:master Jun 26, 2023
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GOBBLIN-1844] Ignore workflows marked for deletion when calculating container count #3709

[GOBBLIN-1844] Ignore workflows marked for deletion when calculating container count #3709

homatthew commented Jun 21, 2023 •

edited

Loading

homatthew Jun 21, 2023

ZihanLi58 left a comment

ZihanLi58 left a comment

codecov-commenter commented Jun 23, 2023 •

edited

Loading

[GOBBLIN-1844] Ignore workflows marked for deletion when calculating container count #3709

[GOBBLIN-1844] Ignore workflows marked for deletion when calculating container count #3709

Conversation

homatthew commented Jun 21, 2023 • edited Loading

JIRA

Description

Tests

Commits

homatthew Jun 21, 2023

Choose a reason for hiding this comment

ZihanLi58 left a comment

Choose a reason for hiding this comment

ZihanLi58 left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jun 23, 2023 • edited Loading

Codecov Report

homatthew commented Jun 21, 2023 •

edited

Loading

codecov-commenter commented Jun 23, 2023 •

edited

Loading