[GOBBLIN-1855] Metadata writer tests do not work in isolation after upgrading to Iceberg 1.2.0

[homatthew]

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

• My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
  • https://issues.apache.org/jira/browse/GOBBLIN-XXX

Description

• Here are some details about my PR, including screenshots (if applicable):
  HiveMetaStoreTest from Iceberg had some minor changes to the class that affect the order of metastore creation. This did not break our CI because iceberg tests run as a group in ABC order, so one of the tests was properly starting the metastore. But going forward, we should call the method and have an empty catch in case another test already init the hive metastore.

This would cause a NPE when the tests were run in isolation.

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:
  

Commits

• My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

[codecov-commenter]

Codecov Report

Merging #3718 (bcb3ca3) into master (2c2ffac) will increase coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3718      +/-   ##
============================================
+ Coverage     46.79%   46.95%   +0.15%     
- Complexity    10793    10822      +29     
============================================
  Files          2143     2143              
  Lines         84528    84600      +72     
  Branches       9392     9404      +12     
============================================
+ Hits          39557    39724     +167     
+ Misses        41360    41252     -108     
- Partials       3611     3624      +13     

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ZihanLi58]

+1