Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-1872] Modify logs to improve multi-active debugging #3735

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

umustafi
Copy link
Contributor

@umustafi umustafi commented Aug 9, 2023

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Add, clean up, and move some log statements that would help debug issues with multi-active scheduler.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Merging #3735 (42b4d10) into master (01c433c) will increase coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##             master    #3735   +/-   ##
=========================================
  Coverage     47.08%   47.09%           
- Complexity    10862    10866    +4     
=========================================
  Files          2146     2146           
  Lines         84789    84792    +3     
  Branches       9409     9410    +1     
=========================================
+ Hits          39926    39935    +9     
+ Misses        41241    41235    -6     
  Partials       3622     3622           
Files Changed Coverage Δ
...pache/gobblin/runtime/kafka/HighLevelConsumer.java 0.00% <0.00%> (ø)
...vice/modules/orchestration/FlowTriggerHandler.java 2.81% <ø> (+0.07%) ⬆️
.../modules/scheduler/GobblinServiceJobScheduler.java 69.83% <0.00%> (-0.58%) ⬇️
...blin/runtime/api/MysqlMultiActiveLeaseArbiter.java 78.44% <100.00%> (+0.19%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Will-Lo Will-Lo merged commit c578e5d into apache:master Aug 11, 2023
6 checks passed
phet pushed a commit to phet/gobblin that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants